GitLab

Jean-Baptiste Kempf authored Aug 01, 2011 and Harald Sitter committed Aug 01, 2011

Signed-off-by: Harald Sitter <sitter@kde.org>

do not segfault when accessing an unitialized libvlc... this prevents crashes in the backend ctor, thus allowing for apps to be used even if vlc is kaput

if we could not init LibVLC or the libvlc_instance itself, simply do not return any objects to the frontend, that way we cannot crash :P

the only way to select an audio track at runtime in vlc is by selecting
the appropriate subitem of the media, however currently this is one
gigantic PITA, so we cannot do this until pvlc gets based on libcutevlc

meanwhile only one scenario is supported: setting the track *before*
play is called, this way we can simply inject the cdda-track option
in playInternal and be done with it

BUG: 276034
FIXED-IN: 0.4.1

BUG: 275312

This reverts commit f941d163.

dont make pause start playing if the state is paused and there is a media, that is not the way it should work according to phonon api documentation

As no one complained about broken things I must assume it is working
perfectly. :)

disconnect all signals of a videowidget upon disconnect as to avoid signal connection duplication etc.

Otherwise one could have a videowidget attached to one MO, try to set adjusts, disconnect the videowidget before video becomes available, connect to a MO with different source before video becomes available there and see settings applied to a wrong video.

Otherwise it could happen that a player tries to set the values so they end up in the pendings hash, then the user switches to another file before video is detected -> the settings are applied to the new video rather than the one they were targetting.