GitLab

As no one complained about broken things I must assume it is working
perfectly. :)

disconnect all signals of a videowidget upon disconnect as to avoid signal connection duplication etc.

Otherwise one could have a videowidget attached to one MO, try to set adjusts, disconnect the videowidget before video becomes available, connect to a MO with different source before video becomes available there and see settings applied to a wrong video.

Otherwise it could happen that a player tries to set the values so they end up in the pendings hash, then the user switches to another file before video is detected -> the settings are applied to the new video rather than the one they were targetting.

I have no idea what aspectratiowidget is supposed to do, much less how we should do it in libvlc

Instead of messing around with percent values, make use of the fact that we either
normalize -1..1 to 0..2 or 0..1, hence a simple multiplication with either the
upper boundary or half the boudary is sufficient to scale the normalized values
to the target range.

Additionally stop setting the upper boundary by default to 2.0, it makes the calling rather confusing.

Document the magic so that everyone knows why things are the way they are. Additionally fix the logic to remain working on fixed libvlc versions.

This was previous done in the addSubtitle metafunction -> got removed

It actually is more of a patch for the problem as the libphonon design is heavily flawed in that it exposes MediaController specific descriptors to the world also via the backend. Now as the Backend is a singleton but the MC is not, there is a bit of a scope problem... The present solution thus introduces a global overlord master subtitle manager where each MC needs to store its subtitles. Additionally libvlc seems broken as it reports completely bogus SPU ids \o/

The code at hand needs refactoring && bugfixing && cleanup && documentation && *whine*

BUG: 267424

only return false on read requests to vlc if both eos is set and the buffer is empty. patch by kevin_b

This reverts commit 7d1af9c7.

Unbreak video in dragon player, pending an actual rationale in which this fails and a proper fix.

msv doesnt like dynamic arrays, so we just hardcode the libvlc arguments to 64, a new assert will fall over if the argument qstringlist actually exceeds the char** in size

Should fix a bug when starting video playback with a large vlc window
appearing out of nowhere. That happened sometimes because playback was
starting when the video widget wasn't being shown yet and didn't have a
valid window ID.

Remove Backend::logMessage().
Convert the old Backend::m_debugLevel to Debug::DebugLevel.
Small adjustments to the debug things, including null debug.
PHONON_VLC_DEBUG env has the same functionality, except for the value 2,
where it has some less output.
__FUNCTION__ --> Q_FUNC_INFO everywhere

Limited testing done, but it's just debug stuff.

Patch by Yuri Chornoivan