GitLab

backport plasma/plasma-pa@5bdd1368

Backport 208ae94b05765758dfd16d4ace2413a3c17f230f and d0140c034860cfab1aab5d7fe03b57df884798be from plasma-pa

Introduce IndexedPulseObject since not all PulseObjects actually have an
index.

Make sure information is correctly passed to the superclasses.

Remove redundant code in CardPort

All subclasses have it, so move it to the superclass

Use the Context singleton directly

Just set volume for all of them.
Otherwise when just calling setMuted, we will send the original volume struct, which might have multiple channels,
with a hardcoded channel map that only has one channel. PulseAudio then refuses to write the settings.

Differential Revision: https://phabricator.kde.org/D20262

This is what pavucontrol is doing too.

BUG: 383787
FIXED-IN: 5.11

Differential Revision: https://phabricator.kde.org/D7485

Use QList<qreal> instead of QList<qint64> which is not supported by QML.

Differential Revision: https://phabricator.kde.org/D5665

Applet updates mute state with every volume change - it does
writeChanges(volume) immediately following with writeChanges(mute)
and it seems to make PulseAudio to ignore the volume change.
This makes sure that writeChanges() is only called when something really
changed.

BUG: 367688
FIXED-IN: 5.10.0

Differential Revision: https://phabricator.kde.org/D5657

pa_ext_stream_restore have only one function to change all its
properties, so we need to cache values between clients changing
StreamRestore properties and pulseaudio actually signaling the property
was changed.

Fixes correctly muting Notification Sounds stream in KCM when moving
slider to 0 value, because in that moment the KCM first sets volume to 0
and then immediately mute to true.

Differential Revision: https://phabricator.kde.org/D4674

Summary:
Due to a lack of pa_channel_map::&operator==() the code does a memcmp on
the cached m_channelMap to the new version in the update to see if it needs
updating.

As our struct starts of uninitialised, vagrlind prints a correct warning
about comparing uninitialised data. However, given our garbage data is
unlikely to match the update, it's not a bug that has a lot of impact.

Test Plan: valgrind plasmashell is quieter

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2796

It is now possible to change volume of notification sounds.

BUG: 355470
FIXED-IN: 5.7.0

Differential Revision: https://phabricator.kde.org/D1366