We don't use ReviewBoard any more

That's what the cmake file is for

Finding a Qca Qt6 build leads to errors if Qt5Compat has not been loaded
before by the project.

Allen Winter authored May 02, 2022 and Albert Astals Cid committed May 02, 2022

Encountered when testing with the vcpkg provided openssl.
The vcpkg built opensll package (on linux anyway) does
not provide the API for cast5 support.

And other simplifications that can be done that didn't really need a
QRegExp

Tobias Junghans authored Jan 10, 2022 and Albert Astals Cid committed Jan 10, 2022

Qt uses qintptr for the socket file descriptor.

The argument is not used by any user of the SafeSocketNotifier class so we can eliminate it to fix a compile error when building for the x86_64-w64-mingw32 architecture caused by the new QSocketNotifier::activated() overload.

Tobias Junghans authored Jan 10, 2022 and Albert Astals Cid committed Jan 10, 2022

Replace CMake variable QT6 with common BUILD_WITH_QT6 and
QT_MAJOR_VERSION variables:

  - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/linux-qt6.yml
  - https://invent.kde.org/frameworks/extra-cmake-modules/-/raw/master/modules/QtVersionOption.cmake

Keep checking the QT6 variable for compatibility reasons.

Allen Winter authored Jan 10, 2022 and Albert Astals Cid committed Jan 10, 2022

the cms unittest needs to look for OpenSSL since only the
plugins do that so far. NOTE: that the cms change can be
reverted once we no longer support openssl < 1.1.1i

Allen Winter authored Jan 08, 2022 and Albert Astals Cid committed Jan 09, 2022

Fix the CMake error:
"CMake Error at cmake/modules/QcaMacro.cmake:73
(get_target_property): The LOCATION property may not be read
from target "qca-qt5". Use the target name directly with
add_custom_command, or use the generator"

resurrects code from 1137ed5f

This reverts commit acbbd4ae.

We want to keep a CI builder at out baselines level
  i.e. Qt 5.14, cmake 3.16, etc.

Ubuntu 20.10 is EOL so no packages can be installed any longer.

GIT_SILENT

The default provider is not included in QCA::providers

For some reason they had not been caught before

debian broke the non numbered binary

Makes clang 13 happier

We don't use Phabricator any more

Qt 6.3 wants the dependent projects to use the same CMake policies
as the ones used to build Qt. To do that, an error is thrown if
the minimum CMake version doesn't match the qtbase one on platforms
using shared libraries.

Fabian Vogt authored Sep 15, 2021 and Albert Astals Cid committed Sep 16, 2021

Use QSignalSpy::wait to avoid waiting needlessly.
Reduce time to wait for (expected and unexpected) signals to 2s.

Those are not used with OPENSSL_FIPS.

By using a lambda this way, it'll be stored in the unique_ptr instances.
Use a custom deleter type instead to avoid that.

Qt 6 doesn't provide pkgconfig files.

Tobias Junghans authored May 10, 2021 and Albert Astals Cid committed May 29, 2021

The Core5Compat module is still required for QTextCodec and some
difficult remaining QRegExp -> QRegularExpression migrations.

Tobias Junghans authored May 10, 2021 and Albert Astals Cid committed May 29, 2021

Still a few occurrences of QRegExp and QTextCodec need to be replaced
in order to drop the dependency on the Core5Compat module. Besides this
QCA builds fine with Qt 6.1 and passes all tests.