Skip to content
  • Linus Jahn's avatar
    d7bfdba8
    JingleIq/Rtp'Muting: Do not default init 'isMute' like 'creator' (breaking) · d7bfdba8
    Linus Jahn authored
    Otherwise this looks like the struct has default initializers for all
    attributes and so one might forget to initialize creator (as happened in
    the parsing code). Having a default to prefer one of the creator
    enumerations (or having a default for isMute) doesn't really make sense.
    People should just initialize both values.
    
    Technically this is a breaking change, but I doubt anyone has actually
    used this API yet (should be marked in changelog though).
    d7bfdba8
    JingleIq/Rtp'Muting: Do not default init 'isMute' like 'creator' (breaking)
    Linus Jahn authored
    Otherwise this looks like the struct has default initializers for all
    attributes and so one might forget to initialize creator (as happened in
    the parsing code). Having a default to prefer one of the creator
    enumerations (or having a default for isMute) doesn't really make sense.
    People should just initialize both values.
    
    Technically this is a breaking change, but I doubt anyone has actually
    used this API yet (should be marked in changelog though).
To find the state of this project's repository at the time of any of these versions, check out the tags.
Loading