1. 14 Nov, 2020 1 commit
  2. 13 Nov, 2020 2 commits
    • Agata Cacko's avatar
      Improve performance of MyPaint shade selector · d760a761
      Agata Cacko authored
      Before this commit, MyPaint shade selector would be drawn using
      the setPixel() method instead of a sequential iterator.
      That caused performance issues on high dpi displays.
      
      This commit fixes it by using the iterator instead of setPixel().
      d760a761
    • Agata Cacko's avatar
      Fix triangle color selector not reacting to mouse events · 5a4fe7ee
      Agata Cacko authored
      Before this commit, there was an issue with selecting the colors from
      the left and top areas. It was possible to move to them only if the user
      dragged the point from the right-bottom area. This was a regression
      from ae1b3c71.
      
      This commit fixes this behaviour by making sure that the "constainsPoint"
      method returns true for all the appropriate points even on high dpi
      displays.
      5a4fe7ee
  3. 12 Nov, 2020 2 commits
  4. 11 Nov, 2020 4 commits
    • Agata Cacko's avatar
      Initialize m_firstRedo in FlipFlopCommand · 02049883
      Agata Cacko authored
      Before this commit one constructor of the FlipFlopCommand
      initialized m_firstRedo to true, and the other constructor
      didn't initialize it at all.
      This commit removes the initialization of m_firstRedo in the
      initialization list of the constructor and instead initializes it
      in the place of definition.
      
      Since constructors don't seem to be doing something different - both
      take one parameter telling if the command is finalizing or not, and
      a parent command - I assumed that both would want m_firstRedo to be
      initialized to the same value, which is 'true'. However considering
      that I believe most compilers would initialize the value to false,
      this can change the behaviour, so this commit might not be.
      
      CID 248600
      02049883
    • Agata Cacko's avatar
      Remove unused timedID variable from KUndo2Stack · 3528dcf6
      Agata Cacko authored
      Before this commit, there was an unused variable called timedID
      in KUndo2Stack. There was another one called m_timedID which was used
      multiple times and exposed outside via timedID() and setTimedID()
      functions.
      This commit removes that variable and initializes all other variables.
      
      CID 248789
      CID 248587
      3528dcf6
    • Agata Cacko's avatar
      Fix passing big parameters by value in selection action factories · ebfec95b
      Agata Cacko authored
      This commit just converts it from passing by value to passing by
      reference.
      
      CID 248826
      CID 248556
      ebfec95b
    • Dmitry Kazakov's avatar
      Fix assert when requesting liquify mode on an empty layer · f645aa3c
      Dmitry Kazakov authored
      The assert was rather harmless, it just checked if the liquify
      mode was initialized or not. Before the recent changes in the
      transform tool, currentArgs.isIdentity() could not be called
      in case of sckipped initialization, but now it is possible. Just
      consider the transformation as identity in case initialization was
      skipped.
      
      BUG:428685
      
      # Conflicts:
      #	plugins/tools/tool_transform2/tool_transform_args.cc
      f645aa3c
  5. 10 Nov, 2020 3 commits
  6. 09 Nov, 2020 18 commits
  7. 08 Nov, 2020 5 commits
    • Alvin Wong's avatar
      Fix AppImage build script errors · 322c5062
      Alvin Wong authored
      322c5062
    • Alvin Wong's avatar
      Fix build of KisAppimageUpdaterTest when git hash not detected · c3321c04
      Alvin Wong authored
      This can happen when using git-worktree and building inside docker with
      the git dir not setup properly.
      c3321c04
    • Agata Cacko's avatar
      Fix ugly edge of MyPaint shade selector · 085cdbaa
      Agata Cacko authored
      Before this commit, the MyPaint shade selector would have an ugly edge
      on the inside circle. That was because the anti-aliasing is done
      manually, and the saturation value was the same for pixel of the inside
      circle and the pixel of the background, even though the pixel of the
      background should have the saturation value reset to the saturation of
      the original color.
      This commit fixes this behaviour by resetting the saturation value
      to the saturation of the original color (note that h, s, and v in the
      code represent changes, not absolute values; hence resetting to 0
      is the correct behaviour).
      085cdbaa
    • Agata Cacko's avatar
      Draw MyPaint shade selector in high res on high dpi displays · ae1b3c71
      Agata Cacko authored
      Before this commit, MyPaint shade selector would be drawn with low
      resolution on high dpi displays.
      This commit fixes this behaviour so the selector is always drawn with
      the highest possible resolution.
      ae1b3c71
    • Agata Cacko's avatar
      Fix MyPaint shade selector changing look on resizing · eb657062
      Agata Cacko authored
      Before this commit, MyPaint shade selector would look differently
      depending on the ratio of height and width (horizontal stripes)
      or depending on the actual pixel length of the stripe
      (diagonal stripes).
      
      This commit fixes that behaviour by making sure that the ratio at which
      colors change is consistent with different sizes of MyPaint selector.
      The ratio is now calculated using the proportion of the distance
      of the pixel from the center, to the distance between the center
      to the closest edge.
      eb657062
  8. 07 Nov, 2020 3 commits
  9. 06 Nov, 2020 2 commits