Christian Muehlhaeuser authored Nov 06, 2022 and Kurt Hindenburg committed Nov 25, 2022

Avoids magic numbers and tracks OSC codes in an enum.

Luis Javier Merino authored Nov 12, 2022 and Kurt Hindenburg committed Nov 25, 2022

Fixes a potential crash when opening the right mouse button context menu
just after launching some process in the shell, before konsole has had
any chance to update the foreground process group information.

BUG: 454122
BUG: 458157

Friedrich W. H. Kossebau authored Nov 20, 2022 and Kurt Hindenburg committed Nov 25, 2022

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

MainWindow::wasWindowGeometrySaved() doesn't take into account the currently connected outputs. So
when Konsole starts after hotplugging a new output, wasWindowGeometrySaved() will erroneously return
true and resize(sizeHint()) in MainWindow::showEvent() won't be called thus resulting in Konsole
starting with wrong size.

This change makes Konsole take the current output layout into account when deciding whether the
geometry has been restored (logic was copied from KWindowConfig), however it indicates that we have
some fundamental issues in KMainWindow or KWindowConfig as it's a really messy way to determine
whether the previous state has been properly restored.

BUG: 460428

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Luis Javier Merino authored Nov 10, 2022 and Kurt Hindenburg committed Nov 10, 2022

Commits 4e69f47b and 9046680f where using an incorrect start of buffer
when trimming trailing spaces and trailing empty cells in a line from
the scrollback buffer.  This could cause too short of a text to be
copied from the selection when there were trailing spaces in the
selection.

BUG: 461542
CCBUG: 455165

- The meaning of wordModeAttr was reversed.
- The foregroundColor field includes the reverse flag, so no need to
  consider this flag when comparing character's attributes.
- Draw the cursor separately from the text characters, since drawing it
  in drawTextCharacters() is incompatible with word mode.

There are three positions for each character:
- Logical (where it is in the text, extended characters count as one)
- Visual (where it is on the screen)
- Line (where it is in the text, extended characters are expanded).

In TerminalDisplay::bidiMap, the calculation of visual to line map, used
logical instead of visual in one place. This causes using an uninitialized
memory as an index to an array, as well as other issues.

When no extended characters are used, line and logical are the same. When
no bidi characters (Arabic or Hebrew) are used, visual and logical are the
same.

BUG: 461478

Christian Muehlhaeuser authored Nov 01, 2022 and Kurt Hindenburg committed Nov 09, 2022

Implement OSC-777, which lets you trigger a system notification.
Already supported by other terminals like kitty, foot, urxvt.

You can easily try this out by running this in your bash:

printf '\x1b]777;notify;Hello;World\x1b\\'

See:
https://chromium.googlesource.com/apps/libapps/+/HEAD/hterm/docs/ControlSequences.md#OSC
https://github.com/kovidgoyal/kitty/blob/9d98aa315922119e8a845046416432548d665b36/kitty/window.py#L811

Matan Ziv-Av authored Nov 08, 2022 and Kurt Hindenburg committed Nov 08, 2022

(cherry picked from commit 4cbc3742)

Luis Javier Merino authored Nov 06, 2022 and Kurt Hindenburg committed Nov 08, 2022

When URLs were inside single quotes, we would include the ending quote
in the parsed URL.  To avoid that, remove a final apostrophe in a URL
when creating the hotspot.

Test:
'https://en.wikipedia.org/wiki/Earth's_rotation'

BUG: 458996

Nicolas Fella authored Nov 05, 2022 and Kurt Hindenburg committed Nov 08, 2022

Somwhat ironically removing this fixes the main window appearing together with the confirmation dialog when the window is closed while minimized

Matan Ziv-Av authored Nov 06, 2022 and Kurt Hindenburg committed Nov 08, 2022

- Change Brahmic ranges according to !764 (comment 558117)
- Use symbolic bitmap values,instead of a magic number.
- Fix a crash with wordModeAttr enabled and bidi disabled

Matan Ziv-Av authored Nov 05, 2022 and Kurt Hindenburg committed Nov 08, 2022

A character is sent once, and rendered many times, so this is the best
place for the calculation, though it is used only when rendering.

Matan Ziv-Av authored Nov 05, 2022 and Kurt Hindenburg committed Nov 08, 2022

- Word mode to render (some) words with one drawText() call, instead of
  one per character.
- Ascii - to render words of ASCII characters
- Brahmic - to render words of Brahmic scripts characters.
- Option to consider attribute (color, bold, etc.) as word boundary.