1. 17 Jul, 2018 1 commit
  2. 22 Jan, 2017 1 commit
    • Boudewijn Rempt's avatar
      BUG:375253 Work around a bug in QTransform · ac257511
      Boudewijn Rempt authored
      Weirdly enough, this bug only occurs on Windows 10 with the latest
      Wacom drivers and an older Wacom Intuos 3 or Cintiq tablet. At least,
      that's what we suspect. Somehow the input from this drivers drives
      the roation sensor crazy, and set rotation to NaN.
      
      So, first step: check whether the resulting rect is valid, we now return
      a 0,0 1x1 rect.
      
      Second step: check whether the rotation value happens to be NaN and
      return 0 in that case.
      
      Third step: make sure that the rotationLikeValue() function doesn't return
      NaN -- that is in the next commit.
      ac257511
  3. 20 Jan, 2017 1 commit
  4. 19 Jan, 2017 2 commits
    • Boudewijn Rempt's avatar
      Fix noisy warning · a115ebed
      Boudewijn Rempt authored
      a115ebed
    • Boudewijn Rempt's avatar
      CCBUG:375253 Replace asserts with warnings. · 893bc79a
      Boudewijn Rempt authored
      Despite the asserts being of the KIS_ASSERT_RECOVER_NOOP type,
      they lead to a hard assert without a message being shown in our
      windows builds. I do not know why that is, but it means that this
      check gives a crash without any information.
      
      So, for now, let's disable the asserts so we can test what is really
      going on.
      893bc79a
  5. 26 Sep, 2016 1 commit
    • Nishant Rodrigues's avatar
      Undo rename of KisGrbBrush · f1657cb3
      Nishant Rodrigues authored
      I hadn't realised that there were multiple types of Gimp brushes, until
      Boudewijn pointed it out. (I had actually indended to push this branch
      to master but messed up the git push command. Sorry about that.)
      
      Revert "Rename KisGbrBrus to KisGimpBrush for clarity"
      This reverts commit 3f761273.
      f1657cb3
  6. 25 Sep, 2016 2 commits
  7. 16 Aug, 2016 1 commit
  8. 21 Jul, 2016 2 commits
  9. 26 May, 2016 1 commit
  10. 25 Jan, 2016 1 commit
  11. 04 Sep, 2015 1 commit
    • Boudewijn Rempt's avatar
      Port away from kdebug to qcdebug · 4fa86a75
      Boudewijn Rempt authored
      The approach taken is a bit different from what's in the porting
      scripts or in pigment: I've moved kis_debug to libglobal and adapted
      the dbgKrita etc. defines to use qcDebug etc. I've kept the old
      category numbers for now. I've also ported all places where we
      used kDebug() etc. directly, and not a few places where qDebug() etc
      were used directly.
      4fa86a75
  12. 09 Mar, 2015 1 commit
    • Boudewijn Rempt's avatar
      Hide warning · d4d07866
      Boudewijn Rempt authored
      This kind of warning should only be seen by developers when debugging a
      particular problem, not by every user who starts krita from a terminal.
      d4d07866
  13. 05 Oct, 2014 1 commit
  14. 03 Sep, 2014 1 commit
    • Dmitry Kazakov's avatar
      Last (hope so) fixes for the predefines brushes · 70d25713
      Dmitry Kazakov authored
      Fixes:
      
      1) Use correct scale for the LOD-sourced transformation (taking LOD
         rounding into account)
      
      2) Workaround Qt's bug when the Translate-only QTransform produces
         low-quality sampling
      
      3) Use non-rounded brush size for calculating Hot Spot
      
      4) Calculate mirroring offset correctly (NOTE: current solution will
         not work, if one day hotspot will become non-symmetric).
      70d25713
  15. 02 Sep, 2014 1 commit
    • Dmitry Kazakov's avatar
      Remove rounding of the brush scale · 399e1f72
      Dmitry Kazakov authored
      It was incorrect to round the brush scale, because it affects the
      precision of the line. The bug was not seen in auto brushes, but
      it affected Predefined Brushes, since they use the resulting transform
      directly.
      
      BUG:322839
      399e1f72
  16. 20 Aug, 2014 1 commit
    • Dmitry Kazakov's avatar
      Fixed antialiasing of auto-brush based brushes · 052f2177
      Dmitry Kazakov authored
      This patch does two changes:
      
      1) Add 1 px fading to every auto brush
      2) Implement "Auto" spacing mode. In this mode the spacing is calculated
         using a different formula. Instead of usual sp = k * size, we use
         sp = k * sqrt(size). This formula gives an excellent line quality
         and shows quite nice performance
      3) Use qreal's for calculation of the spacing instad of using dab's size.
         Dab's size is rather unstable on sizes around 1.0 - 5.0.
      
      TODO:
      
      1) Port Vc implementation of the auto brush to use a new formula
      2) Activate "Auto" spacing mode for all the default presets in Krita
      3) Port the other brushes
      
      CCMAIL:kimageshop@kde.org
      052f2177
  17. 02 Jun, 2014 1 commit
    • Boudewijn Rempt's avatar
      Load brushes and presets in the gui thread, in the right order · ac880641
      Boudewijn Rempt authored
      The brush server needed access to the KisResourceServerProvider singleton
      in its constructor, while in the constructor of KisResourceServerProvider,
      the loading of presets needed to have all the brushes loaded.
      
      This commit moves libbrush to the krita/image and krita/ui level and
      makes kritaui link to libbrush instead of the other way around. Now
      we can load the brushes and then the presets.
      
      This makes start a bit slower... But on the other hand, you cannot crash
      Krita anymore by closing it while the presets are still being loaded.
      ac880641
  18. 14 Feb, 2014 1 commit
    • Boudewijn Rempt's avatar
      BUG:330661 Save multi-sensor configuration correctly · 5db9a905
      Boudewijn Rempt authored
      Big rewrite & cleanup of the sensors/libpaintop code...
      
      The KisDynamicSensorList class is gone and KisCurveOption now tracks
      all sensors. The KisMultiSensorModel doesn't own the data it is a model
      for anymore everything is tracked by KisCurveOption.
      
      Conflicts:
      	krita/plugins/paintops/spray/kis_spray_paintop_settings_widget.cpp
      	krita/plugins/paintops/spray/kis_sprayop_option.cpp
      	krita/plugins/paintops/spray/spray_brush.cpp
      	krita/plugins/paintops/spray/spray_brush.h
      5db9a905
  19. 24 Dec, 2013 1 commit
  20. 22 Dec, 2013 1 commit
  21. 14 Nov, 2013 1 commit
  22. 17 Jul, 2013 1 commit
  23. 16 Jul, 2013 3 commits
    • Dmitry Kazakov's avatar
      Properly fix the broken predefined brush issue reported by David · 4f57ae25
      Dmitry Kazakov authored
      Do not fast-path return the image if it is not in rgba8 format
      4f57ae25
    • Dmitry Kazakov's avatar
      Temporary fix for the predefined brush artifacts · ddb649db
      Dmitry Kazakov authored
      It looks like there is an implicit sharing + multithreading
      problem somewhere.
      ddb649db
    • Dmitry Kazakov's avatar
      A significant refactoring in the Predefined Brush engine · 6416a4ae
      Dmitry Kazakov authored
      This patch ports the predefined brush engine to the new capabilities
      of Qt. It removes a huge chunk of hand-written code. Here is a short list
      of changes:
      
      1) All the operations are now performed on non-premultiplied RGB values.
         The use of premultiplication resulted in instability of the color,
         which caused artifacts on scaling and rotation of the brushes.
      
      2) Trilinear filtering of the brushes is now substituted with simple
         bilinear filtering from the nearest pyramid level.
      
         It turned out that trilinear filtering not only impacted the
         performance, but also introduced heavy aliasing artifacts on specific
         zoom levels.
      
      3) After the patch the speed of the dab generation raised 3-5 times. Here
         are the values for 512px brush:
         Before patch:
            Scaling:   34 ms
            Rotation:  19 ms
         After patch:
            Scaling:   6 ms
            Rotation:  9 ms
      
      CCBUG:320651
      BUG:320368,319944,300665
      CCMAIL:kimageshop@kde.org
      6416a4ae