1. 11 Sep, 2019 2 commits
  2. 09 Sep, 2019 6 commits
  3. 06 Sep, 2019 3 commits
    • Dmitry Kazakov's avatar
      Remove XCB library from the list of dependencies · ca902a45
      Dmitry Kazakov authored
      We don't use it anymore (all the tablet code has been merged back
      into Qt).
      ca902a45
    • Dmitry Kazakov's avatar
      Fix crash after cropping a specific image · 0f9c5472
      Dmitry Kazakov authored
      This patch ends the era of the custom "empty extent" value
      QRect(quint32_MAX, quint32_MAX, 0, 0). When I started refactoring
      tile engine ten years ago in 2009, this "empty extent" flag was
      already present. It was just a result of the way how extent was
      calculated those days. I guess it was also considered as
      an "optimization", or as "a flag" that could ease debugging a bit
      (and it actually did help debugging a couple of times).
      
      Years passed by and I considered to remove this custom value multiple
      times. It was always causing troubles, because the QRect is not safe
      against integer oveflows. But the problem was, there was code outside
      tiles engine that relied on this behavior. So I was always scared of
      the actual removal. Even when the tile engine was rewritten again
      to become lockfree in 2017, I insisted on keeping the old behavior...
      
      So, it looks like now all code that relies on this custom value is gone,
      so it should be safe to remove it.
      
      Funny side, I guess it was one of few artifacts that were still kept
      in Krita since 'tiles' and 'tiles_new' days (has anyone ever wondered
      why the engine's folder is called 'tiles3'?) ;)
      
      BUG:411536
      0f9c5472
    • Dmitry Kazakov's avatar
      Remove unused code · 46cc3890
      Dmitry Kazakov authored
      46cc3890
  4. 05 Sep, 2019 27 commits
  5. 04 Sep, 2019 2 commits
    • Wolthera van Hövell's avatar
      Possibly fix File Layer loading and comics manager page updating on windows. · ff338de7
      Wolthera van Hövell authored
      Windows has a pretty slow file system, which means when we check whether
      our updated file exists, windows hasn't gotten to renaming it yet, making
      Krita think there's no file at all...
      
      So this puts a little bit of a delay in our two checks of whether the file still
      exists and needs to be readded to the filesystemwatcher again.
      
      This currently works as expected on Linux, now we need to test if it works
      on Windows.
      
      CCBUG:410409
      CCBUG:389544
      ff338de7
    • Boudewijn Rempt's avatar
      Fix memory leak · 7bdebbc0
      Boudewijn Rempt authored
      Since these two actions aren't added to any menu or action registry,
      they are dangling and need a parent
      7bdebbc0