GitLab

GIT_SILENT

BUG: 423122
FIXED-IN: 5.20

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

FEATURE: 419718

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Properly mark as changed when the user checks or unchecks
a specific runner.

GIT_SILENT

BUG: 399554

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 422398

Summary:
This patch implements the part of T12441 that was virtually universally agreed-to:
switching out the regular Task Manager for an Icons-Only Task Manager and pinning
some apps by default. The panel is also thickened to to 46px (with the default font,
since the calculation is based on GridUnits, which are font-aware). The panel remains
in its current position pending further discussion about whether or not we want to
move it to the left edge.

Ideally I'd like for this patch to used for discussions about the implementation, not the
general concept, so if you have concerns about that, please put them in T12441.

Test Plan: This is now the default panel: {F8290193}

Reviewers: #vdg, #plasma, niccolove, cblack

Reviewed By: #vdg, #plasma, niccolove, cblack

Subscribers: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, The-Feren-OS-Dev, plasma-devel

Tags: #plasma

Maniphest Tasks: T12441

Differential Revision: https://phabricator.kde.org/D27845

Summary:
We receive many complaints and bug reports about the current UI for adjusting panel
thickness. People don't figure out that they have to drag on the button, and when they do,
they complain that it's too hard to set the value finely enough.

This patch removes the draggable button and replaces it with a more conventional SpinBox,
which in D29534 is given ability to adjust the values by scrolling over it or clicking and
dragging. This yields the following improvements:
- The way you adjust panel thickness is now more obvious
- The existing drag-to-adjust behavior is much nicer and less buggy
- Panel thickness can now be specified numerically
- Fine-tuning panel thickness is now easier using any adjustment method
- We have one fewer custom control to maintain
- Bugs in custom scrolling implementation go away

Touch friendliness is maintained because this SpinBox has an inherently touch-friendly design
with large touchable buttons that can be held down to quickly adjust the value, and touch-and
-drag still works after D29534 is applied.

I wouldn't mind using this SpinBox design elsewhere too; see T9460.

BUG: 418700
BUG: 421169
FIXED-IN: 5.19

Test Plan:
{F8301480}
{F8301388}

Reviewers: abetts, #vdg, #plasma, mart

Reviewed By: #vdg, #plasma, mart

Subscribers: mart, ahiemstra, cblack, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29535

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 422656

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

- setupBindings() was deprecated in 5.45, plasma-desktop requires 5.71
- follow the suggested KDeclarative replacement of setupBindings()

- The q-pointer isn't used right now, so Clang complains about it;
  removing it is an option, but then we might get surprising ping-pongs
  if more functionality is added to the private class. Use Q_UNUSED instead.

The prototype for crypt(3) is in <unistd.h> on Linux and FreeBSD.
The <crypt.h> header isn't needed at all. There's also machinery
for detecting the presence of <crypt.h>, defining HAVE_CRYPT_H,
but we don't need that.

Reported and resolved independently in
	https://phabricator.kde.org/D29847

@nicofe tested that this works on Linux
@adridg tested that this works on FreeBSD

- from local directory, use "" (esp. the header file for this .cpp)

- Missing letter "w" and "W" in list of characters meant only 62
  letters, so less than 6 bits of randomness per salt char.
- A char array like this one still has a trailing NUL char which
  affects the sizeof. Since bounded produces a number < its second
  argument, need to discount the NUL so we only index into
  the letters-part of the string.

Add static_assert() to catch this.

 - the array of salt chars should be const, it's read-only
 - the array of salt chars should be static, since it is
   initialized to a constant value anyway and can live beyond
   this one function
 - sizeof(char) is 1 by the standard, so remove the weird
   array-size calculation: here saltCharacters has type
   (const) char[63], and its sizeof() is 63