Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
E
Elisa
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Matthieu Gallien
Elisa
Commits
6254e03f
Commit
6254e03f
authored
Aug 19, 2019
by
Matthieu Gallien
🎵
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix failing test in autotests/mediaplaylisttest.cpp
parent
caf86cbd
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
3 deletions
+2
-3
autotests/mediaplaylisttest.cpp
autotests/mediaplaylisttest.cpp
+1
-1
src/mediaplaylist.cpp
src/mediaplaylist.cpp
+1
-2
No files found.
autotests/mediaplaylisttest.cpp
View file @
6254e03f
...
...
@@ -4095,7 +4095,7 @@ void MediaPlayListTest::testSetData()
QCOMPARE(myPlayList.data(myPlayList.index(1, 0), MediaPlayList::ColumnsRoles::IsPlayingRole).toBool(), false);
QCOMPARE(myPlayList.data(myPlayList.index(2, 0), MediaPlayList::ColumnsRoles::IsPlayingRole).toBool(), true);
QCOMPARE
(
myPlayList
.
setData
(
myPlayList
.
index
(
2
,
0
),
true
,
MediaPlayList
::
ColumnsRoles
::
Title
Role
),
false
);
QCOMPARE(myPlayList.setData(myPlayList.index(2, 0), true, MediaPlayList::ColumnsRoles::
SecondaryText
Role), false);
QCOMPARE(rowsAboutToBeRemovedSpy.count(), 0);
QCOMPARE(rowsAboutToBeMovedSpy.count(), 0);
...
...
src/mediaplaylist.cpp
View file @
6254e03f
...
...
@@ -220,8 +220,7 @@ bool MediaPlayList::setData(const QModelIndex &index, const QVariant &value, int
return
modelModified
;
}
if
((
role
!=
ColumnsRoles
::
TitleRole
&&
role
!=
ColumnsRoles
::
ArtistRole
)
&&
(
role
<
ColumnsRoles
::
IsValidRole
||
role
>
ColumnsRoles
::
IsPlayingRole
))
{
if
(
role
<
ColumnsRoles
::
IsValidRole
||
role
>
ColumnsRoles
::
IsPlayingRole
)
{
return
modelModified
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment