Skip to content

GitLab

Switch branch/tag
  1. 25 Aug, 2019 1 commit
  3. 23 Aug, 2019 2 commits
  5. 22 Aug, 2019 4 commits
  7. 19 Aug, 2019 4 commits
  9. 18 Aug, 2019 1 commit
  11. 17 Aug, 2019 6 commits
  13. 14 Aug, 2019 4 commits
  15. 13 Aug, 2019 2 commits
  17. 09 Aug, 2019 1 commit
  19. 08 Aug, 2019 1 commit
    • Alexander Stippich's avatar
      Use standard icon names · 3cd39553
      Alexander Stippich authored 
      Summary:
Try to avoid icon names containing "amarok" in order to
use more common icon names, which they are symlink of.
Only remaining icon is "media-show-active-track-amarok"
for which there is no standard replacement.

Reviewers: ngraham, mgallien

Reviewed By: ngraham, mgallien

Differential Revision: https://phabricator.kde.org/D22921
      3cd39553
  21. 06 Aug, 2019 4 commits
    • Nate Graham's avatar
      Make it easier to click on a new position for the playback and volume sliders · 67565a46
      Nate Graham authored 
      Summary:
Because Elisa uses customized visuals for its sliders, various nice features of the
default implementation need to be re-implemented. One example is mouse wheel/scroll
handling, which was done in D22332. Another example is expanded click areas, which is
the target of this patch.

This patch makes the effective click targets fill the entire available space. This makes
it vastly easier to move the slider to a new position with a click.

BUG: 408703

Test Plan:
- It's 1000% easier to click to get a new slider position
- Still looks good with Breeze light and dark color schemes

Reviewers: #elisa, #vdg, mgallien, astippich

Reviewed By: #elisa, mgallien

Differential Revision: https://phabricator.kde.org/D22951
      67565a46
    • Matthieu Gallien's avatar
      fix the compilation album insertion · 61f06336
      Matthieu Gallien authored 
      Summary:
partial fix for handling albums without album artist

partially handle the case of compilations not getting Various Artists as
album artist

BUG: 409147

Test Plan: all tests are fine and most common cases should be covered.

Reviewers: #elisa, ngraham, astippich

Reviewed By: #elisa, ngraham

Differential Revision: https://phabricator.kde.org/D22499
      61f06336
    • Matthieu Gallien's avatar
      fix import of multi-valued data from existing Baloo db · c6e8f3e5
      Matthieu Gallien authored 
      Summary:
Values like the track artist can ba represented by a QStringList inside a QVariant (probably linked to an old baloo database).
In this case, the value imported in Elisa database is empty (a string list with multiple elements converted to a string gives an empty string).

Test Plan: with this patch, we get a correct string with all the values

Reviewers: #elisa, astippich, ngraham

Reviewed By: #elisa, ngraham

Differential Revision: https://phabricator.kde.org/D22972
      c6e8f3e5
    • Nate Graham's avatar
      Always use white color for headerbar text · 40f5d8e3
      Nate Graham authored 
      Summary:
Elisa uses the color scheme's highlighted text color for headerbar labels. This is not
semantically correct since this color relies on being above the color scheme's highlight
color to ensure adequate contrast. However the headerbar's blur does not do this; rather,
it always produces a dark-ish color. This causes issues for color schemes where the
highlight is light and the highlightext text color is dark, such as Materia Light.

This patch fixes the problem by always using a hardcoded white color, which always looks
good against the dark-ish blurry headerbar.

BUG: 410560

Test Plan:
Now looks good with the previously problematic Materia Light color scheme: {F7166959}

Worst-case scenario for contrast with white album art; headerbar still darkens it enough to make the text easily visible: {F7167007}

Reviewers: #vdg, #elisa, mgallien, astippich

Reviewed By: #elisa, mgallien

Differential Revision: https://phabricator.kde.org/D22949
      40f5d8e3
  23. 03 Aug, 2019 4 commits
  25. 31 Jul, 2019 2 commits
  27. 28 Jul, 2019 3 commits
  29. 27 Jul, 2019 1 commit