1. 07 Sep, 2019 1 commit
  2. 27 Aug, 2019 1 commit
  3. 26 Aug, 2019 1 commit
    • Alexander Stippich's avatar
      Rework shuffle handling · aa0cd617
      Alexander Stippich authored
      Summary:
      Remove deprecated usage of qrand().
      Keep a list of the previous, current and next track
      when in shuffle mode, to be used in a following patch.
      Simplify calling skip and previousTracks
      
      Depends on D22769
      
      Test Plan: all tests pass
      
      Reviewers: ngraham, mgallien
      
      Reviewed By: mgallien
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D22770
      aa0cd617
  4. 22 Aug, 2019 1 commit
    • Alexander Stippich's avatar
      Make MediaPlayList responsible for remaining tracks · 9e28b008
      Alexander Stippich authored
      Summary:
      Make MediaPlayList responsible for remaining tracks.
      Allows simplification by only reacting to currentTrack
      changes inside manageheaderbar.
      Add tests for remainingTracks and cleanup manageheaderbar.
      Fixes the remaining tracks showing when in playlist repeat
      or shuffle mode.
      
      Test Plan:
      tests pass
      Remaining tracks are only showed for when not in
      shuffle or repeat mode
      
      Reviewers: ngraham, mgallien
      
      Reviewed By: mgallien
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D22769
      9e28b008
  5. 19 Aug, 2019 1 commit
    • Jerome Guidon's avatar
      Add support for radio streams · 84001921
      Jerome Guidon authored
      Summary:
      Add support for radio streams
      
      Steps of development:
        - play a stream and get some information from it
        - Added a table for radios in the database (V13) with some examples in it.
        - Get the examples in the view and add/play them in the playlist.
      
      Test Plan: after the first reviews, add test for the radios view
      
      Reviewers: #elisa, #vdg, mgallien, astippich
      
      Reviewed By: #elisa, mgallien, astippich
      
      Subscribers: astippich, ngraham, mgallien, ndavis
      
      Maniphest Tasks: T7567
      
      Differential Revision: https://phabricator.kde.org/D21525
      84001921
  6. 06 Aug, 2019 1 commit
    • Matthieu Gallien's avatar
      fix the compilation album insertion · 61f06336
      Matthieu Gallien authored
      Summary:
      partial fix for handling albums without album artist
      
      partially handle the case of compilations not getting Various Artists as
      album artist
      
      BUG: 409147
      
      Test Plan: all tests are fine and most common cases should be covered.
      
      Reviewers: #elisa, ngraham, astippich
      
      Reviewed By: #elisa, ngraham
      
      Differential Revision: https://phabricator.kde.org/D22499
      61f06336
  7. 24 Jul, 2019 1 commit
  8. 28 Jun, 2019 1 commit
  9. 24 Jun, 2019 1 commit
    • Matthieu Gallien's avatar
      fix restore of tracks with missing metadata in playlist · a3eb443d
      Matthieu Gallien authored
      Summary:
      fix storing of tracks without track, disc, ...
      
      correctly store a null when track, disc, channels, bit rate, sample rate
      are not existing in the track data
      
      will need a complete reindexing to fix users database
      
      let play list and audio player restore state when track has few metadata
      
      when album, track number or disc number are missing, the state is not
      correctly restored at startup
      
      let those metadata be optional in the saved state such that tracks
      missing those are still restored
      
      Test Plan: new test is OK and a track without album, track and disc numbers will restore and playback will restore at correct position
      
      Reviewers: #elisa, astippich
      
      Reviewed By: astippich
      
      Subscribers: astippich, #elisa
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D21900
      a3eb443d
  10. 12 Apr, 2019 1 commit
    • Jerome Guidon's avatar
      Allow to undo the clear actions on the playlist · c8a43561
      Jerome Guidon authored
      Summary:
      When a clear action is performed on the playlist, the user might lose valuable work.
      Add the possibility to undo this operation via passive notification.
      Keep it simple by allowing only one undo and no redo.
      
       - The patch now enables to restore the playlist and the player status.
      For the notification, I use KNotification here, you can see in the screenshot the notification with an Undo button.
      
       - KNotification needs the file elisa.notifyrc to be installed in QStandardPaths::GenericDataLocation directory, so it may impact the packaging of the app (https://api.kde.org/frameworks/knotifications/html/classKNotification.html#file).
      
      Reviewers: mgallien
      
      Reviewed By: mgallien
      
      Subscribers: ngraham
      
      Tags: #elisa
      
      Maniphest Tasks: T5376
      
      Differential Revision: https://phabricator.kde.org/D19610
      c8a43561
  11. 01 Feb, 2019 1 commit
  12. 07 Jan, 2019 1 commit
  13. 30 Dec, 2018 1 commit
  14. 20 Dec, 2018 2 commits
  15. 19 Dec, 2018 1 commit
  16. 12 Dec, 2018 16 commits
  17. 31 Oct, 2018 1 commit
  18. 26 Sep, 2018 1 commit
  19. 13 Sep, 2018 1 commit
  20. 15 Jul, 2018 1 commit
  21. 08 May, 2018 1 commit
  22. 05 May, 2018 1 commit
    • Alexander Stippich's avatar
      move manageaudio to c++ · d41c7e06
      Alexander Stippich authored
      Summary: move the manageaudioplayer class to c++. with this, the main files responsible for playing audio are now in c++ only, with more to follow
      
      Test Plan: audio still plays
      
      Reviewers: #elisa, mgallien
      
      Reviewed By: #elisa, mgallien
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D11678
      d41c7e06
  23. 01 May, 2018 1 commit
  24. 25 Feb, 2018 1 commit
    • Matthieu Gallien's avatar
      improve adding tracks or albums from the proxy models (fast and not blocking) · 95ee3eae
      Matthieu Gallien authored
      Summary:
      now adding albums from AllAlbumsProxyModel is fast
      
      when adding tracks from the proxy models, use a working thread and
      signals
      
      this means that the main thread and the interface is no longer blocked
      
      adds new methods to MediaPlayList to add list of albums or list of
      tracks or list of artists
      
      adding a lot of tracks or artists is still very slow and blocks the
      interface
      
      include QtConcurrentRun instead of QtConcurrent (suggested by ebn.kde.org)
      
      enqueue a lot of tracks is now much faster
      
      Test Plan: The tracks or the albums are still added to the playlist but much faster and without blocking the UI.
      
      Reviewers: #elisa, astippich
      
      Reviewed By: #elisa, astippich
      
      Subscribers: astippich
      
      Tags: #elisa
      
      Maniphest Tasks: T7886
      
      Differential Revision: https://phabricator.kde.org/D10451
      95ee3eae