GitLab

Summary:
properly initialize the metadata model in now playing view

BUG: 412334

Test Plan: Now playing view works OK and no warnings are printed in console

Reviewers: #elisa, ngraham, astippich, jguidon

Reviewed By: #elisa, ngraham

Differential Revision: https://phabricator.kde.org/D24274

Summary:
Not all metadata was fetched from the database.
Also do not load database id for display in the
metadata view.

Test Plan:
Year is displayed in metadata view
No empty entry with bogus label

Reviewers: mgallien, ngraham

Reviewed By: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D23934

Summary:
Seems to do the job by providing a global menu and not clutering the UI
when plasma-workspace does not provide a global menu.

BUG: 400335

Test Plan: Works with Plasma 5.14 and a global menu applet

Reviewers: #elisa, ngraham

Reviewed By: #elisa, ngraham

Subscribers: trmdi

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D21006

The translation domain must be set immediately after the QApplication
instance is created, before any i18n call takes place. See:

https://api.kde.org/frameworks/ki18n/html/prg_guide.html#link_prog

Summary: partial removal of isRadio and duplicated code in TrackMetadataModel

Test Plan:
could not spot regressions

all automatic tests are OK except elisaqmltests that does not run due to an issue with a missing so dependency on KIO

Reviewers: #elisa, ngraham, jguidon, astippich

Reviewed By: #elisa, ngraham, astippich

Differential Revision: https://phabricator.kde.org/D23280

Summary: fix other issues reported by Clazy

Test Plan: tests are OK

Reviewers: #elisa, ngraham, astippich, jguidon

Reviewed By: #elisa, astippich

Differential Revision: https://phabricator.kde.org/D23541

Summary:
Rework the mediaplayercontrol to use the new previous
and next tracks from mediaplaylist. Allows a large
cleanup.

Depends on D22771

Test Plan:
tests pass
play, next and previous buttons are still enabled as before
Random and repeat buttons still work as before

Reviewers: ngraham, mgallien

Reviewed By: mgallien

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D22772

Summary:
null album artist case needs to be handled to extract all albums from artist and genre

BUG: 411300

Test Plan: new automatic test is KO without patch and OK with it

Reviewers: #elisa, astippich, ngraham

Reviewed By: #elisa, ngraham

Differential Revision: https://phabricator.kde.org/D23720

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Make it possible to retrieve the previous and next tracks
from mediaplaylist.
Prerequisite for T7531 and T7674.
Depends on D22770

Reviewers: ngraham, mgallien

Reviewed By: mgallien

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D22771

Summary:
Remove deprecated usage of qrand().
Keep a list of the previous, current and next track
when in shuffle mode, to be used in a following patch.
Simplify calling skip and previousTracks

Depends on D22769

Test Plan: all tests pass

Reviewers: ngraham, mgallien

Reviewed By: mgallien

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D22770

Summary:
When opening albums in the albums view
containing cover art, Elisa was spitting
anchors loops and eventually crashed.
Since the image is in a layout, let it
scale the image and avoid the loop.

Reviewers: ngraham, mgallien

Reviewed By: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D23363

Summary:
Previously, the menu would open at the cursor
position. Right align it beneath the media
control bar.

Should also fix
BUG: 406025

Reviewers: mgallien, ngraham

Reviewed By: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D23359

Summary:
Make MediaPlayList responsible for remaining tracks.
Allows simplification by only reacting to currentTrack
changes inside manageheaderbar.
Add tests for remainingTracks and cleanup manageheaderbar.
Fixes the remaining tracks showing when in playlist repeat
or shuffle mode.

Test Plan:
tests pass
Remaining tracks are only showed for when not in
shuffle or repeat mode

Reviewers: ngraham, mgallien

Reviewed By: mgallien

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D22769

Summary:
Greatly simplify the ContentView after
the removal of the old notifications.

Reviewers: mgallien, ngraham

Reviewed By: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D23239

Summary:
Always resolve symlink so that
Baloo indexer works

BUG: 410670
CCBUG: 407918

Test Plan:
remove actual music folder from search path
delete old database
create a symlink to your music folder
add symlink as search path
music is found with patch

Reviewers: mgallien, ngraham

Reviewed By: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D23240

initialize TrackMetadataModel::mIsRadio to false should be enough to
"fix" the failing test

Summary:
Add support for radio streams

Steps of development:
  - play a stream and get some information from it
  - Added a table for radios in the database (V13) with some examples in it.
  - Get the examples in the view and add/play them in the playlist.

Test Plan: after the first reviews, add test for the radios view

Reviewers: #elisa, #vdg, mgallien, astippich

Reviewed By: #elisa, mgallien, astippich

Subscribers: astippich, ngraham, mgallien, ndavis

Maniphest Tasks: T7567

Differential Revision: https://phabricator.kde.org/D21525

Summary:
The notification system is not used anywhere
anymore. There is no single emit of
newNotification within Elisa.
If new notifications are added to Elisa, they
should use a PassiveNotification from Kirigami.
More ui cleanup will follow later.

Reviewers: mgallien, ngraham

Reviewed By: mgallien, ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D23223

This reverts commit 43a65838.
Was not meant to be committed.

Summary:
1. Fix track size — use fontSize + margin instead of 45.
2. Moved 0.85 constant to theme, calculate height of grid cell in one place. Two different calculations were the cause of problem, mentioned in [1].

Also this fix improves Elisa looks when user selects default font size more than 9.

[1] https://phabricator.kde.org/D23132#511825

Reviewers: mgallien, ngraham, astippich

Reviewed By: astippich

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D23206

Test Plan: {F7176880}

Reviewers: #elisa, #vdg, mgallien, astippich

Reviewed By: #elisa, astippich

Differential Revision: https://phabricator.kde.org/D23007

Summary:
Use Qt's internal scaling for HighDPI now that
we rely only on QQC2.
Closes T7530

Test Plan: HighDPI works

Reviewers: mgallien, ngraham, mykolak

Reviewed By: mgallien, ngraham

Tags: #elisa

Maniphest Tasks: T7530

Differential Revision: https://phabricator.kde.org/D23132