GitLab

Dmitry Kazakov authored May 01, 2014 and Lukáš Tvrdý committed May 01, 2014

Fixes glitches when bitbliting gmic result on moved layer with selection

BUG:325771

This function causes some hefty slowdowns on startup in Windows
if we don't do it like this. The reason is that the url completion
widget from kdelibs is deadly slow to destruct on windows, causing
about eight seconds of slowdown on startup (at least on my machine)

https://bugs.kde.org/show_bug.cgi?id=333142

Fixed as per Dmitry's suggestion to remove the for loop entirely.
The progress updater still doesn't work correctly.

With okteta...

CCMAIL:kde-18n-doc@kde.org,aacid@kde.org

Thanks to Manuel Riecke!
CCMAIL:spell1337@gmail.com

GIT_SILENT

GIT_SILENT

- the computation of tile width was buggy
- scaling pixels to float color-space in temporary tile
  did not take into account the posibility that the source
  tile is read only partially (when you e.g. selection)

- there is still some corruption when bitblting
  gmic result to layer

BUG:327980
CCBUG:325771

from layer stack.

Caption isn't updated properly yet, but I could not really figure out
how to do that properly.

BUG: 333213

CID 35286 (#1 of 1): Resource leak (RESOURCE_LEAK)
4. leaked_storage: Variable bal going out of scope leaks
   the storage it points to.

Otherwise we end up taking the size from the dialog window which results
in tiny text.

BUG: 333468

Instead of using QImageReader::canRead which reads parts of the file
causing issues when saving on Windows.

15. pass_freed_arg: Passing freed pointer im as an argument to QImage.