GitLab

This is a layer that is loaded from a file and updates when the file
changes. Optionally, the image in the file can be scaled to the current
image's resolution.

I just got a crash in tryEndRunningShortcut where the action() object
returned by m_d->runningShortcut->action() was 0 in the second line
where it was used. Store the action object locally instead before
dereferencing it.

1) Fixed painting on semi-transparent images. Now COMPOSITE_COPY is the
   default mode and it works nicely!
2) Added a feature: Smudge Mode for the Filter Op. The temporary device is
   not cleared every time, which creates really nice effects.
3) Fixed loading of the default filter configuration for the Filter Op
4) Fixed an offset bug when painting with Gaussian Blur.

BUG:252882

The default value should be 1.0, not zero.

BUG:308470

Well, you can delete it, but it will now reincarnate as a usual
paint layer ;)

BUG:314920

PaintOp box doesn't initialize the filter configuration widget fully,
so the temporary switching of the tools does not happen. So we shouldn't
request switching back in this case.

BUG:317953

There is no need to regenerate transfers every time and
in the multithreaded evnvironment. Just do it in a single-threaded part
of the process when the configuration is generated.

I also did the same changes to the Brightnesss-Contrast Filter, bacause
it looks also vulnerable, although I couldn't reproduce the crash there.

BUG:317811,317939,312996

1) Histogram should not crash when the source device is empty
2) The preview (and histogram) devices for an adjustment layer
   should be created not from the previous layer, but from the
   layers stack below.

BUG:318621

BUG:317768

This introduces quite a non-trivial still-point concept... please, read
about it in the docs for KisImage::sigImageSizeChanged.

The general idea of user iteractions:
1) When rescaling/rotating the whole image (the actual content
   doesn't change):

   -> the scaling/rotating of the image happens around its center
      (not around the center of the screen!)

2) When cropping/changing the size of the canvas (the amount of content
   changes):

   -> the content of the image that is left after cropping does not
      change its position on screen

3) When working in FIT_WIDTH/FIT_PAGE modes:

   -> changing the size of the image switches zoom mode to CONSTANT

BUG:313489

Now for all internal conversions one must use:

KoColorConversionTransformation::InternalRenderingIntent
or
KoColorConversionTransformation::InternalConversionFlags

Or their Adjustment counterparts.

BUG:318434

The painter was not initialized with the paint color before the first
iteration of the loop. That meant the first segment of the connecting
line was painted with a random color.

BUG:316858

This reverts commit c2a6cc79585d97760ffc8c7b74c9a702bb1eb84b.

Conflicts:
	krita/data/kritarc

Okay, it's official: no more commits until I am home and at my desk...

The favourites bug was already fixed, but let's change the list to
Deevad's suggestion.

Thanks Thra11 for pointing this out!

This reverts commit a772c8aa968e85b950d86659ef31020ef0dbd57a.

I shouldn't try to debug stuff during a busy conference.

This reverts commit 5a0728f28631a599df204641d4b2682d65c5d779.

In most of the cases we use fixed paint devices with zero offset,
so this bug was not seen usually. But a newly written unittest for
KisPixelSelection (cross colorspace painting) reveals this bug.

Before
* had parts centered horizontally

REVIEW: 109901

thanks boud for review

Before
* had parts centered horizontally
* stretched whole UI vertically

REVIEW: 109899

thanks boud for review

REVIEW: 109903

thanks boud for review

REVIEW: 109902

thanks boud for review

REVIEW: 109898

thanks boud for review

Among other things removed the margin from KoResourceItemChooser, as it is a widget,
only composed from other widgets, so to align properly with other widgets there should
not be a margin around it

REVIEW: 109896

thanks boud for review

REVIEW: 109897

thanks boud for review

'NOT' != '!' in cmake

REVIEW: 109889

Thanks boud for review