GitLab

Summary:
This patch adds timing functionality to the Animation Timeline Docker's "Insert N Keyframes" menu actions. Out of necessity, it also replaces the create-on-demand QInputDialog with a new TimelineInsertKeyframesDialog that was designed as a drop-in replacement that allows for getting more than a single variable of user input (i.e. frame count and timing) and which could easy be given more functionality in the future.

{F5845888}

The motivation behind this patch was to improve the "Insert N Keyframes Right/Left" action workflow by giving the animator control of frame timing. Previously, those actions worked by adding a number of immediately adjacent frames based on the user's desired number of frames to insert.

In animation, keyframes that are immediately adjacent to each other are described as being "on 1s", but other timings are also common - "on 2s", "on 3s", etc. - in which drawings are held for different amounts of time. Animations typically maintain a particular rhythm for a span of frames, but it's also very common for different parts of a single animation to switch timings.

This patch improves upon existing functionality to facilitate animating on 1s, 2s, 3s, and others. Now, a Krita user can specify a timing of 2 to quickly and easily insert keyframes "on 2s", a timing of 3 to insert "on 3s", and so on, allowing even longer timings if desired.

( Pair-programmed on a sunny Portland Saturday with @eoinoneill, of course! =] )

Test Plan:
1. Right-click a position on the animation Timeline docker.

2. Select "Keyframes > Insert N Keyframes Right" or "Keyframes > Insert N Keyframes Left".

3. A new dialog windows should pop up, asking for a number of frames and a timing.

4. Test different values as well as both the "Cancel" and "OK" buttons and check for predictable behavior in a variety of cases.

Reviewers: #krita, #krita_abyss, dkazakov, rempt, scottpetrovic, Bollebib

Subscribers: #krita_abyss, #krita, eoinoneill

Tags: #krita_abyss

Differential Revision: https://phabricator.kde.org/D12843

Now "Remove Frames" action of the animation docker will also
remove all the selected frames, like the action in the context
menu

Now one can copy-paste frames and columns on the timeline using
a special context menu.

CC:kimageshop@kde.org

One can select some frames range, it will be mirrored. It is also
possible to mirror columns.

CC:kimageshop@kde.org

These actions allow the user change duration of the key frames that
are part of the current selection.

CC:kimageshop@kde.org

The full list of new actions:
1) Insert Keyframe Right
2) Insert Keyframe Left
3) Insert N Keyframes Right
4) Insert N Keyframes Left

5) Remove Frame and Shift
6) Remove Frame

7) Insert Column Right
8) Insert Column Left
9) Insert N Columns Right
10) Insert N Columns Left

11) Remove Column and Shift
12) Remove Column

I will probably change the naming of some actions in the future when
other planned actions like "Add/Remove hold frames" is implemented.


CC:kimageshop@kde.org

BUG:377730
Fixes T5754

Thanks Kevin Funk for providing a patch!

Thanks Kevin Funk for providing a patch!

It also fixes the tooltip used for e.g. the brush to show the brush in
the tooltip.
Additionally it is possible to show the tooltip by pressing the middle
button.

Closes T3499 Layer thumbnail on the timeline on hover

It is quite primitive yet (it doesn't have any visualisation), but it
works! Just select the file using a button on the timeline and it'll
work fine: with both playback and scrubbing.

TODO: icons for the button!

CC:kimageshop@kde.org

BUG:373316
Fixes T4837

See comments in KisNodeView::selectionCommand() and
TimelineFramesView::startDrag().

BUG:356056
Fixes T1141
CC:kimageshop@kde.org

We have two (well, three, but the tests don't work yet) situations:
after make install, and after deploying. After install, plugins are
in lib/kritaplugins, after deploy in PlugIns. To avoid trying to
load way too many plugins, assume that all Krita plugins start with
"krita".

Also, move all dockers to plugins/dockers, from plugins/extensions/dockers.

Now we have only one plugin dir. The plugin dir now has the
great big include_directories list, but that's for fixing
later on.

Now one can play only a portion of the clip by selecting a range
on the timeline and clicking 'Play' button.

CC:kimageshop@kde.org

CC:kimageshop@kde.org

Now you have the following actions available in the timeline:

1) Space + drag --- pan
2) Space + rclick drag --- zoom
3) Alt + drag --- offset the frame with the all the right-hand frames

Conflicts:
	krita/ui/input/kis_extended_modifiers_mapper.cpp
	krita/ui/input/kis_input_manager.cpp

Zoom: Ctrl + Right button
Pan: Ctrl + Left button

TODO:
1) cached frames
2) zooming with gestures
3) add to the docker itself