1. 12 Sep, 2019 1 commit
  2. 24 Jul, 2018 1 commit
  3. 02 Jan, 2018 1 commit
  4. 30 Sep, 2015 1 commit
  5. 12 Jul, 2014 1 commit
  6. 13 Jun, 2012 1 commit
    • Thorsten Zachmann's avatar
      Fix saving of style child elements · f43593b9
      Thorsten Zachmann authored
      When saving style child elements the child elements where always saved into the default property. However this is not correct as the output of Jos tests shows
      
      [01:53:45]: kofficetests-odp (17s)
      [01:53:45]: [kofficetests-odp] odf/odp/114096.odp
      [01:53:45]: [odf/odp/114096.odp]
          INVALIDSTYLESXML: (unknown file):267: error: element "style:tab-stops" not allowed here; expected the element end-tag or element "style:background-image", "style:columns" or "text:list-style"
          INVALIDCONTENTXML: (unknown file):1061: error: element "style:tab-stops" not allowed here; expected the element end-tag or element "style:background-image", "style:columns" or "text:list-style"
                             (unknown file):1081: error: element "style:tab-stops" not allowed here; expected the element end-tag or element "style:background-image", "style:columns" or "text:list-style"
      
      The problem is that the stye:tab-stops are added to the graphic properties but should be added to the paragraph properties.
      
      This patch adds the possibility to define the property the child elements should be added too.
      f43593b9
  7. 18 May, 2012 1 commit
    • Thorsten Zachmann's avatar
      Fix saving of percent values · 23898f28
      Thorsten Zachmann authored
      When saving the file odf/odp/114096.odp from calligratests invalid xml is generated:
      
      [11:37:25]: [odf/odp/114096.odp] INVALIDSTYLESXML:
      (unknown file): 62 error: value of attribute "svg:x2" is invalid; must be a string matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)%" or must be a string matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)((cm)|(mm)|(in)|(pt)|(pc)|(px))"
      (unknown file):62: error: value of attribute "svg:y1" is invalid; must be a string matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)%" or must be a string matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)((cm)|(mm)|(in)|(pt)|(pc)|(px))"
      (unknown file):65: error: value of attribute "svg:x2" is invalid; must be a string matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)%" or must be a string matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)((cm)|(mm)|(in)|(pt)|(pc)|(px))"
      (unknown file):65: error: value of attribute "svg:y1" is invalid; must be a string matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)%" or must be a string matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)((cm)|(mm)|(in)|(pt)|(pc)|(px))"
      
      The problem is that the gradient attributes are saved like:
      
      <svg:linearGradient draw:name="gradient3" svg:spreadMethod="pad" svg:x1="100%" svg:x2="-6.66134e-14%" svg:y1="5.55112e-14%" svg:y2="100%">
          <svg:stop svg:offset="0" svg:stop-color="#cc3300"/>
          <svg:stop svg:offset="1" svg:stop-color="#c7a309"/>
      </svg:linearGradient>
      
      however e-14 is not alloed in the value for precent.
      
      This patch adds a new function to add percent attributes that takes care of using the correct format.
      23898f28
  8. 07 Feb, 2012 1 commit
    • Halla Rempt's avatar
      Change <QtGui/QDialog> style includes to <QDialog> · 02025cd8
      Halla Rempt authored
      This is already a tiny part of preparation for Qt5, where QtGui is split
      into QtGui and QtWidgets. If we use explicit module names in our includes,
      we are liable to churn like this.
      
      Since KDE applications always have all Qt modules in the include path
      anyway, direct includes always work (both in Qt4 and Qt5), and since we
      already used direct includes in thousands of places, this change makes
      our code more consistent, too.
      02025cd8
  9. 27 Nov, 2011 1 commit
  10. 18 Nov, 2011 1 commit
  11. 12 Nov, 2011 1 commit
  12. 30 Aug, 2011 1 commit
  13. 28 Aug, 2011 1 commit
  14. 18 Jun, 2011 1 commit
    • Halla Rempt's avatar
      Change koffice to calligra · 49d11865
      Halla Rempt authored
      In all places in the code where we used the string "koffice" in any
      capitalisation, use "calligra" instead.
      49d11865
  15. 02 Jun, 2011 1 commit
  16. 24 Apr, 2011 1 commit
  17. 28 Mar, 2011 1 commit
  18. 10 Jan, 2011 1 commit
  19. 28 Sep, 2010 1 commit
    • Casper Boemann's avatar
      ------------------------------------------------------------------------ · 3f9e6926
      Casper Boemann authored
      r1180146 | staniek | 2010-09-27 09:33:21 +0200 (Mon, 27 Sep 2010) | 2 lines
      Changed paths:
         M /trunk/koffice/plugins/chartshape/ChartProxyModel.cpp
         M /trunk/koffice/plugins/chartshape/kdchart/src/KDChartCartesianGrid.cpp
      
      warnings--
      
      ------------------------------------------------------------------------
      r1180147 | staniek | 2010-09-27 09:35:31 +0200 (Mon, 27 Sep 2010) | 2 lines
      Changed paths:
         M /trunk/koffice/filters/kword/msword-odf/wv2/src/word97_generated.cpp
      
      Fixed warning: ‘shifterU16’ is used uninitialized in this function
      
      
      ------------------------------------------------------------------------
      r1180155 | danders | 2010-09-27 10:12:12 +0200 (Mon, 27 Sep 2010) | 2 lines
      Changed paths:
         M /trunk/koffice/kplato/kptpart.cpp
         M /trunk/koffice/kplato/kptview.cpp
         M /trunk/koffice/kplato/libs/kernel/kptschedulerplugin.cpp
         M /trunk/koffice/kplato/libs/kernel/kpttask.cpp
         M /trunk/koffice/kplato/libs/ui/kptintervaledit.cpp
         M /trunk/koffice/kplato/libs/ui/kpttaskdescriptiondialog.cpp
         M /trunk/koffice/kplato/libs/ui/kpttaskeditor.cpp
         M /trunk/koffice/kplato/libs/ui/reports/reportview.cpp
         M /trunk/koffice/kplato/libs/ui/reports/reportview.h
         M /trunk/koffice/kplato/plugins/schedulers/rcps/KPlatoRCPSScheduler.cpp
         M /trunk/koffice/kplato/templates/Simple/Basicproject.desktop
      
      krazy issues.
      
      
      ------------------------------------------------------------------------
      r1180164 | scripty | 2010-09-27 10:23:31 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/kplato/templates/Simple/Basicproject.desktop
      
      SVN_SILENT made messages (.desktop file, second try)
      
      ------------------------------------------------------------------------
      r1180209 | mkruisselbrink | 2010-09-27 13:21:42 +0200 (Mon, 27 Sep 2010) | 2 lines
      Changed paths:
         M /trunk/koffice/plugins/pictureshape/PictureShape.cpp
      
      in odf an image is also allowed to have text on it, so properly load&save this text
      BUG: 249853
      ------------------------------------------------------------------------
      r1180210 | mkruisselbrink | 2010-09-27 13:22:03 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/libs/odf/KoGenStyle.h
      
      make property and attribute getters public, so it is possible to access previously stored data in already generated KoGenStyle instances
      ------------------------------------------------------------------------
      r1180211 | mkruisselbrink | 2010-09-27 13:22:05 +0200 (Mon, 27 Sep 2010) | 2 lines
      Changed paths:
         M /trunk/koffice/filters/kspread/xlsx/XlsxXmlWorksheetReader.cpp
      
      when cells are merged we need to get the right/bottom border from the style of the cells in the last row/column of the merged area
      BUG: 239764
      
      ------------------------------------------------------------------------
      r1180224 | rempt | 2010-09-27 14:37:07 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/krita/ui/widgets/kis_scratch_pad.cpp
      
      Fix warning
      ------------------------------------------------------------------------
      r1180225 | rempt | 2010-09-27 14:37:24 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/libs/pigment/KoColorSpace.h
      
      Fix compilation.
      
      ------------------------------------------------------------------------
      r1180305 | nikolaus | 2010-09-27 17:44:02 +0200 (Mon, 27 Sep 2010) | 2 lines
      Changed paths:
         M /trunk/koffice/kspread/dialogs/SortDialog.cpp
      
      Allow sorting when only one column/row is selected.
      
      
      ------------------------------------------------------------------------
      r1180343 | adamc | 2010-09-27 20:37:41 +0200 (Mon, 27 Sep 2010) | 5 lines
      Changed paths:
         M /trunk/koffice/krita/ui/widgets/kis_scratch_pad.cpp
      
      enabled transactions in the scratchpad. they don't get recorded, so no
      undo. this was needed to make the filter brush work correctly.
      
      BUG: 227533
      
      
      ------------------------------------------------------------------------
      r1180363 | staniek | 2010-09-27 21:18:51 +0200 (Mon, 27 Sep 2010) | 2 lines
      Changed paths:
         M /trunk/koffice/tools/f-office/FoDocumentRdf.cpp
         M /trunk/koffice/tools/f-office/FoDocumentRdf.h
      
      chmod -x
      
      ------------------------------------------------------------------------
      r1180364 | mkruisselbrink | 2010-09-27 21:20:16 +0200 (Mon, 27 Sep 2010) | 2 lines
      Changed paths:
         M /trunk/koffice/filters/kspread/xlsx/XlsxXmlDrawingReader.cpp
         M /trunk/koffice/filters/kspread/xlsx/XlsxXmlDrawingReader.h
         M /trunk/koffice/filters/kspread/xlsx/XlsxXmlWorksheetReader.cpp
         M /trunk/koffice/filters/kspread/xlsx/XlsxXmlWorksheetReader_p.h
         M /trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h
      
      add another bunch of hack to the DrawingML code to make it possible for it to load at least text boxes in xlsx files. But this entire DrawingML reading code really desperately needs to be rewritten (and redesigned) if we ever want it to be able to properly support loading DrawingML instead of adding hack upon hack.
      Also colors are still completely messed up, but at least it sort of does something now.
      
      ------------------------------------------------------------------------
      r1180366 | zander | 2010-09-27 21:32:53 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/libs/flake/KoShape.h
      
      Fix typo
      
      ------------------------------------------------------------------------
      r1180368 | zander | 2010-09-27 21:33:35 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/plugins/chartshape/ChartShape.cpp
      
      Fix init-order warning
      ------------------------------------------------------------------------
      r1180369 | zander | 2010-09-27 21:33:37 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/plugins/dockers/shapeselector/Canvas.cpp
      
      Remove unused code
      ------------------------------------------------------------------------
      r1180370 | zander | 2010-09-27 21:33:40 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/libs/flake/KoInsets.h
      
      Add 'clear' method to cheaply clear the insets
      ------------------------------------------------------------------------
      r1180371 | zander | 2010-09-27 21:33:42 +0200 (Mon, 27 Sep 2010) | 3 lines
      Changed paths:
         M /trunk/koffice/plugins/textshape/TextTool.cpp
         M /trunk/koffice/plugins/textshape/tests/TestTextTool.cpp
      
      A line with no text still has a position.
      
      BUG: 213238
      ------------------------------------------------------------------------
      r1180372 | zander | 2010-09-27 21:33:45 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/libs/flake/KoToolProxy.h
      
      Replace API docs with something a bit more true
      
      ------------------------------------------------------------------------
      r1180382 | berger | 2010-09-27 22:15:08 +0200 (Mon, 27 Sep 2010) | 4 lines
      Changed paths:
         M /trunk/koffice/krita/image/kis_convolution_worker.h
      
      Fix: feather selection crashes
      Fix: convolution worker does not respect channels flags
      
      
      
      ------------------------------------------------------------------------
      r1180395 | zander | 2010-09-27 23:02:25 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/kword/part/frames/KWFrame.cpp
      
      Properly write out if the frame will be copied
      
      ------------------------------------------------------------------------
      r1180402 | piggz | 2010-09-27 23:20:40 +0200 (Mon, 27 Sep 2010) | 6 lines
      Changed paths:
         M /trunk/koffice/kexi/migration/importtablewizard.cpp
         M /trunk/koffice/kexi/migration/importtablewizard.h
         M /trunk/koffice/kexi/migration/kspread/kspreadmigrate.cpp
      
      Fix memory leak
      Fix crash and memory corruption by not deleting things that shouldnt be deleted
      Clear the table list when visiting the page
      Ensure an ods document is closed before opening another
      CCMAIL:staniek@kde.org
      BUG:250164
      
      ------------------------------------------------------------------------
      r1180409 | staniek | 2010-09-27 23:45:48 +0200 (Mon, 27 Sep 2010) | 1 line
      Changed paths:
         M /trunk/koffice/kexi/formeditor/WidgetTreeWidget.cpp
      
      Forms: fix possible crash when activating tab page
      
      ------------------------------------------------------------------------
      r1180417 | staniek | 2010-09-28 00:40:25 +0200 (Tue, 28 Sep 2010) | 5 lines
      Changed paths:
         M /trunk/koffice/kexi/core/kexisharedactionhost.cpp
         M /trunk/koffice/kexi/core/kexisharedactionhost.h
         M /trunk/koffice/kexi/doc/dev/CHANGELOG-Kexi-js
         M /trunk/koffice/kexi/main/KexiMainWindow.cpp
         M /trunk/koffice/kexi/main/KexiMainWindow.h
      
      Forms
      *Widgets Tree:
      **fix delete widget action in context menu (and possibly other actions)
      
      
      
      ------------------------------------------------------------------------
      r1180425 | adamc | 2010-09-28 01:21:43 +0200 (Tue, 28 Sep 2010) | 4 lines
      Changed paths:
         M /trunk/koffice/krita/plugins/extensions/dockers/colorselectorng/kis_common_colors.cpp
         M /trunk/koffice/krita/plugins/extensions/dockers/colorselectorng/kis_common_colors.h
         M /trunk/koffice/krita/plugins/extensions/dockers/colorselectorng/kis_common_colors_recalculation_runner.cpp
         M /trunk/koffice/krita/plugins/extensions/dockers/colorselectorng/kis_common_colors_recalculation_runner.h
      
      - fix bug, where switching of autoupdate of image colours didn't work.
      - speed up calculation of image colours by using dmitry's sugestion
      (update only needed region and listen to sigImageUpdated(const QRect &))
      
      
      
      svn path=/branches/work/koffice-essen/; revision=1180480
      3f9e6926
  20. 27 Sep, 2010 1 commit
  21. 25 Aug, 2010 1 commit
  22. 07 May, 2010 1 commit
    • Thomas Zander's avatar
      LibOdf cleanups. · 7baeea2c
      Thomas Zander authored
      Whitespace and enum naming correctness.
      
      svn path=/trunk/koffice/; revision=1124027
      7baeea2c
  23. 30 Mar, 2010 2 commits
    • Halla Rempt's avatar
      Merged revisions 1108961,1108972,1108989 via svnmerge from · acf9adc6
      Halla Rempt authored
      https://rempt@svn.kde.org/home/kde/trunk/koffice
      
      ........
        r1108961 | lassin | 2010-03-30 10:08:15 +0200 (Tue, 30 Mar 2010) | 3 lines
        
        Fixes small caps for 2007 DrawingML
      ........
        r1108972 | vandenoever | 2010-03-30 10:31:49 +0200 (Tue, 30 Mar 2010) | 1 line
        
        Fix crash caused by dereferencing a zero pointer.
      ........
        r1108989 | staniek | 2010-03-30 11:26:10 +0200 (Tue, 30 Mar 2010) | 33 lines
        
        KoGenStyle(s) cleanup
        
        * KoGenStyle::Type cleanup:
        - renamed StyleUser to StyleParagraph
        - renamed StyleAuto to StyleParagraphAuto
        - move the 'Auto' to the end for the table style families
        * KoGenStyles::Flags made QFlags                         
        * KoGenStyles::lookup() -> KoGenStyles::insert()
        * move KoGenStyle::isEmpty() code to .cpp
        * use constFind(), constBegin(), constEnd() for iterators if possible
        * made some methods const
        * introduced KoGenStyles::StylesPlacement for saving odf and inserting raw styles.
        * insertRawStyles() replaces 4 methods. saveOdfStyles() replaces 4 other methods.
        * KoGenStyle::N_NumTypes -> KoGenStyle::N_NumPropertyTypes
        * added KoGenStyle::N_NumTypes
        * KoGenStyles: StyleArray -> QList<KoGenStyles::NamedStyle>
        * KoGenStyles: NameMap typedef removed, using just QSet<QString> is clear
        * To minimize size of the patch, I am noting down remaining possible TODOs:
        * Implemented qDebug() for KoGenStyles instead of dump()
        * Added KoGenStyles::FontFaceDecls to enum KoGenStyles::StylesPlacement, so
        - removed void KoGenStyles::saveOdfFontFaceDecls(KoXmlWriter* xmlWriter) const; for the same result use KoGenStyles::saveOdfStyles(FontFaceDecls, xmlWriter)
        - it's possible to add font faces using raw XML in insertRawOdfStyles()
        - moved private methods to the Private class
        * Added other proposed improvements
        * Use Style and AutoStyle suffixes for Type enum
        * Updated the whole koffice code for the KoGenStyle(s) change
        
        Revieweing, testing:
        *reviewed and approved by Jos; http://reviewboard.kde.org/r/3090/
        *builds agains trunk, checked if there's no change in semantics, relevant unit tests updated and passed
        *while global search/replace was executed to port to the new API, the change has been reviewed line-by-line too
      ........
      
      svn path=/branches/work/koffice-ko/; revision=1108994
      acf9adc6
    • Jarosław Staniek's avatar
      KoGenStyle(s) cleanup · 51f546dc
      Jarosław Staniek authored
      * KoGenStyle::Type cleanup:
      - renamed StyleUser to StyleParagraph
      - renamed StyleAuto to StyleParagraphAuto
      - move the 'Auto' to the end for the table style families
      * KoGenStyles::Flags made QFlags                         
      * KoGenStyles::lookup() -> KoGenStyles::insert()
      * move KoGenStyle::isEmpty() code to .cpp
      * use constFind(), constBegin(), constEnd() for iterators if possible
      * made some methods const
      * introduced KoGenStyles::StylesPlacement for saving odf and inserting raw styles.
      * insertRawStyles() replaces 4 methods. saveOdfStyles() replaces 4 other methods.
      * KoGenStyle::N_NumTypes -> KoGenStyle::N_NumPropertyTypes
      * added KoGenStyle::N_NumTypes
      * KoGenStyles: StyleArray -> QList<KoGenStyles::NamedStyle>
      * KoGenStyles: NameMap typedef removed, using just QSet<QString> is clear
      * To minimize size of the patch, I am noting down remaining possible TODOs:
      * Implemented qDebug() for KoGenStyles instead of dump()
      * Added KoGenStyles::FontFaceDecls to enum KoGenStyles::StylesPlacement, so
      - removed void KoGenStyles::saveOdfFontFaceDecls(KoXmlWriter* xmlWriter) const; for the same result use KoGenStyles::saveOdfStyles(FontFaceDecls, xmlWriter)
      - it's possible to add font faces using raw XML in insertRawOdfStyles()
      - moved private methods to the Private class
      * Added other proposed improvements
      * Use Style and AutoStyle suffixes for Type enum
      * Updated the whole koffice code for the KoGenStyle(s) change
      
      Revieweing, testing:
      *reviewed and approved by Jos; http://reviewboard.kde.org/r/3090/
      *builds agains trunk, checked if there's no change in semantics, relevant unit tests updated and passed
      *while global search/replace was executed to port to the new API, the change has been reviewed line-by-line too
      
      
      svn path=/trunk/koffice/; revision=1108989
      51f546dc
  24. 09 Feb, 2010 2 commits
  25. 05 Feb, 2010 1 commit
    • Jos van den Oever's avatar
      Bring KoGenStyle(s) more in line with ODF spec · 5b9d939b
      Jos van den Oever authored
      I've uncovered some problems in KoGenStyle and KoGenStyles.
      - Not all style families have their own value in KoGenStyle::Type
         StyleParagraph, StyleRuby, StyleGraphic, and StylePresentation are not
      defined.
      - The documentation says:
         "StyleText,                   ///< style:style with style:text-properties"
        which is strange since also StyleParagraph, StyleTableCell, StyleGraphic,
      StylePresentation and StyleChart can have style:text-properties too.
      - There is an assert in KoGenStyles.cpp line 164 that only allows default
      styles for StyleUser, StyleTableColumn, StyleTableRow and StyleTableCell.
       (StyleUser seems to be a synonym for the missing StylePresentation).
      
      The problems are solved with the following steps:
      
      - add StyleParagraph, StyleRuby, StyleGraphic, and StylePresentation to
      KoGenStyle::Type
      - fix the documentation for the 12 style families to not define styles by their
      contents but by their family
      - expand the assert to include the other 9 style families.
      
      svn path=/trunk/koffice/; revision=1085521
      5b9d939b
  26. 18 Jan, 2010 1 commit
  27. 22 Dec, 2009 1 commit
  28. 19 Aug, 2009 3 commits
  29. 07 Aug, 2009 1 commit
  30. 30 Jul, 2009 1 commit
  31. 19 Jul, 2009 1 commit
  32. 22 Jun, 2009 1 commit
  33. 30 Mar, 2009 1 commit
  34. 18 Mar, 2009 1 commit
  35. 11 Sep, 2008 1 commit
  36. 27 Aug, 2008 1 commit