Skip to content
  • Wolthera van Hövell's avatar
    Merge in softproofing and ocio looks. · 0807eeb0
    Wolthera van Hövell authored
    These features allow for better workflow in for Print and VFX respectively.
    Check https://docs.krita.org/Soft_Proofing on how to use softproofing.
    
    Looks will still need a little note added to Lut management page.
    
    CCMAIL:kimageshop@kde.org
    Fixes T2395
    
    Squashed commit of the following:
    
    commit 38c4fc32
    Merge: 54776118 e308ed0f
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Tue Jun 28 17:46:16 2016 +0200
    
        Merge branch 'master' into krita-testing-wolthera
    
    commit 54776118
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Tue Jun 28 17:43:20 2016 +0200
    
        Add rant why per-shot looks won't work after wasting afternoon on it.
    
        The tl;dr is that OCIO's documentation is extremely vague.
    
        Ref T2337
    
    commit a3b224b6
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Fri Jun 24 13:16:01 2016 +0200
    
        Fix loading of default gamut warning color.
    
        Always set the color space of the kocolor, kids.
    
        ref T2337
    
    commit 652405d3
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Fri Jun 24 12:54:17 2016 +0200
    
        Add adaptation state slider.
    
        This allows you to set whether or not to adapt the white point, that is,
        to set the white point to the screen white(full slider) or to convert all whiteson screen to the white point of the profile when using absolute colorimetric
        as intent.
    
        This is useful to simulate paper-colour.
    
        Ref T2337
    
    commit aea525ca
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Fri Jun 24 10:32:37 2016 +0200
    
        Fix builds on gcc 6
    
    commit 67f4e5a2
    Merge: 519f9c1f 159a6126
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 22:00:22 2016 +0200
    
        Merge branch 'master' into krita-testing-wolthera
    
    commit 519f9c1f
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 19:49:56 2016 +0200
    
        Add option to set default Proofing Options.
    
        These will work for images with no proofing options, so, old loaded images
        and new images. With this it is feature complete, and people can start testing.
    
        Ref T2337
        Ref T1238
    
    commit 062db74d
    Merge: 2e057e7a 76255392
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 15:16:54 2016 +0200
    
        Merge branch 'master' into krita-testing-wolthera
    
    commit 2e057e7a
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 15:15:24 2016 +0200
    
        Clean up all the debug messages.
    
        It's... quieter in the terminal now.
    
        Ref T2337
    
    commit 7ff7e60b
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 15:01:02 2016 +0200
    
        Cleanup: Make projection color a defined tag.
    
    commit 604efc8d
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 14:50:20 2016 +0200
    
        Not sure if this isn't the correct code instead...
    
        Ref T2337
    
    commit 7c669703
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 14:42:04 2016 +0200
    
        Load embedded proofing profiles if they exist, and add them to the profile registery.
    
        Needs testing for obvious reasons.
    
        Ref T2337
    
    commit 119906b2
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 14:27:07 2016 +0200
    
        Add embedding of the proofing profile.
    
        This is so that we can later unembed them.
    
        Ref T2337
    
    commit 9ef1dad7
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 14:15:47 2016 +0200
    
        Load Warning Colors properly from file.
    
        Now the out of gamut warning can be written into file as XML
        and loaded from file as XML.
    
        Ref T2337
    
    commit 6a57cf08
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 13:49:49 2016 +0200
    
        Fix naming conventions.
    
        I was using gamut warnings/alarms, and softproofing and soft proofing.
    
        The standard is (Out of )Gamut Warnings and Soft Proofing.
    
        Ref T2337
    
    commit 4faa8b57
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 23 13:37:49 2016 +0200
    
        Disable softproofing in floating point spaces.
    
        There's a bunch of little niggling bugs that crop up when soft proofing
        in floating point spaces, amongst which the inability of the proofing
        mechanism to see floating point values higher than 1.0 fall outside of
        the gamut of the color space, let alone recognising whether it can go
        inside the gamut of the proofing space.
    
        See also http://ninedegreesbelow.com/bug-reports/soft-proofing-problems.html
    
        For now, it's best to disable softproofing on floating point spaces.
        Might need a more official check, though.
    
        Ref 2337
    
    commit 91d7da8c
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Wed Jun 22 16:26:52 2016 +0200
    
        Make views smart enough to track softproof/gamutcheck-state.
    
        Also add a floating message to say when the softproofing or gamutcheck
        is turned on in the view. Wording may change.
    
        Ref T2337
    
    commit 5c48dd2c
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Wed Jun 22 16:26:35 2016 +0200
    
        Fix Build
    
    commit 6bacfcda
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Wed Jun 22 14:45:52 2016 +0200
    
        Add attempt at saving color to xml.
    
        This fails due to me not being able to load the xml, due object-bonanza.
    
        ref T2337
    
    commit 3bbf025b
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Wed Jun 22 12:49:06 2016 +0200
    
        Intitial saving/loading of config.[unstable]
    
        Works, but might change later.
    
    commit 1f733e28
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Tue Jun 21 20:21:15 2016 +0200
    
        Refactor the proofing transform system for better caching.
    
        This now makes the transform separately from the actual transforming,
        which means it's easier to cache and to update. Softproofing is now
        gone from usable to user-friendly.
    
        Still needs saving/loading and little setting-bugs fixed.
    
        ref T2337
    
    commit 8371c417
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Tue Jun 21 18:20:48 2016 +0200
    
        Enable Gamut color and proofing intent.
    
        The image now stored proofing intent, and the monitor intent is the general
        rendering intent.
    
        This also allows us to set the gamut warning color, however, for updating
        you currently need to switch profiles as well. I'll make a seperate
        generateSoftProofingTransform function, to cache the transform better, so it's
        easier to update.
    
        Ref 2337
    
    commit 9d9ce380
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Tue Jun 21 14:18:05 2016 +0200
    
        Add softproofing section to image properties menu.
    
        Now, the proofing in the image can be changed.
    
        Also fixes that ugly little square problem with the kocoloractionpopup button.
    
        Ref T1238, T2337
    
    commit 8d7b4418
    Merge: e2ee9ff5 d58645ed
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 16 13:28:24 2016 +0200
    
        Merge remote-tracking branch 'origin/master' into krita-testing-wolthera
    
    commit e2ee9ff5
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Tue Jun 14 15:56:50 2016 +0200
    
        Cache the transform unelegantly.
    
        This does cause a significant speed-up, but it's a bit fiddly.
        Regardless, the speed-up is enough to make this usable.
    
    commit f643fc7b
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Tue Jun 14 14:49:16 2016 +0200
    
        Fix softproofing
    
        It's slow again :/
    
    commit cbc91c07
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Tue Jun 14 12:45:43 2016 +0200
    
        Fix setting softproofing and gamutcheck flags.
    
    commit 9ae336ed
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Tue Jun 14 12:44:50 2016 +0200
    
        Cache the color space engine to make it faster
    
        It doesn't fix everything, but it fixes quite a bit.
        Ref T210
    
    commit d4358901
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Mon Jun 13 17:59:18 2016 +0200
    
        Add base implementation softproofing with toggles.
    
        It doesn't really work yet :/
    
        Ref: T210
        Ref: T2337
    
    commit 7de02569
    Author: Boudewijn Rempt <boud@valdyas.org>
    Date:   Sun Jun 12 16:10:31 2016 +0200
    
        Create the proofing transform
    
        This doesn't use the caching graph stuff, which is too complex
        to refactor for now.
    
    commit 00efd627
    Author: Boudewijn Rempt <boud@valdyas.org>
    Date:   Sun Jun 12 16:10:05 2016 +0200
    
        Add a per-image proofing settings class
    
    commit d3bd5375
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Sun Jun 12 14:44:50 2016 +0200
    
        Push work-in-progress proofing
    
    commit bb97947a
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 9 16:42:18 2016 +0200
    
        Fix copy-paste error
    
    commit 9ed934a8
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Thu Jun 9 16:30:09 2016 +0200
    
        Add OCIO Look support.
    
        The code is based of that of Blender, as I couldn't figure out how else to
        apply looks. The OCIO api wasn't clear about it, nor could I find much information,
        but it somewhat works and doesn't crash.
    
        Auditors: rempt, dkazakov
        Ref: T210
    
    commit 2819ad66
    Author: Wolthera van Hovell tot Westerflier <griffinvalley@gmail.com>
    Date:   Wed Jun 8 12:21:25 2016 +0200
    
        Add softproofing to the lcms conversion tests
    
        I am not fully sure if I understand the softproofing function, but the alarm works.
    0807eeb0