1. 15 Jun, 2019 1 commit
    • Agata Cacko's avatar
      Add tiff import/export color space tests · 3525af5d
      Agata Cacko authored
      Before this commit there was no tests to check if tiff can be exported
      and imported using a specific color space. This commit adds those tests.
      
      It also changes the way filestest.h works to make sure there is no files
      left afterwards.
      3525af5d
  2. 11 Jun, 2019 1 commit
    • Agata Cacko's avatar
      Add color space import/export compatibility tests · eacc04e1
      Agata Cacko authored
      Before there was no way of checking if an image saved in one color space
      is opened in the same color space. For example tiff import can assume
      things about color space of the image that isn't necessarily true.
      This commit adds a possible test to use to check it.
      eacc04e1
  3. 21 May, 2019 2 commits
    • Agata Cacko's avatar
      Improve exr error codes, remove raw wrong tests · b70a8d60
      Agata Cacko authored
      Raw is an import-only format, so export tests shouldn't be used.
      Exr returned Failure before, now it returns ErrorWhileReading or
      ErrorWhileWriting. Tests were changed to allow for that sitation
      (since exr filter doesn't know whether it can't read the file or
      just parse it).
      b70a8d60
    • Agata Cacko's avatar
      Fix tiff imp/ex tests, add more error handling · d21b28f9
      Agata Cacko authored
      Before this commit, tiff tests failed because of the way tiff uses
      savingImage() and how tests were written and how KisDocument works.
      This commit makes sure that tiff tests uses KisDocument exportSync
      function which copies the file to savingImage() so tiff tests doesn't
      crash anymore.
      
      This commit also adds more error checking in tiff converter.
      d21b28f9
  4. 20 May, 2019 2 commits
    • Agata Cacko's avatar
      Fix memory leaks in case of failed tests · 12d6e3e8
      Agata Cacko authored
      Before this commit if the tests failed, there were memory leaks
      and tests created writeonly files (which you can't add to git,
      for example). This commit makes sure that tests will overwrite
      permissions to make the files read-write and close the image
      no matter if the tests are passing or not.
      12d6e3e8
    • Agata Cacko's avatar
      Add brush import/export test, add test files · 215cbb2e
      Agata Cacko authored
      Before this commit there was no brush import/export tests
      at all, this commit adds permissions tests and incorrect
      format tests.
      
      This commit also adds tests files. They would be generated during the
      test run but only if "data" directory already exists, which is not that
      obvious since some of the tests didn't have any test files and you can't
      push empty directories to git, hence addition of all files.
      Their permissions (for permissions tests) will be set correctly
      in the test itself anyway.
      215cbb2e
  5. 17 May, 2019 4 commits
    • Agata Cacko's avatar
      Fix mimetype of xcf, improve tests debug · de363975
      Agata Cacko authored
      Before this commit, the mimetype in xcf tests was incorrect.
      This commit fixes it. Also this commit introduces a tip
      what to do if permission tests fails with FileFormatIncorrect
      error message.
      de363975
    • Agata Cacko's avatar
      Add more tests for import and export of files · f97d4ce8
      Agata Cacko authored
      Before this commit, there was no tests for checking
      error messages in case of reading a file with incorrect
      format or export to readonly location. This commit
      adds those tests.`
      f97d4ce8
    • Agata Cacko's avatar
      Test writing pngs and jpgs to readonly location · c85b417d
      Agata Cacko authored
      Before this commit, there were no tests for png and jpg filters
      to write to readonly location. This commit adds such a test.
      c85b417d
    • Agata Cacko's avatar
      Unify error codes engaged in import/export · e518e102
      Agata Cacko authored
      Before this patch, there were two layers of error codes:
      KisImageBuilder_Result in KisImageBuilderResult.h
      later converted into ConversionStatus in KisImportExportFilter.h
      In case of usage of libraw, there were also libraw error codes.
      After this patch, only one error code system and error messages system
      is implemented. Error codes should match the previous ones,
      but are not necessarily correct now.
      e518e102
  6. 04 May, 2019 1 commit
    • Dmitry Kazakov's avatar
      Implement a projection store for masks (for indirect painting) · 0ed30208
      Dmitry Kazakov authored
      We have implemented correct painting on masks, but we have never
      implemented a projection for them. Indeed, for normal rendering
      process they don't need it. But when a mask is selected in isolated
      mode, it still needs a projection, so that the use could see the result
      of the painting.
      
      BUG:403576
      0ed30208
  7. 01 Mar, 2019 1 commit
  8. 11 Oct, 2018 1 commit
  9. 07 Oct, 2018 2 commits
  10. 06 Oct, 2018 1 commit
  11. 23 Aug, 2018 1 commit
  12. 21 Aug, 2018 1 commit
  13. 14 Aug, 2018 2 commits
  14. 08 Aug, 2018 1 commit
  15. 07 Aug, 2018 1 commit
    • Dmitry Kazakov's avatar
      Make sgrb-trc color profile be the default for GrayAU8 color space · 24d6bfb7
      Dmitry Kazakov authored
      It fixes loading/saving of PNG images (and the
      corresponding unittest).
      
      WARNING:
      This patch also makes linear profile to be a default for
      GrayAF16, GrayAU16 and GrayAF32 color spaces. Theoretically,
      it can break loading some file formats. I have already fixed
      PNG and TIFF. What else can load GrayA16+?
      24d6bfb7
  16. 05 Aug, 2018 2 commits
  17. 31 Jul, 2018 1 commit
    • Boudewijn Rempt's avatar
      "Fix" the jpeg unittest · f6b2342b
      Boudewijn Rempt authored
      JPeg needs extreme amounds of fuzziness, and even then, the saved
      result will often be hugely different, yet still recognizable.
      f6b2342b
  18. 27 Jul, 2018 2 commits
  19. 25 Jul, 2018 2 commits
    • Boudewijn Rempt's avatar
      Use KISTEST_MAIN where necessary · 5c60d63d
      Boudewijn Rempt authored
      5c60d63d
    • Boudewijn Rempt's avatar
      Make it possible for tests to access resources · f9ee9a42
      Boudewijn Rempt authored
      If a test needs access to the resources in the install folder, it
      needs to use KISTEST_MAIN instead of QTEST_MAIN. This will set an
      env variable, EXTRA_RESOURCE_DIRS, where KoREsourcePaths will then
      also look.
      
      Also remove the setReady/isReady methods for KoResourcePaths: we
      don't need that. We can add resource dirs in as many places as
      we want.
      
      CCMAIL:kimageshop@kde.org
      f9ee9a42
  20. 10 Jul, 2018 1 commit
  21. 04 Jul, 2018 1 commit
    • Dmitry Kazakov's avatar
      Test for rectangular artifacts on transparency masks · cf035350
      Dmitry Kazakov authored
      The problem itself is not solved yet. Only a test that
      can reproduce it in a stable way is implemented.
      
      The only things that I know right now is:
      
      1) The problem is related to multithreading. It doesn't
         appear when the number of threads is limited to 1.
      
      2) Artifacts appear only after clearing the transparency
         paint device.
      
      3) Artifacts are neither present in the transparency mask
         paint device, nor in the projection of its parent layer.
      
      4) Artifacts appear in the final image projection, right
         when the async merger calls layer->projectionPlane()->
         ->apply().
      
      5) Changing dirtyRect in KisToolUtils::clearImage() to the
         entire image bounds doesn't help much.
      
      
      CCBUG:395273
      cf035350
  22. 10 May, 2018 1 commit
  23. 05 Apr, 2018 1 commit
    • Jouni Pentikäinen's avatar
      Refactor how views access their main window · 01e3e1bf
      Jouni Pentikäinen authored
      Code in KisCanvasControllerWidget assumed that they are children of the
      main window. This assumption will be broken by the detached canvas mode.
      Instead, the access is now routed through KisViewManager.
      
      To ensure that KisView knows of KisViewManager early enough, its
      construction has been refactored as well.
      01e3e1bf
  24. 15 Mar, 2018 1 commit
    • Boudewijn Rempt's avatar
      Resources: Remove KoResourceLoaderThread · 5d361cf0
      Boudewijn Rempt authored
      All resources were loaded synchronously by now, so KoResourceLoaderThread
      was obsolete. This also moved the bundle server to it's own singleton,
      since it needs a completely instantiated singleton of KisResourceServerProvider.
      
      KisApplication now instantiates the singletons in the correct order, without
      superfluously getting the actual resource providers. Since the order is now
      properly known, we can clear the empty krita 3 system preset tags from the
      tag database after loading the last bundles. However, the tag system seems
      to be case-insensitive, but we used to have both ink and Ink; that still
      needs fixing.
      
      This fixes item 2 from
      
      CCBUG:391576
      
      Curiously enough, this also makes Krita start quite a bit faster for me...
      5d361cf0
  25. 09 Feb, 2018 1 commit
    • Dmitry Kazakov's avatar
      Fix KisShapeLayerTest · b356eab8
      Dmitry Kazakov authored
      Now when both KisShapeLayer and KisTransformMask use
      KisDelayedUpdateNodeInterface, which recalculates itself after on
      a time basis, we cannot just do waitForDone() and hope that the layer
      will be fully prepared. Instead we should add a round of forcing delayed
      layers and waiting again.
      b356eab8
  26. 05 Feb, 2018 1 commit
    • Dmitry Kazakov's avatar
      Fix merging of two shape layers (also after scaling) · f2ad5ab4
      Dmitry Kazakov authored
      1) Implement correct reordering of the shapes according to zIndex
         (see KoShapeReorderCommand::mergeDownShapes()). Added
         homogenizeZIndexes() function, that can be reused in other cases
         for linearizing the indexes
      
      2) KisShapeLayer should be linked to its own KoShapeManager, otherwise
         transformations of the layer will not issue updates.
      
      3) KisShapeLayerCanvas::updateCanvas() should use toAlignedRect() to
         handle antialiasing correctly.
      
      The patch also adds a unittest for checking all these bugs :)
      
      BUG:389905
      f2ad5ab4
  27. 01 Feb, 2018 1 commit
  28. 06 Jan, 2018 1 commit
  29. 22 Dec, 2017 1 commit
  30. 14 Nov, 2017 1 commit