1. 10 Jan, 2020 2 commits
    • Boudewijn Rempt's avatar
      Remove commented-out code · d8dce334
      Boudewijn Rempt authored
      d8dce334
    • Boudewijn Rempt's avatar
      Clear the activationLocks before deactivating the Stroke and Fill config widgets · 7f7d98d9
      Boudewijn Rempt authored
      When loading a file with a vector layer, the node manager will
      activate and deactivate the default tool in the wrong order. This
      cannot be worked around; and in fact, we get a LOT of activate
      and deactivate calls because just creating the config widgets will
      call those:
      
      KoStrokeConfigWidget::KoStrokeConfigWidget DefaultToolTabbedWidget(0x562719ef0e00, name="default-tool-tabbed-widget")
      KoFillConfigWidget::KoFillConfigWidget KoFillConfigWidget(0x562719f206a0)
      KoFillConfigWidget::deactivate() KoFillConfigWidget(0x562719f206a0, name="KoFillConfigWidget")  locks: 0
      KoFillConfigWidget::activate() KoFillConfigWidget(0x562719f206a0, name="KoFillConfigWidget") 2
      KoStrokeConfigWidget::deActivate(): locks 0
      KoFillConfigWidget::deactivate() KoFillConfigWidget(0x562719f206a0, name="KoFillConfigWidget")  locks: 0
      KoFillConfigWidget::KoFillConfigWidget KoFillConfigWidget(0x56271a039190)
      KoFillConfigWidget::deactivate() KoFillConfigWidget(0x56271a039190, name="KoFillConfigWidget")  locks: 0
      KoFillConfigWidget::activate() KoFillConfigWidget(0x56271a039190, name="KoFillConfigWidget") 2
      KoStrokeConfigWidget::activate(): locks 2
      KoFillConfigWidget::activate() KoFillConfigWidget(0x562719f206a0, name="KoFillConfigWidget") 2
      KoFillConfigWidget::deactivate() KoFillConfigWidget(0x56271a039190, name="KoFillConfigWidget")  locks: 0
      KoStrokeConfigWidget::deActivate(): locks 0
      KoFillConfigWidget::deactivate() KoFillConfigWidget(0x562719f206a0, name="KoFillConfigWidget")  locks: 0
      KoFillConfigWidget::deactivate() KoFillConfigWidget(0x56271a039190, name="KoFillConfigWidget")  locks: 2
      SAFE ASSERT (krita): "d->deactivationLocks.empty()" in file /home/boud/dev/krita/libs/ui/widgets/KoFillConfigWidget.cpp, line 358
      KoStrokeConfigWidget::deActivate(): locks 2
      SAFE ASSERT (krita): "d->deactivationLocks.empty()" in file /home/boud/dev/krita/libs/ui/widgets/KoStrokeConfigWidget.cpp, line 481
      
      BUG:416000
      7f7d98d9
  2. 09 Jan, 2020 1 commit
    • Lamarque Souza's avatar
      Commit 97c03e0f was reverted · 8a0b7cbe
      Lamarque Souza authored
      by ef55574a and then the crash
      happens again.
      
      I have tested this change and it does not break PalleteDocker.
      
      PS: KIS_ASSERT_RECOVER_RETURN_VALUE trigger an assert and krita
      fails to start up. KisPaletteModel::index works if I use
      KIS_SAFE_ASSERT_RECOVER_RETURN_VALUE and change
      KoColorSet::getGroup to return null pointer when its name
      parameter is an empty string, but KisSwatchGroup::rowCount
      crashes, so I think it is simpler to return an default
      QModelIndex as soon as possible in KisPaletteModel::index
      
      CCBUG:414890
      8a0b7cbe
  3. 08 Jan, 2020 3 commits
  4. 07 Jan, 2020 6 commits
  5. 06 Jan, 2020 2 commits
  6. 05 Jan, 2020 1 commit
  7. 03 Jan, 2020 4 commits
  8. 19 Dec, 2019 1 commit
  9. 16 Dec, 2019 1 commit
  10. 09 Dec, 2019 2 commits
    • Agata Cacko's avatar
      Fix crash opening .kra with incorrect clone source · cf368266
      Agata Cacko authored
      Before this commit, files created using copying and pasting
      clone layers from one file to another would be corrupted
      and crash Krita when the user tried to open them.
      This commit fixes crashing on opening those files.
      After this commit, all clone layers are replaced by
      empty paint layers. (Empty, because all data is lost).
      
      CCBUG:414699
      cf368266
    • Jasper Hartog's avatar
      Fix comparison of double spin box · 8bc2965d
      Jasper Hartog authored
      When the value of a QDoubleSpinBox is changed it will be round down to the amount of decimals that are assigned to that spin box. The KisDoubleParseSpinBox would check the new unrounded value with the current rounded value, which resulted in an incorrect comparison.
      8bc2965d
  11. 05 Dec, 2019 1 commit
  12. 04 Dec, 2019 4 commits
  13. 02 Dec, 2019 3 commits
    • Agata Cacko's avatar
      Fix crash using onion skins on non-animated layers · 089a28f9
      Agata Cacko authored
      Using onion skins on layers without any content keyframes
      is possible if one is using opacity keyframes.
      Before this commit, turning onion skins on would cause a crash.
      After this commit, turning onion skins on will do nothing.
      
      BUG:414668
      089a28f9
    • Agata Cacko's avatar
      Fix Grow Selection expanding in one direction · b49d9789
      Agata Cacko authored
      Before this commit there was a mistake in calculating
      the border of the selection. It was caused by misreading
      the original calculation equation while fixing the
      CID issue (dividing by 0).
      This commit fixes the behaviour by ensuring that
      the value is being multiplied, not divided by sqrt.
      
      BUG:414647
      b49d9789
    • Yuri Chornoivan's avatar
      Update URLs · d4dfd7b6
      Yuri Chornoivan authored
      d4dfd7b6
  14. 01 Dec, 2019 1 commit
  15. 30 Nov, 2019 1 commit
    • Lamarque Souza's avatar
      Fix crash when starting Krita with Qt compiled in debug mode. · 97c03e0f
      Lamarque Souza authored
      This is the backtrace:
      
      0  0x00007ffff38a11cc in KoColorSet::getGroup(QString const&) () from
      /usr/lib64/libkritapigment.so.18
      1  0x00007ffff3d2aa69 in KisPaletteModel::index(int, int, QModelIndex
      const&) const () from /usr/lib64/libkritawidgets.so.18
      2  0x00007ffff5812796 in
      QAbstractItemView::setModel(QAbstractItemModel*) () from
      /usr/lib64/libQt5Widgets.so.5
      3  0x00007ffff582e749 in QHeaderView::setModel(QAbstractItemModel*) ()
      from /usr/lib64/libQt5Widgets.so.5
      4  0x00007ffff5871493 in QTableView::setModel(QAbstractItemModel*) ()
      from /usr/lib64/libQt5Widgets.so.5
      5  0x00007ffff3d31e17 in
      KisPaletteView::setPaletteModel(KisPaletteModel*) () from
      /usr/lib64/libkritawidgets.so.18
      6  0x00007ffff3d2691e in
      KisDlgInternalColorSelector::KisDlgInternalColorSelector(QWidget*,
      KoColor, KisDlgInternalColorSelector::Config, QString const&,
      KoColorDisplayRendererInterface const*) () from
      /usr/lib64/libkritawidgets.so.18
      7  0x00007ffff7000d67 in
      KoDualColorButton::Private::init(KoDualColorButton*) () from
      /usr/lib64/libkritaui.so.18
      8  0x00007ffff7002c5b in KoDualColorButton::KoDualColorButton(KoColor
      const&, KoColor const&, KoColorDisplayRendererInterface const*,
      QWidget*, QWidget*) ()
        from /usr/lib64/libkritaui.so.18
      9  0x00007ffff6e2b5b5 in KisControlFrame::setup(QWidget*) () from
      /usr/lib64/libkritaui.so.18
      10 0x00007ffff71014ea in KisViewManager::KisViewManager(QWidget*,
      KActionCollection*) () from /usr/lib64/libkritaui.so.18
      11 0x00007ffff70cb72b in KisMainWindow::KisMainWindow(QUuid) () from
      /usr/lib64/libkritaui.so.18
      12 0x00007ffff70d8352 in KisPart::createMainWindow(QUuid) () from
      /usr/lib64/libkritaui.so.18
      13 0x00007ffff70d85de in KisPart::startBlankSession() () from
      /usr/lib64/libkritaui.so.18
      14 0x00007ffff70995b9 in KisApplication::start(KisApplicationArguments
      const&) () from /usr/lib64/libkritaui.so.18
      15 0x0000555555e4e229 in main ()
      
      The KisPaletteModel::index() call is inside an Q_ASSERT_X in
      QAbstractItemView::setModel(), so you have to compile Qt in debug mode
      to reproduce this crash.
      
      m_rowGroupNameMap is empty during the startup.
      97c03e0f
  16. 29 Nov, 2019 1 commit
  17. 27 Nov, 2019 1 commit
  18. 25 Nov, 2019 1 commit
  19. 20 Nov, 2019 4 commits