1. 16 Oct, 2019 1 commit
  2. 02 Oct, 2019 1 commit
  3. 30 Sep, 2019 1 commit
  4. 26 Sep, 2019 2 commits
    • Boudewijn Rempt's avatar
      CID 35534: Uninitialized pointer field (UNINIT_CTOR) · 2354e8f3
      Boudewijn Rempt authored
      18. uninit_member: Non-static class member _lastOpacityData is not
      initialized in this constructor nor in any functions that it calls.
      
      2. uninit_member: Non-static class member dstRowStart is not initialized
      in this constructor nor in any functions that it calls.
      
      4. uninit_member: Non-static class member dstRowStride is not initialized
      in this constructor nor in any functions that it calls.
      
      6. uninit_member: Non-static class member srcRowStart is not initialized
      in this constructor nor in any functions that it calls.
      
      8. uninit_member: Non-static class member srcRowStride is not initialized
      in this constructor nor in any functions that it calls.
      
      10. uninit_member: Non-static class member maskRowStart is not initialized
      in this constructor nor in any functions that it calls.
      
      12. uninit_member: Non-static class member maskRowStride is not
      initialized in this constructor nor in any functions that it calls.
      
      14. uninit_member: Non-static class member rows is not initialized in
      this constructor nor in any functions that it calls.
      
      16. uninit_member: Non-static class member cols is not initialized in
      this constructor nor in any functions that it calls.
      2354e8f3
    • Boudewijn Rempt's avatar
      CID: 35533 Uninitialized pointer field (UNINIT_CTOR) · bddb196a
      Boudewijn Rempt authored
      4. uninit_member: Non-static class member m_group is not initialized in
      this constructor nor in any functions that it calls.
      bddb196a
  5. 24 Sep, 2019 1 commit
  6. 23 Sep, 2019 2 commits
    • Krzysztof Kurek's avatar
      Clean up compilation log from deprecations · f867486c
      Krzysztof Kurek authored
      Bunch of misc commits that remove warnings about
      deprecation in places where it doesn't affect code much.
      
      !150
      
      Squashed commit of the following:
      
      commit 10429761
      Author: Krzysztof Kurek <krzysio.kurek@wp.pl>
      Date:   Mon Sep 23 13:48:36 2019 +0000
      
          Remove a Qt5.13 function call
      
      commit 232ac699
      Author: Krzysztof Kurek <krzysio.kurek@pm.me>
      Date:   Sat Sep 21 17:14:36 2019 +0200
      
          Remove a CXX specific flag from other targets
      
      commit 6b71a3cc
      Author: Krzysztof Kurek <krzysio.kurek@pm.me>
      Date:   Sat Sep 21 17:12:34 2019 +0200
      
          Even more deprecation removal work
      
      commit 9c4972ad
      Author: Krzysztof Kurek <krzysio.kurek@pm.me>
      Date:   Sat Sep 21 14:10:44 2019 +0200
      
          Revert some const-ref changes
      
          Also explicitly mark KisOptionInfo's copy-ctor as being present
      
      commit f13ff926
      Author: Krzysztof Kurek <krzysio.kurek@pm.me>
      Date:   Fri Sep 20 01:15:47 2019 +0200
      
          A bunch more deprecation fixes
      
          Hopefully it all works... I don't have a second screen to test it thorough.
      
      commit 95c1ee12
      Author: Krzysztof Kurek <krzysio.kurek@pm.me>
      Date:   Thu Sep 19 20:32:47 2019 +0200
      
          Get rid of a few implicit deprecation warnings
      
          Deleted some superfluous constructor definitions,
          explicitly declared operator= of SvgGraphicsContext as default but only for private usage.
      
      commit 35d2f530
      Author: Krzysztof Kurek <krzysio.kurek@pm.me>
      Date:   Thu Sep 19 20:30:35 2019 +0200
      
          Simplify KisSwatch class
      
          Removes a warning about implicit deprecation
      f867486c
    • Krzysztof Kurek's avatar
      Fix the palletize crash · 9fd34885
      Krzysztof Kurek authored
      getColorGlobal no longer modifies global and simply returns the color.
      9fd34885
  7. 22 Sep, 2019 1 commit
    • Mathias Wein's avatar
      Fix KoColor::setColor() · f5dd77bf
      Mathias Wein authored
      It did not update m_size to match the given color profile,
      which causes a corrupt internal state.
      f5dd77bf
  8. 21 Sep, 2019 1 commit
  9. 16 Sep, 2019 1 commit
  10. 12 Sep, 2019 1 commit
  11. 05 Sep, 2019 3 commits
    • Mathias Wein's avatar
      Add isLinear() query function to KoColorProfile · f1f556e3
      Mathias Wein authored
      Returns true if a color profile has only linear transfer response curves.
      This implies that that it has transfer response curves.
      
      Hint: The abstract class IccColorProfile::Profile doesn't really seem
      to server any really purpose anymore (if it ever did), so I didn't touch
      its interface. It might be time to remove it and use non-virtual functions.
      f1f556e3
    • Wolthera van Hövell's avatar
      Make use of LCMS' copy alpha flag instead of copying alpha ourselves. · 48d339ea
      Wolthera van Hövell authored
      This should make color management related transforms a bit faster, as
      well as simplifying the code. Given an enum in the depths of the pigment
      jungle is being changed, it takes long to compile.
      
      boud thought there was more alpha handling that needed to be changed,
      but this is the only place I can see with a workaround...
      
      Ref T3503
      48d339ea
    • Dmitry Kazakov's avatar
      Do not include KoCompositeOps.h where not needed · 6bef07c0
      Dmitry Kazakov authored
      Use KoCompositeOpRegistry.h to get IDs of the composite opsinstead.
      The former one is used by colorspaces to actually create the composite
      op objects.
      6bef07c0
  12. 02 Sep, 2019 2 commits
  13. 01 Aug, 2019 2 commits
    • Boudewijn Rempt's avatar
      Modernize initializers · 5645fdef
      Boudewijn Rempt authored
      5645fdef
    • Karl Ove Hufthammer's avatar
      Use translation of unnamed (‘Untitled’) colours · acf34791
      Karl Ove Hufthammer authored
      All of the colour palettes included in Krita that have unnamed colours,
      have actually the colour names set to ‘Untitled’ in the .gpl files,
      instead of having empty names (I’m not sure it’s valid to have empty
      names, though). So the code that tried to show unnamed colours as the
      translation of the string ‘Untitled’, did not succeed. Now, colours with
      empty names or the name ‘Untitled’ are treated the same, so that the
      i18n() call always succeeds for unnamed colours.
      acf34791
  14. 29 Jul, 2019 1 commit
    • Eoin O'Neill's avatar
      Gradient Stop Sorting by Value · fa3c22de
      Eoin O'Neill authored
      Adds right click context menu to gradient editor widget with the ability
      to sort gradients by value. 'Sort by Value' simply sorts the values onto
      the gradient by the value of the color and thus is distributed
      appropriately. 'Sort by Value (Even Distribution)' sorts the stops by
      value but instead of placing them by color value onto the gradient, it
      evenly distributes the colors across the entire gradient space. Both of
      these values can be flipped using the 'reverse' button or the reverse
      option in the right click menu.
      fa3c22de
  15. 19 Jul, 2019 2 commits
  16. 17 Jul, 2019 1 commit
  17. 13 Jul, 2019 1 commit
    • Boudewijn Rempt's avatar
      Use QFileInfo::completeBaseName instead of baseName · 14adaa3b
      Boudewijn Rempt authored
      This makes it possible for users to use dots in their filenames.
      Not that that is a good idea, everything after the first dot is
      technically an extensions, as in bla.tar.gz, but Krita doesn't
      handle any file formats where that actually happens, so we can
      be a bit less technically correct when handling filenames and
      only check the extension after the last dot.
      
      BUG:409765
      14adaa3b
  18. 10 Jul, 2019 2 commits
    • Boudewijn Rempt's avatar
      Fix warning -Wclass-memaccess · ca741341
      Boudewijn Rempt authored
      In file included from /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpCopy2.h:26,
                       from /home/boud/dev/krita/libs/pigment/colorspaces/KoAlphaColorSpace.cpp:35:
      /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpBase.h: In instantiation of ‘void KoCompositeOpBase<_CSTraits, _compositeOp>::genericComposite(const KoCompositeOp::ParameterInfo&, const QBitArray&) const [with bool useMask = true; bool alphaLocked = true; bool allChannelFlags = true; _CSTraits = KoColorSpaceTrait<half, 1, 0>; _compositeOp = AlphaColorSpaceMultiplyOp<KoColorSpaceTrait<half, 1, 0> >]’:
      /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpBase.h:67:72:   required from ‘void KoCompositeOpBase<_CSTraits, _compositeOp>::composite(const KoCompositeOp::ParameterInfo&) const [with _CSTraits = KoColorSpaceTrait<half, 1, 0>; _compositeOp = AlphaColorSpaceMultiplyOp<KoColorSpaceTrait<half, 1, 0> >]’
      /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpBase.h:58:10:   required from here
      /home/boud/dev/krita/libs/pigment/compositeops/KoCompositeOpBase.h:110:27: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘KoCompositeOpBase<KoColorSpaceTrait<half, 1, 0>, AlphaColorSpaceMultiplyOp<KoColorSpaceTrait<half, 1, 0> > >::channels_type’ {aka ‘class half’} with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
                           memset(dst, 0, pixel_size);
                           ~~~~~~^~~~~~~~~~~~~~~~~~~~
      ca741341
    • Boudewijn Rempt's avatar
      Try to make the kis_tiff_test run on Jenkins · 5830646d
      Boudewijn Rempt authored
      No need to assert if a certain profile cannot be found; we can
      disregard that and handle not getting a colorspace back.
      5830646d
  19. 06 Jul, 2019 1 commit
    • Dmitry Kazakov's avatar
      Disable AVX optimizations for 32-bit composite ops · cd5450a8
      Dmitry Kazakov authored
      They cause artifacts and we don't have a fix yet :(
      
      CCBUG:404133
      
      Note from the committer:
      This commit was initially made on krita/4.2 branch.
      However between 4.2.1 and 4.2.2 the stable branch was
      reconstructed, which caused all commits that were exclusively
      on the previous krita/4.2 (and not on master) to be missing.
      
      The previous commit hash: d3e4c3aa
      
      Also regarding the artifacts: it never worked, optimization were
      enabled during the creamy flow implementation, but they never should
      be enabled until someone fix them properly.
      cd5450a8
  20. 05 Jul, 2019 1 commit
  21. 01 Jul, 2019 1 commit
  22. 24 Jun, 2019 1 commit
  23. 21 Jun, 2019 1 commit
  24. 15 Jun, 2019 2 commits
  25. 08 Jun, 2019 4 commits
  26. 05 Jun, 2019 1 commit
  27. 14 May, 2019 1 commit
  28. 10 May, 2019 1 commit