1. 26 Sep, 2019 1 commit
    • Boudewijn Rempt's avatar
      CID 35534: Uninitialized pointer field (UNINIT_CTOR) · 2354e8f3
      Boudewijn Rempt authored
      18. uninit_member: Non-static class member _lastOpacityData is not
      initialized in this constructor nor in any functions that it calls.
      
      2. uninit_member: Non-static class member dstRowStart is not initialized
      in this constructor nor in any functions that it calls.
      
      4. uninit_member: Non-static class member dstRowStride is not initialized
      in this constructor nor in any functions that it calls.
      
      6. uninit_member: Non-static class member srcRowStart is not initialized
      in this constructor nor in any functions that it calls.
      
      8. uninit_member: Non-static class member srcRowStride is not initialized
      in this constructor nor in any functions that it calls.
      
      10. uninit_member: Non-static class member maskRowStart is not initialized
      in this constructor nor in any functions that it calls.
      
      12. uninit_member: Non-static class member maskRowStride is not
      initialized in this constructor nor in any functions that it calls.
      
      14. uninit_member: Non-static class member rows is not initialized in
      this constructor nor in any functions that it calls.
      
      16. uninit_member: Non-static class member cols is not initialized in
      this constructor nor in any functions that it calls.
      2354e8f3
  2. 07 Feb, 2019 1 commit
  3. 26 Jun, 2018 1 commit
    • Miguel Lopez's avatar
      Quadratic Blending Modes · 563269c9
      Miguel Lopez authored
      Summary:
      During the creation of Quadratic Blending Modes, I have did the following:
      
        - Add new category suitable for quadratic blending modes
       -  I copied and paste existing codes, and created new codes used to calculate blending of images accordingly to the Pegtop formula reference sheet
      - I have tested the 4 new blending modes, and keep adjusting until the blending modes matches that of the Pegtop blending modes
      
      -----
      - Before the testing plan, find a way to make freeze and heat with acceptable coding. Reflect Blend Mode has now been solved.
      
      Test Plan:
      - Have artists find usage of quadratic blend modes, and see if they find the blending modes useful
      - Test results of quadratic blend modes with existing programs (As far as I"m concerned, only reflect and glow are available for testing)
      -If all seem sounds, and ready to go, then maybe it can be patched in Krita
      
      Reviewers: #krita, dkazakov
      
      Subscribers: dkazakov
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D13383
      563269c9
  4. 15 Jun, 2018 1 commit
    • Miguel Lopez's avatar
      Quadratic Blending Modes · 41c72fc7
      Miguel Lopez authored
      Summary:
      During the creation of Quadratic Blending Modes, I have did the following:
      
        - Add new category suitable for quadratic blending modes
       -  I copied and paste existing codes, and created new codes used to calculate blending of images accordingly to the Pegtop formula reference sheet
      - I have tested the 4 new blending modes, and keep adjusting until the blending modes matches that of the Pegtop blending modes
      
      -----
      - Before the testing plan, find a way to make freeze and heat with acceptable coding. Reflect Blend Mode has now been solved.
      
      Test Plan:
      - Have artists find usage of quadratic blend modes, and see if they find the blending modes useful
      - Test results of quadratic blend modes with existing programs (As far as I"m concerned, only reflect and glow are available for testing)
      -If all seem sounds, and ready to go, then maybe it can be patched in Krita
      
      Reviewers: #krita, dkazakov
      
      Subscribers: dkazakov
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D13383
      41c72fc7
  5. 20 Sep, 2017 1 commit
    • Dmitry Kazakov's avatar
      Implement the first version of the multithreaded Pixel Brush · e03e9533
      Dmitry Kazakov authored
      All the presets that use Pixel Brush (KisBrushOp) are now
      multithreaded and rendered asynchronously. Basically, it means
      that if the brush is too slow, Krita will lower down FPS rate
      for the sake of faster rendering of the stroke.
      
      
      Short summary:
      
      1) It doesn't use strokes system's threading, just QtConcurrent. It
         is not good, but works for now. I hope it is only a temporary
         solution.
      
      2) Updates are coming asynchronously with the period of 20...80ms,
         which is 50...12fps. I didn't manage to implement a correct control
         loop for auto-adjusting the FPS value, because it needs porting the
         threading part into strokes system and a bit of refactoring of
         the strokes system itself. Therefore, the FPS adjustment is controlled
         by an open-loop system, based on one-dab-rendering-time. Basically,
         FPS is proportional to the time spent on rendering a single tile.
      
      3) The patch adds two new API functions: KisPaintOpSettings::
         needsAsynchronousUpdates() tells if the paintop uses threading and
         needs asynchronous updates. When this function returns true, the
         freehand stroke does additional calls to
         KisPaintOp::doAsyncronousUpdate(), which does the rendering itself.
      
      4) Still to be implemented:
           * color source options
           * postprocessing: sharpness and texturing
           * selection handling (works only in Wash mode)
           * mirroring mode
           * pipe brushes
      
      CC:kimageshop@kde.org
      e03e9533
  6. 10 Sep, 2015 1 commit
  7. 02 Sep, 2015 1 commit
  8. 15 Jan, 2015 1 commit
  9. 24 Oct, 2014 1 commit
  10. 03 Oct, 2014 1 commit
  11. 30 Dec, 2013 1 commit
  12. 25 Sep, 2013 2 commits
  13. 02 Jul, 2013 1 commit
  14. 29 Jun, 2013 1 commit
    • Dmitry Kazakov's avatar
      Fixed a pressure bug in Wash-mode of painting · c2fcdced
      Dmitry Kazakov authored
      When the pressure drops, the opacity drops as well. In this moment, to
      avoid the artifacts while painting the ALPHA_DARKEN op should work in a
      reversed way. That is the contents of the layer should be painted on the
      top of the brush dab. To allow this, we now keep the average value of the
      opacity of several last dabs to be able to reverse the composite op.
      
      This is tested to work best with spacings 0.1-0.2. With other spacing
      values, probably, one needs to correct exponent value in
      ParameterInfo::updateOpacityAndAverage().
      
      CCBUG:320651
      c2fcdced
  15. 16 Oct, 2012 1 commit
    • Dmitry Kazakov's avatar
      Added Vc implementation of the "over" composite · 8e76b3b6
      Dmitry Kazakov authored
      There is still one bug in both the composites: the calculation
      of a single pixel compositions should be done in float instead of
      integers, otherwise it causes artifacts on the canvas during painting.
      8e76b3b6
  16. 24 Apr, 2012 1 commit
  17. 16 Apr, 2012 1 commit
  18. 23 Oct, 2011 3 commits
    • Boudewijn Rempt's avatar
      Remove KoCompositeOp::userVisible · 8c23368c
      Boudewijn Rempt authored
      userVisible was no longer used, so remove from the api. Query: isn't
      the category string also obsolete since commit 84e57495069833f647f7a41511d451eafae69737
      (Replaced the old composite op ComboBox with a new one.)?
      8c23368c
    • Boudewijn Rempt's avatar
      2d20d6e5
    • Boudewijn Rempt's avatar
      Make composite copy visible again · 9cf098ce
      Boudewijn Rempt authored
      Commit 84e57495069833f647f7a41511d451eafae69737 dated Sep 17 2011
      by  Silvio Heinrich (Replaced the old composite op ComboBox with a new one.)
      replaced the dynamic userVisible method of showing/hiding composite ops
      with a map.
      
      This commit adds COMPOSITE_COPY to that map. Next commit will remove
      userVisbile everywhere.
      9cf098ce
  19. 14 Jun, 2011 3 commits
  20. 10 Jun, 2011 1 commit
  21. 06 Jun, 2011 2 commits
  22. 03 Jun, 2011 2 commits
  23. 11 Feb, 2011 1 commit
  24. 03 Jan, 2010 1 commit
  25. 26 Apr, 2009 1 commit
  26. 11 Feb, 2008 1 commit
  27. 12 Nov, 2007 1 commit
  28. 22 Oct, 2007 1 commit
  29. 07 Sep, 2007 1 commit
  30. 30 Aug, 2007 1 commit
  31. 24 Mar, 2007 1 commit
  32. 21 Mar, 2007 1 commit
  33. 27 Dec, 2006 1 commit