1. 01 Aug, 2020 1 commit
    • Nate Graham's avatar
      [kcms/notifications] Use Kirigami.BasicListItem instead of custom delegate · 6025f926
      Nate Graham authored
      There's no need since the custom delegate was manufacturing the exact
      same look that a Kirigami.BasicListitem can provide with the hidden
      separator setting. However this commit does not use that setting, so as
      a result the separators now become visible. This makes the list
      consistent with other lists in QML-based software.
      
      My sense is that the reason why we hid the lines in the past was
      because the lines had a very heavy appearance, but that was improved
      recently to look much more lightweight.
      6025f926
  2. 31 Jul, 2020 3 commits
    • David Redondo's avatar
      Use some() for searching in list of model indices · 27e1c236
      David Redondo authored
      includes() compares for equality, two objects are only equal if both reference
      the same object. The active task model index is not necessarily the same as the
      indx corresponding to it in the list because they are created seperately.
      Alternatively we can just check if some index in the list is active.
      27e1c236
    • David Redondo's avatar
      Hardcode icons for default plasma components · ad97508a
      David Redondo authored
      Unfortunately are components free to choose their unique component name any way
      they like, that means we have no chance to reasonably map a KService/icon to a
      component if its identifier is chosen badly. For presentation purposes we can
      at least hardcode some icons for components that are active in a default plasma
      session.
      CCBUG:424197
      CCBUG:424198
      CCBUG:424194
      CCBUG:424195
      ad97508a
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · e7c8cb4e
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      e7c8cb4e
  3. 30 Jul, 2020 3 commits
    • Felix Ernst's avatar
      [kcms/fonts] (Re-)Add tooltips using a contextual help button · ca49df93
      Felix Ernst authored
      This commit adds tooltips to font settings for which the label alone isn't
      sufficient for laymans to understand their effect. Similar explanations
      were previously available in the form of "What's This?"-help but got lost
      in commit R119:24b960f9: "QML port of fonts kcm" perhaps because
      tooltip functionality was not readily available at the time. The
      tooltips added here are partly based on these older ones.
      
      The tooltips are invoked by either hovering or clicking flat Contextual
      Help Buttons. This way the available help is unintrusively visible and
      can be easily invoked on touch devices.
      ca49df93
    • Jan Blackquill's avatar
      [kcms/users]: focus password field on sheet open · d0e89b82
      Jan Blackquill authored
      BUG: 422170
      d0e89b82
    • Jan Blackquill's avatar
      [kcms/users] Bail out on trying to apply user when an error encounters · 36e9218f
      Jan Blackquill authored
      While there's not a graceful way to discern between user cancellation and an actual error,
      the former is more likely so we bail out when encountering an error.
      
      BUG: 422175
      36e9218f
  4. 29 Jul, 2020 6 commits
    • Nate Graham's avatar
    • Jan Blackquill's avatar
    • Nate Graham's avatar
      [applets/taskmanager] Make new "cycle through tasks" option the default · c73f703c
      Nate Graham authored
      This is ultimately the sanest default as it provides the quickest way to
      perform the two most common actions for grouped tasks: switching to the
      last-used one, or hunting through all of them to find the one you want.
      The "Cycle through task" option allows you to perform both actions with
      clicks on the same icon, meaning that you don't have to move your cursor
      or your visual focus compared to using any of the other three methods.
      
      CCBUG: 370258
      c73f703c
    • Nate Graham's avatar
      [applets/taskmanager] Add option to cycle through grouped tasks on click · 39eaa549
      Nate Graham authored
      This implements a fairly common feature request to cycle through grouped
      tasks when clicking on the group. There are two behaviors depending on
      the active currentlytask:
      
      - If the currently active task is not among the tasks of the clicked-on
        app/grouped task, then the most-recently used task in the group is
        brought forward.
      - Otherwise, the next task in the group is brought forward, ignoring the
        stacking order, and instead going by the order of the indexes in the
        tasks model. This is deliberate; cycling through all tasks according
        to stacking order does not work because the stacking order changes
        every time a task is. Not using the stacking order for this case
        preserves the cycle order to improve the user's muscle memory when
        cycling through a large number of tasks.
      
      As a result, it becomes ixtremely simple to switch between two
      recently-used windows belonging to different apps when one or both
      are within groups. With this mode, it takes only a single click. And
      switching between multiple tasks of the same app likewise becomes simple
      since you don't have to move your cursor from the grouped task icon;
      instead you just keep clicking until you find the task you want.
      
      FEATURE: 370258
      FIXED-IN: 5.20.0
      39eaa549
    • Bhushan Shah's avatar
      e7ba61d6
    • Michael Weghorn's avatar
      kcmaccess: Allow configuring Orca on Wayland · 923e7972
      Michael Weghorn authored
      The Orca screen reader works on Wayland, so allow
      to enabled/disable and configure it in the KCM when
      in a Wayland session as well.
      
      This removes the restriction that kcmaccess was only
      available on X11/XCB, yet disables all tabs except
      the screen reader one, since the other features
      that could be configured didn't seem to work in a
      quick test on Wayland.
      
      BUG: 414546
      923e7972
  5. 28 Jul, 2020 2 commits
  6. 27 Jul, 2020 2 commits
  7. 26 Jul, 2020 1 commit
  8. 25 Jul, 2020 1 commit
  9. 24 Jul, 2020 2 commits
  10. 23 Jul, 2020 3 commits
    • Nate Graham's avatar
      [applets/taskmanager] Offer better options when activating grouped tasks · ebaddb7d
      Nate Graham authored
      Currently we get many complaints about the behavior of clicking on
      grouped tasks, especially for the Icons-Only Task Manager, where the
      Present Windows effect is always used when available.
      
      This commit overhauls what happens when you click on a grouped task to
      offer three options:
      1. Show tooltips (new default setting)
      2. Show Present Windows effect
      3. Show textual list (AKA group dialog)
      
      The user is now free to choose in the settings window which visualization
      best suits them.
      
      This commit does not implement the most heavily-requested option--to
      bring forward all of the windows belonging to a grouped task
      (https://bugs.kde.org/show_bug.cgi?id=370258)--as it is still blocked by
      some technical isues related to stacking order and outstanding UX
      uncertainty regarding what should happen when one or more of the windows
      in a group happens to beminimized. However, since this commit introduces
      a config UI for choosing the desired behavior when activating a grouped
      task, there is now a place to put that option once it is implemented.
      
      BUG: 424268
      BUG: 390400
      CCBUG: 370258
      FIXED-IN: 5.20
      
      Depends on frameworks/plasma-framework!39
      ebaddb7d
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 65106759
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      65106759
    • Bhushan Shah's avatar
      doc: remove the desktopthemedetails and icons kcm · 821fc611
      Bhushan Shah authored
      They are now moved to plasma-workspace
      821fc611
  11. 22 Jul, 2020 2 commits
  12. 21 Jul, 2020 4 commits
    • Nate Graham's avatar
      Revert "Refine style of add widget sidebar" · 3d388480
      Nate Graham authored
      This reverts commit f17eae91.
      
      It was committed without adequate discussion and there were unresolved
      discussions. Furthermore, no code review was done, and as a result it
      shipped with visual regressions.
      
      We will re-discuss and commit a fixed version if appropriate.
      3d388480
    • Jan Blackquill's avatar
      Refine style of add widget sidebar · f17eae91
      Jan Blackquill authored
      f17eae91
    • Nicolas Fella's avatar
      [kcms/desktoppath] Use folder dialogs instead of file dialogs · 40499005
      Nicolas Fella authored
      Locations are folders. Set the appropriate hint in order to get folder dialogs.
      
      BUG: 424438
      FIXED-IN: 5.18.6
      40499005
    • Mikhail Zolotukhin's avatar
      [GTK Integration] Apply the same theme for GTK2 and GTK3 applications · d9d49d5c
      Mikhail Zolotukhin authored
      GTK configuration in Plasma depends on xsettings daemon, that has no
      separation between GTK2 and GTK3 theme, therefore separate themes for
      GTK2 and GTK3 are impossible, while this daemon is working. The daemon
      itself provides the functionality to apply settings to GTK applications
      without restarting them.
      
      The functionality to apply different themes to applications, depending on
      the framework version isn't necessary, when 99% of the themes are
      compatible with both versions and when most of the applications are
      using the last GTK version anyway.
      
      Given all that, I think, that a theme selection must be narrowed to one
      and only one theme for both versions of the GTK framework.
      
      CCBUG: 423141
      d9d49d5c
  13. 17 Jul, 2020 1 commit
  14. 16 Jul, 2020 2 commits
  15. 15 Jul, 2020 5 commits
  16. 13 Jul, 2020 2 commits