Marijo Mustac (bad7c916) at 15 Mar 16:52
@vkrause Could you please take a look if you have some time?
Changed description from "1. May" to be more descriptive "Tag der Arbeit" and added some missing days while checking all existing are still correct.
Marijo Mustac (9d0d907c) at 11 Mar 19:57
update german holidays
Marijo Mustac (11e69c95) at 11 Mar 18:39
Whats now little bit confusing is that the main switch is beneath the "add rule" button in the toolbar so you now have to got first down and up again bit I agree that this looks way better. Maybe offtopic but why is the firewall kcm the only one with an "about" page and displayed so prominant ?
I am not sure if the "view connection" or "view logs" make sense when the firewall is disabled but if not what about a toolbar like this:
firewall off: toogle
firewall on: view logs | view connection | add rule | toogle
Marijo Mustac (6fb9fef4) at 09 Feb 19:18
fix: overlap between content and sidebar
I like the idea of the monitor name. However, I would also keep the connector information because I use three same monitors so the name alone wouldn't be useful at all. Wouldn't it be cool if we could also somehow show the currently used wallpaper inside the preview, in case users have set different wallpapers? It could further help to distinguish them.
What about hiding the display selection when the new switch is active, as those are not needed in this case, right?
Any chance we can get the type of operation move/copy maybe in the title of the window? I found myself often copying files from my local PC to my server and sometimes I am not sure if I choose move or copy action correctly. It would be just some small hint for poeple like me.
But the spec does define a battery-full => The sound used when the battery is fully loaded up. so maybe rename the sounds in the theme instead?
Google Chrome/Chromium for example behaves the exact same way. The last closed window saves its opened tabs which are then restored when started again. Kate has also this kind of feature but it's based on sessions I think not sure how it is solved there.
I am no developer but what I can see is, that many of the changes you did in this MR do not belong to the feature you are trying to implement. Many of those are related to changing texts or cleaning up some code (batterymonitor and clipboard applet or klipper to name a few) which is good in general for sure but should go maybe into a different MR which then could be reviewed and merged easily and the review of this huge MR could concentrate on the changes which really matter.
But the feature itself sounds really great.