1. 28 Dec, 2018 2 commits
  2. 26 Dec, 2018 2 commits
  3. 24 Dec, 2018 1 commit
  4. 21 Dec, 2018 1 commit
  5. 20 Dec, 2018 2 commits
  6. 19 Dec, 2018 2 commits
  7. 16 Dec, 2018 1 commit
  8. 15 Dec, 2018 1 commit
  9. 12 Dec, 2018 2 commits
  10. 10 Dec, 2018 5 commits
  11. 09 Dec, 2018 4 commits
  12. 08 Dec, 2018 5 commits
    • Christoph Cullmann's avatar
      Review user interaction in session management · e078ee32
      Christoph Cullmann authored
      Summary:
      * SessionManageDialog
          - Build user interface by ui file
          - Avoid obsolete Qt members
          - Choose more meaningful member names
          - Add filter field and sort button
          - Open session by double click
          - Add buttons for "Copy" and "Open as Template"
          - Reorder a couple of code to be a little bit more logic ordered
          - Delete a session with delay which offer a restore and avoid annoying
            confirmation dialog
          - Rename a session inside of the list view to avoid extra popup
            window to enter the new name.
      
      * Remove SessionOpenDialog, use SessionManageDialog instead
      * Remove SessionChooser, use SessionManageDialog instead
      
      * SessionManager
          - Add signal sessionListChanged()
            To avoid unneded signals is updateSessionList() slightly modified
            with a clearer look and an added check for changes in an easy way.
          - Add copySession()
          - Let rename/copySession() ask for a new name when needed
          - Move session creation parts from newSessionName() to sessionSaveAs()
          - Rename newSessionName() to askForNewSessionName()
          - Add suggestNewSessionName()
          - Don't create anonymous session in ctor
          - Don't save anonymous session as last session
      
      * MainWindow
          - Remove from sessions menu "Open Session" because it's now the
            same as "Manage Sessions"
      
      Test Plan:
      {F6443763}
      {F6443766}
      
      Reviewers: #kate, dhaumann, ngraham, #vdg, cullmann
      
      Reviewed By: #kate, dhaumann, cullmann
      
      Subscribers: fabianr, anthonyfieroni, cullmann, kwrite-devel, #kate
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D16926
      e078ee32
    • loh tar's avatar
      ViewManager: Fix I18n_ARGUMENT_MISSING hint in message box when open a very large file · b1b09ed9
      loh tar authored
      Test Plan:
      Before
      {F6463917}
      After
      {F6463918}
      
      Reviewers: #kate, #vdg, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: cullmann, pino, kwrite-devel, #kate
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D17428
      b1b09ed9
    • Gregor Mi's avatar
      Analysis tools: Use const where possible · 7a2b2268
      Gregor Mi authored
      Reviewers: #kate, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: cullmann, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D17435
      7a2b2268
    • Gregor Mi's avatar
      Projects Plugin: Add ShellCheck analyzer · 407928e4
      Gregor Mi authored
      Summary:
      Plus:
      - Add target programming language after the name of each analyzer.
      - Add number of processed files
      - Disable Start button as long as analysis is running
      
      Screenshot of selection box:
      
      {F6451235}
      
      Screenshot of a finished run:
      
      {F6464116}
      
      Tool description:
      
      {F6464138}
      
      Reviewers: #kate, dhaumann
      
      Reviewed By: #kate, dhaumann
      
      Subscribers: ngraham, dhaumann, kfunk, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D17314
      407928e4
    • Gregor Mi's avatar
      Code Analysis: Show list of file extensions on which the tool runs on · dcbed2c3
      Gregor Mi authored
      Summary:
      Reason: a long time I wondered how exactly this Code Analysis works and wasn't even aware of that for "cppcheck" .h files are _not_ scanned.
      
      Plus:
      - Rearrange to GUI to make the label better fit (at least for my eye): move selector and start
      button from the lower right to the upper left.
      
      Before:
      
      {F6451333}
      
      After:
      
      {F6463943}
      
      Ideas for later:
      - Make it possible to run a tool for individual files
      - Another analyser which derives from the cppcheck class could be created: it specifically sets the language to C++ (in the original class the caption should be renamed to "cppcheck (C/C++) and also includes .h and .hpp files
      - Show the number of files the analyser was run on
      
      Reviewers: #kate, cullmann
      
      Reviewed By: #kate, cullmann
      
      Subscribers: cullmann, dhaumann, ngraham, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D17318
      dcbed2c3
  13. 06 Dec, 2018 3 commits
  14. 05 Dec, 2018 1 commit
    • loh tar's avatar
      BuildView: Fix broken load of project plugin targets · 6686e5f6
      loh tar authored
      Summary: Most changes are only a little code cosmetic, like unwrap lines or remove spaces
      
      Test Plan:
      Here it was reproducible e.g. by changing between my sessions "kate" and "sonnet". I think you can guess what they are.
      
      1. Start Kate with session "kate" -> Project Targets shown
      2. Switch to "sonnet" -> No Project Targets shown. I think there are no (however) defined (any illuminating tip is appreciated)
      3. Switch back to "kate" -> Also NO Project Targets shown, but should!
      
      With this patch are at 3. the Project Targets back again
      
      Reviewers: #kate, sars
      
      Reviewed By: #kate, sars
      
      Subscribers: sars, kwrite-devel, #kate
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D17339
      6686e5f6
  15. 03 Dec, 2018 5 commits
    • Gregor Mi's avatar
      Add file related actions to Tabbar context menu and File menu: Rename, Delete,... · e8496c60
      Gregor Mi authored
      Add file related actions to Tabbar context menu and File menu: Rename, Delete, Compare (new), and some more
      
      Summary:
      Add some actions to Tabbar context menu and File menu
      
      New items in Tabbar context menu:
      - 'Rename file'
      - 'Delete file'
      - 'Properties'
      - 'Compare'
      
      'Compare' does the following: compare two files with an external diff tool. It works like this: right click on a tab which is NOT active and select the appropriate menu item (see screenshot). Then, the external tool opens and compares the active document with the one which was clicked on. Currently, three diff tools are supported: kdiff3, kompare and meld.
      
      New items in File main menu:
      - 'Rename file'
      - 'Delete file'
      - 'Compare'
      - 'Copy File Path'
      - 'Open Containing Folder'
      - 'Properties'
      
      Screenshots:
      
      Tab context menu:
      
      {F6414794}
      
      Tab context menu when no file is associated:
      
      {F6414793}
      
      Tab context menu with the compare feature:
      
      {F6431032}
      
      Diff tools not found:
      
      {F6450993}
      
      Actions are also available in the main File menu:
      
      {F6450928}
      
      NOTE: Some code of kfileactions.cpp was copied and adapted from katefiletree.cpp. TODO: reuse code there. Probably, this means kfileactions.h must be moved to KTextEditor.
      
      TODO: in a later change the 'Open with...' menu item which is currently available in the Projects and FileTree plugin could also be extracted and be added to the Tabbar context menu and File menu (Gwenview has it, too).
      
      Reviewers: #kate, #vdg, ngraham, cullmann
      
      Reviewed By: #kate, #vdg, ngraham, cullmann
      
      Subscribers: cullmann, anthonyfieroni, dhaumann, mmustac, ngraham, kwrite-devel
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D16830
      e8496c60
    • loh tar's avatar
      SearchView: Fix missing signal/slot connection to project plugin · 53dd31b4
      loh tar authored
      Summary:
      ...to notice project change after session switch
      
      Without this patch was the project offer in the m_ui.searchPlaceCombo
      after a session switch gone
      
      Reviewers: #kate, sars
      
      Reviewed By: #kate, sars
      
      Subscribers: sars, kwrite-devel, #kate
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D17296
      
      BUG:347311
      53dd31b4
    • loh tar's avatar
      BuildView: Improve user information when build fails · 2667d1b4
      loh tar authored
      Summary:
      ...due to wrong set build path
      
      Reviewers: #kate, #vdg, sars
      
      Reviewed By: #kate, sars
      
      Subscribers: ngraham, sars, kwrite-devel, #kate
      
      Tags: #kate
      
      Differential Revision: https://phabricator.kde.org/D17297
      2667d1b4
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · c3b2ab00
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      c3b2ab00
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · f2454831
      Script Kiddy authored
      f2454831
  16. 02 Dec, 2018 1 commit
  17. 29 Nov, 2018 2 commits