Commit 0292de05 authored by Matěj Laitl's avatar Matěj Laitl
Browse files

Extend fix of bug 285951 to the other crash site

This should definitely fix the Amarok crashes during exit bug.

BUG: 285951
FIXED-IN: 2.6
DIGEST: fix crash bug
parent c31d00f0
......@@ -134,11 +134,11 @@ CollectionManager::~CollectionManager()
d->collections.clear();
d->unmanagedCollections.clear();
d->trackProviders.clear();
qDeleteAll( d->managedCollections );
// qDeleteAll seems to be partly broken in Qt 4.8, FIX: 285951
// qDeleteAll( d->factories );
while (!d->factories.isEmpty())
// Hmm, qDeleteAll from Qt 4.8 crashes with our SmartPointerList, do it manually. Bug 285951
while( !d->managedCollections.isEmpty() )
delete d->managedCollections.takeFirst();
while (!d->factories.isEmpty() )
delete d->factories.takeFirst();
delete d;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment