Commit e17bd07d authored by Matěj Laitl's avatar Matěj Laitl
Browse files

Use proper color in "Dynamic Playlist" notification strip

...it was not using style's link colour, from QPalette documentation:
> Note that we do not use the Link and LinkVisited roles when rendering
> rich text in Qt, and that we recommend that you use CSS

I didn't know this.

This should fix low-contrast problem with Obsidian Coast color scheme
and the like. It is still not optimal, but that would require
rethinking PaletteHandler::highlightColor().

BUG: 301303
FIXED-IN: 2.6
parent 2185fa12
......@@ -8,6 +8,7 @@ VERSION 2.6
argument.
BUGFIXES:
* Use colors from KDE style in Dynamic Playlist strip. (BR 301303)
* Finally fix crash on startup in addCollapseAnimation. (BR 258741)
* Don't hit "too many open files" when copying covers to iPod. (BR 301207)
* Don't crash if iPod's eject button is hit twice. (BR 301208)
......
......@@ -247,9 +247,11 @@ void
Playlist::Dock::paletteChanged( const QPalette &palette )
{
m_dynamicHintWidget->setStyleSheet(
QString( "QLabel { background-color: %1; color: %2; ; border-radius: 3px; } " )
QString( "QLabel { background-color: %1; color: %2; border-radius: 3px; } "
"a { color: %3; } " )
.arg( PaletteHandler::highlightColor().name() )
.arg( palette.highlightedText().color().name() )
.arg( palette.color( QPalette::HighlightedText ).name() )
.arg( palette.color( QPalette::Link ).name() )
);
if( m_barBox )
m_barBox->setStyleSheet(
......@@ -257,7 +259,7 @@ Playlist::Dock::paletteChanged( const QPalette &palette )
"background-color: %2; color: %3; border-radius: 3px; }"
"QLabel { color: %3; }" )
.arg( palette.color( QPalette::Window ).name() )
.arg( The::paletteHandler()->highlightColor().name() )
.arg( PaletteHandler::highlightColor().name() )
.arg( palette.color( QPalette::HighlightedText ).name() )
);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment