Commit a8ae266b authored by Nate Graham's avatar Nate Graham
Browse files

DataGridView/DataListView: don't put Binding objects in loaders

Binding already has a when: property that's used for this, and it's much
lighter weight than putting the whole thing in a loader.
parent 180247c3
Pipeline #159420 passed with stage
in 3 minutes and 32 seconds
......@@ -176,37 +176,25 @@ FocusScope {
Layout.fillWidth: true
Loader {
active: gridView.contentModel
sourceComponent: Binding {
target: gridView.contentModel
property: 'filterText'
when: gridView.contentModel
value: navigationBar.filterText
}
Binding {
target: gridView.contentModel
property: 'filterText'
when: gridView.contentModel
value: navigationBar.filterText
}
Loader {
active: gridView.contentModel
sourceComponent: Binding {
target: gridView.contentModel
property: 'filterRating'
when: gridView.contentModel
value: navigationBar.filterRating
}
Binding {
target: gridView.contentModel
property: 'filterRating'
when: gridView.contentModel
value: navigationBar.filterRating
}
Loader {
active: gridView.contentModel && navigationBar.enableSorting
sourceComponent: Binding {
target: gridView.contentModel
property: 'sortRole'
when: gridView.contentModel && navigationBar.enableSorting
value: navigationBar.sortRole
}
Binding {
target: gridView.contentModel
property: 'sortRole'
when: gridView.contentModel && navigationBar.enableSorting
value: navigationBar.sortRole
}
onEnqueue: contentModel.enqueueToPlayList(delegateModel.rootIndex)
......
......@@ -219,37 +219,25 @@ FocusScope {
Layout.fillWidth: true
Loader {
active: listView.contentModel
sourceComponent: Binding {
target: listView.contentModel
property: 'filterText'
when: listView.contentModel
value: navigationBar.filterText
}
Binding {
target: listView.contentModel
property: 'filterText'
when: listView.contentModel
value: navigationBar.filterText
}
Loader {
active: listView.contentModel
sourceComponent: Binding {
target: listView.contentModel
property: 'filterRating'
when: listView.contentModel
value: navigationBar.filterRating
}
Binding {
target: listView.contentModel
property: 'filterRating'
when: listView.contentModel
value: navigationBar.filterRating
}
Loader {
active: listView.contentModel && navigationBar.enableSorting
sourceComponent: Binding {
target: listView.contentModel
property: 'sortRole'
when: listView.contentModel && navigationBar.enableSorting
value: navigationBar.sortRole
}
Binding {
target: listView.contentModel
property: 'sortRole'
when: listView.contentModel && navigationBar.enableSorting
value: navigationBar.sortRole
}
onEnqueue: contentModel.enqueueToPlayList(delegateModel.rootIndex)
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment