Commit bc9b05ca authored by David Koermendi's avatar David Koermendi Committed by Matthieu Gallien

Reduce the size of busy indicators

Summary:
As reported in 406940, the busy indicators that show up when data is being loaded are a bit too big at the moment. These changes reduce their size by anchoring them at the center instead of having them fill the available space (see example screenshots below for comparison).

BUG: 406940

Track view before change:
{F6798571}

Track view after change:
{F6798572}

Grid view before change:
{F6798574}

Grid view after change:
{F6798575}

Test Plan: This is just a minor UI tweak. No behavioural changes.

Reviewers: #elisa, mgallien, #vdg, ngraham

Reviewed By: #elisa, mgallien, #vdg, ngraham

Subscribers: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D20880
parent ae0be389
......@@ -17,6 +17,7 @@
import QtQuick 2.10
import QtQuick.Controls 2.3
import org.kde.kirigami 2.5 as Kirigami
import org.kde.elisa 1.0
FocusScope {
......@@ -97,13 +98,15 @@ FocusScope {
onGoBack: viewManager.goBack()
Loader {
anchors.fill: parent
anchors.centerIn: parent
height: Kirigami.Units.gridUnit * 5
width: height
visible: realModel.isBusy
active: realModel.isBusy
sourceComponent: BusyIndicator {
anchors.fill: parent
anchors.centerIn: parent
}
}
}
......
......@@ -17,6 +17,7 @@
import QtQuick 2.10
import QtQuick.Controls 2.3
import org.kde.kirigami 2.5 as Kirigami
import org.kde.elisa 1.0
FocusScope {
......@@ -71,13 +72,15 @@ FocusScope {
onGoBack: viewManager.goBack()
Loader {
anchors.fill: parent
anchors.centerIn: parent
height: Kirigami.Units.gridUnit * 5
width: height
visible: realModel.isBusy
active: realModel.isBusy
sourceComponent: BusyIndicator {
anchors.fill: parent
anchors.centerIn: parent
}
}
}
......
......@@ -17,6 +17,7 @@
import QtQuick 2.10
import QtQuick.Controls 2.3
import org.kde.kirigami 2.5 as Kirigami
import org.kde.elisa 1.0
FocusScope {
......@@ -85,13 +86,15 @@ FocusScope {
}
Loader {
anchors.fill: parent
anchors.centerIn: parent
height: Kirigami.Units.gridUnit * 5
width: height
visible: realModel.isBusy
active: realModel.isBusy
sourceComponent: BusyIndicator {
anchors.fill: parent
anchors.centerIn: parent
}
}
}
......
......@@ -21,6 +21,7 @@ import QtQuick.Window 2.2
import QtQml.Models 2.1
import QtQuick.Layouts 1.2
import QtGraphicalEffects 1.0
import org.kde.kirigami 2.5 as Kirigami
FocusScope {
id: gridEntry
......@@ -200,10 +201,13 @@ FocusScope {
Loader {
active: isPartial
anchors.fill: parent
anchors.centerIn: parent
height: Kirigami.Units.gridUnit * 5
width: height
sourceComponent: BusyIndicator {
anchors.fill: parent
anchors.centerIn: parent
running: true
}
......
......@@ -17,6 +17,7 @@
import QtQuick 2.10
import QtQuick.Controls 2.3
import org.kde.kirigami 2.5 as Kirigami
import org.kde.elisa 1.0
FocusScope {
......@@ -85,13 +86,15 @@ FocusScope {
}
Loader {
anchors.fill: parent
anchors.centerIn: parent
height: Kirigami.Units.gridUnit * 5
width: height
visible: realModel.isBusy
active: realModel.isBusy
sourceComponent: BusyIndicator {
anchors.fill: parent
anchors.centerIn: parent
}
}
}
......
......@@ -17,6 +17,7 @@
import QtQuick 2.10
import QtQuick.Controls 2.3
import org.kde.kirigami 2.5 as Kirigami
import org.kde.elisa 1.0
FocusScope {
......@@ -85,13 +86,15 @@ FocusScope {
}
Loader {
anchors.fill: parent
anchors.centerIn: parent
height: Kirigami.Units.gridUnit * 5
width: height
visible: realModel.isBusy
active: realModel.isBusy
sourceComponent: BusyIndicator {
anchors.fill: parent
anchors.centerIn: parent
}
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment