Commit c1e93a8b authored by Dmitry Kolesnikov's avatar Dmitry Kolesnikov Committed by Nate Graham
Browse files

Remove unnecessary code for opacity

Previously, if you changed the focus from an object evaluated in 0-5
mode, the stars disappeared. This was due to the fact that the object
became transparent if its rating <2.

Most likely, this was once done in order to produce alignment.
However, this broke the evaluation system.

This is no longer required, as the interaction with this widget has
changed in previous commits. Therefore, this parameter has been
removed.
parent 46da3cf7
Pipeline #229189 passed with stage
in 7 minutes and 32 seconds
......@@ -470,10 +470,6 @@ FocusScope {
State {
name: 'notSelected'
when: !mediaTrack.activeFocus && !hoverArea.containsMouse && !mediaTrack.isSelected
PropertyChanges {
target: ratingWidget
hoverWidgetOpacity: 0.0
}
PropertyChanges {
target: rowRoot
color: (isAlternateColor ? myPalette.alternateBase : myPalette.base)
......@@ -486,10 +482,6 @@ FocusScope {
State {
name: 'hovered'
when: !mediaTrack.activeFocus && hoverArea.containsMouse
PropertyChanges {
target: ratingWidget
hoverWidgetOpacity: 1.0
}
PropertyChanges {
target: rowRoot
color: myPalette.highlight
......@@ -502,10 +494,6 @@ FocusScope {
State {
name: 'selected'
when: !mediaTrack.activeFocus && mediaTrack.isSelected
PropertyChanges {
target: ratingWidget
hoverWidgetOpacity: 1.0
}
PropertyChanges {
target: rowRoot
color: myPalette.mid
......@@ -518,10 +506,6 @@ FocusScope {
State {
name: 'focused'
when: mediaTrack.activeFocus
PropertyChanges {
target: ratingWidget
hoverWidgetOpacity: 1.0
}
PropertyChanges {
target: rowRoot
color: myPalette.highlight
......
......@@ -113,8 +113,6 @@ RowLayout {
readOnly: false
hoverWidgetOpacity: 1
anchors.verticalCenter: parent.verticalCenter
height: Kirigami.Units.gridUnit
......
......@@ -405,7 +405,6 @@ Item {
objectName: 'ratingFilter'
visible: showRating && !ElisaApplication.useFavoriteStyleRatings
hoverWidgetOpacity: 1
readOnly: false
},
......
......@@ -424,41 +424,17 @@ BasePlayListDelegate {
name: "dragging"
when: playListEntry.listView.dragging
},
State {
name: 'notSelected'
when: !containsMouse && !isSelected && !playListEntry.hasActiveFocus && !simpleMode
PropertyChanges {
target: ratingWidget
hoverWidgetOpacity: 0.0
}
},
State {
name: 'hovered'
when: containsMouse && !playListEntry.hasActiveFocus && !simpleMode
PropertyChanges {
target: ratingWidget
hoverWidgetOpacity: 1.0
}
PropertyChanges {
target: buttonRowLoader
active: playListEntry.wideMode
}
},
State {
name: 'selected'
when: !playListEntry.hasActiveFocus && isSelected && !simpleMode
PropertyChanges {
target: ratingWidget
hoverWidgetOpacity: 1.0
}
},
State {
name: 'focused'
when: playListEntry.hasActiveFocus && !simpleMode
PropertyChanges {
target: ratingWidget
hoverWidgetOpacity: 1.0
}
PropertyChanges {
target: buttonRowLoader
active: playListEntry.wideMode
......
......@@ -15,14 +15,12 @@ Row {
property double hoverBrightness: 0.5
property double hoverContrast: 0.5
property double hoverWidgetOpacity: 0
property int hoveredRating: 0
signal ratingEdited()
spacing: 0
opacity: starRating >= 2 ? 1 : hoverWidgetOpacity
Repeater {
model: 5
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment