1. 11 Mar, 2020 1 commit
  2. 20 Jul, 2019 1 commit
  3. 19 Jun, 2019 1 commit
  4. 12 Jun, 2019 4 commits
    • Nate Graham's avatar
      Fix merge collision issue · 86e40e7e
      Nate Graham authored
      86e40e7e
    • Matthieu Gallien's avatar
      improve accessibility by providing metadata for UI elements · ee49bfc0
      Matthieu Gallien authored
      Summary: Add metadata while preserving the string freeze to help a screen reader when navigating with keyboard
      
      Test Plan: Tested under plasma with orca
      
      Reviewers: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Reviewed By: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Subscribers: lavender, davidedmundson, ngraham
      
      Differential Revision: https://phabricator.kde.org/D21608
      ee49bfc0
    • Nate Graham's avatar
      [RFC] Implement KDE-style header toolbars and statusbars for Playlist and Context view · 00b32e06
      Nate Graham authored
      Summary:
      This patch is basically a design proposal in patch form.
      
      Right now, each view's header is not visually separated at all from the content
      view below it, and all header areas have different visual styles, some of then
      being very tall and taking up a lot of space that could be used for more content.
      The context view's flickable is adjusted to take advantage of this, resulting in
      a greatly increased amount of vertical space when the lyrics portion is long.
      
      This patch/design proposal implements a new style of header and statusbar
      that looks more "KDE-style", for lack of a batter term. It mimics what toolbars
      in Kirigami and other QML apps look like. Advantages include:
      - Improved visual consistency with modern KDE apps
      - Visually pleasing separation from content area
      - Scrollable content doesn't appear to get "cut off" under an invisible item anymore
      - More compact headers leave more room for content
      - Code simplification from using a re-usable component rather than multiple custom views
      
      Test Plan:
      Playlist, before: {F6878549}
      Playlist, after: {F6878548}
      
      Playlist + context view, before: {F6878551}
      Playlist + context view, after: {F6878550}
      
      This patch implements the new header style for only the Playlist and Context View.
      If the proposal is approved and the patch lands, I can do the main view too, which
      is more complicated to port and will require changes to the autotests as well.
      
      Reviewers: mgallien, #elisa, #vdg
      
      Reviewed By: mgallien, #elisa
      
      Differential Revision: https://phabricator.kde.org/D21676
      00b32e06
    • Matthieu Gallien's avatar
      improve accessibility by providing metadata for UI elements · 4c71234d
      Matthieu Gallien authored
      Summary: Add metadata while preserving the string freeze to help a screen reader when navigating with keyboard
      
      Test Plan: Tested under plasma with orca
      
      Reviewers: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Reviewed By: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Subscribers: lavender, davidedmundson, ngraham
      
      Differential Revision: https://phabricator.kde.org/D21608
      4c71234d
  5. 06 Jun, 2019 2 commits
    • Nate Graham's avatar
      Make Playlist items span full width · fe7d7043
      Nate Graham authored
      Summary:
      Currently playlist items do not span the full width; there is a bunch of
      complicated logic to determine the margins and playlist's width. This
      makes the display look unbalanced and causes a subtle visual bug
      (see BUG: below).
      
      This patch resolves both issues by making playlist items visually stick to
      both edges of the playlist, just like the category selector list items do.
      
      This patch also does a bit of necessary code cleanup for the playlist states.
      I tested this out quite a bit but to make sure there were no regressions but
      it's possible that I missed something so more testing may be needed.
      
      BUG: 408210
      
      Test Plan:
      Before: {F6871989}
      
      After: {F6871988}
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Subscribers: januz
      
      Differential Revision: https://phabricator.kde.org/D21582
      fe7d7043
    • Nate Graham's avatar
      Make Playlist items span full width · 50bbbfa3
      Nate Graham authored
      Summary:
      Currently playlist items do not span the full width; there is a bunch of
      complicated logic to determine the margins and playlist's width. This
      makes the display look unbalanced and causes a subtle visual bug
      (see BUG: below).
      
      This patch resolves both issues by making playlist items visually stick to
      both edges of the playlist, just like the category selector list items do.
      
      This patch also does a bit of necessary code cleanup for the playlist states.
      I tested this out quite a bit but to make sure there were no regressions but
      it's possible that I missed something so more testing may be needed.
      
      BUG: 408210
      
      Test Plan:
      Before: {F6871989}
      
      After: {F6871988}
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Subscribers: januz
      
      Differential Revision: https://phabricator.kde.org/D21582
      50bbbfa3
  6. 14 May, 2019 1 commit
  7. 26 Apr, 2019 1 commit
  8. 12 Apr, 2019 1 commit
    • Jerome Guidon's avatar
      Allow to undo the clear actions on the playlist · c8a43561
      Jerome Guidon authored and Matthieu Gallien's avatar Matthieu Gallien committed
      Summary:
      When a clear action is performed on the playlist, the user might lose valuable work.
      Add the possibility to undo this operation via passive notification.
      Keep it simple by allowing only one undo and no redo.
      
       - The patch now enables to restore the playlist and the player status.
      For the notification, I use KNotification here, you can see in the screenshot the notification with an Undo button.
      
       - KNotification needs the file elisa.notifyrc to be installed in QStandardPaths::GenericDataLocation directory, so it may impact the packaging of the app (https://api.kde.org/frameworks/knotifications/html/classKNotification.html#file).
      
      Reviewers: mgallien
      
      Reviewed By: mgallien
      
      Subscribers: ngraham
      
      Tags: #elisa
      
      Maniphest Tasks: T5376
      
      Differential Revision: https://phabricator.kde.org/D19610
      c8a43561
  9. 15 Jan, 2019 1 commit
    • Ashwin  Dhakaita's avatar
      Global shortcut for play/pause action using spacebar key · 5847d0e0
      Ashwin Dhakaita authored and Matthieu Gallien's avatar Matthieu Gallien committed
      Summary:
      Assign SpaceBar key as the global shortcut for play/pause action.  Most of the media player out there already use spacebar as the global shortcut for play/pause action.  So,  it would be good to do the same for Elisa.
      Modified ElisaMainWindow.qml to add the shortcut component.
      Modified MediaPlayerControl.qml to prevent elements from getting focus as it causes interference with the shortcut keypressed events.
      
      BUG:    392989
      FIXED-IN:    elisa  0.3.80
      
      Reviewers: #elisa, ngraham, mgallien
      
      Reviewed By: #elisa, ngraham, mgallien
      
      Subscribers: shubham, mgallien, ngraham
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D17994
      5847d0e0
  10. 30 Dec, 2018 1 commit
  11. 20 Dec, 2018 1 commit
  12. 12 Dec, 2018 1 commit
  13. 17 Nov, 2018 1 commit
  14. 15 Oct, 2018 1 commit
  15. 10 Oct, 2018 1 commit
  16. 28 Sep, 2018 1 commit
  17. 13 Sep, 2018 1 commit
  18. 15 Jul, 2018 1 commit
    • Diego Gangl's avatar
      New header style for playlist · f3f15b0f
      Diego Gangl authored
      Summary:
      This patch moves the buttons in the playlist to the top and groups them. I also changed the clear playlist icon to the trash icon (I think it conveys the meaning better), and also tweaked the buttons text for more consistency.
      
      {F6063304}
      
      Reviewers: #elisa, mgallien, astippich
      
      Reviewed By: #elisa, astippich
      
      Subscribers: mgallien, astippich, ngraham
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D14015
      f3f15b0f
  19. 13 Jul, 2018 1 commit
  20. 02 Jul, 2018 1 commit
  21. 01 Jul, 2018 1 commit
  22. 13 May, 2018 1 commit
    • Diego Gangl's avatar
      Design tweaks for the PlayerBar · 314be22f
      Diego Gangl authored
      Summary:
      Design changes for the elisa player bar according to the mockups in the ML
      
      ## Included in this patch
      
      - Move menu button to the bar
      - Make volume slider a bit smaller
      - Move repeat and shuffle to the bar
      - Fix the seek's handle so it doesn't show the radius of the elapsed rect
      - Make player bar slightly thinner
      - Make background of the seek/volume sliders darker so they are more visible
      - Make volume button closer to slider
      - Tweak length of seek bar and spacing between elements to make the design feel more balanced
      - Align "remaining tracks" text and imported notification with the hamburger menu
      
      {F5835836}
      
      ## Notes
      
      - I haven't tested this with a RTL layout. I follow the LayoutMirroring pattern so it should be mostly ok (plz test!)
      - I'm pretty sure I broke something when I moved the shuffle and repeat buttons to the bar because their state isn't being saved when I restart Elisa, but I can't figure out what it is.
      - Do we have another choice of next/prev track icons? The vertical bars on these are super huge and make them feel way too heavy. Specially compared to the shuffle/repeat icons
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Subscribers: ngraham, mgallien, astippich
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D12714
      314be22f
  23. 06 May, 2018 1 commit
  24. 16 Apr, 2018 2 commits
  25. 27 Mar, 2018 1 commit
  26. 10 Mar, 2018 1 commit
  27. 03 Mar, 2018 3 commits
  28. 02 Mar, 2018 1 commit
  29. 25 Feb, 2018 1 commit
  30. 18 Feb, 2018 1 commit
    • Alexander Stippich's avatar
      move MediaPlaylist to C++ · 4d6d8321
      Alexander Stippich authored
      Summary:
      first step of optimization after the introduction of the dedicated proxy model.
      already cleans up a lot of the interface and makes the Qml code easier. Performance does not seem to change much.
      no functional change intended. all tests pass
      
      Reviewers: #elisa, mgallien
      
      Reviewed By: #elisa, mgallien
      
      Subscribers: mgallien
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D10271
      4d6d8321
  31. 04 Feb, 2018 1 commit
  32. 03 Feb, 2018 1 commit
    • Alexander Stippich's avatar
      Implement a filter view and play buttons for all views · 75ceb39a
      Alexander Stippich authored
      Summary:
      Unifies the navigation on top of the views across all views. Filter bar and buttons are enabled in all 5 views we currently have.
      Fixes  T7536, T6294 and T7624. Performance still needs improvement.
      
      Reviewers: #elisa, mgallien
      
      Reviewed By: #elisa, mgallien
      
      Subscribers: davidc, januz, mgallien
      
      Tags: #elisa, #vdg
      
      Maniphest Tasks: T7624, T7536, T6294
      
      Differential Revision: https://phabricator.kde.org/D10088
      75ceb39a
  33. 22 Jan, 2018 1 commit