Yerrey Dev authored Jul 01, 2022 and Nate Graham committed Jul 01, 2022

There was an issue where in the backend the entries are sorted
case insensitively, but when sorting the entries in viewsproxymodel 
it was done case sensitive. This caused that albums and other
entries in the sidebar that started with a lower capital letter would be pushed
to the bottom of the list. This discrepancy made it so you could
click an album on the sidebar and the actual album that opened
would be completely different that you clicked.



Before:

![casesensitivity-before-2022-06-30_14.09.06](/uploads/68f5eb71b224b614b1163b7097a175de/casesensitivity-before-2022-06-30_14.09.06.mp4)

After:

![casesensitivity-after-2022-06-30_14.08.04](/uploads/c7c818d9ce63737d19c802312bd87218/casesensitivity-after-2022-06-30_14.08.04.mp4)


(cherry picked from commit 301c7462)

Bart De Vries authored Jun 21, 2022 and Nate Graham committed Jun 22, 2022

The original implementation used the raw duration and position as
reported by qmultimedia, which are in milliseconds. This, combined with
the actual Slider implementation in qqc2-desktop-style caused
value/duration to overflow at about 3 minutes and 30 seconds.
The adapted implementation uses seconds for the internal Slider values.

CCBUG: 455339


(cherry picked from commit 98227f05)

Make them open on pressed rather than clicked, and highlight when
pressed. This makes them behave more consistently.

BUG: 453399
FIXED-IN: 22.04.1

Firlaev-Hans Fiete authored Apr 26, 2022 and Nate Graham committed Apr 26, 2022

Before, the two entries "Open Playlist…" and "Save Playlist…" in the "File" menu
were bound to the same action as "Refresh Music Collection" which is obviously
not wanted.

We had forgotten to emit change signals for some config settings.

BUG: 436424
FIXED-IN: 22.04.1

Jack Hill authored Apr 04, 2022 and Nate Graham committed Apr 04, 2022

Moved the MouseArea to inside the slider. Previously the Slider was
overriding the MouseArea and wheel events were not working correctly.

BUG: 450984
FIXED-IN: 22.04

Format bit rate as "kbps" with no decimal places
Format sample rate as "kHz" with one decimal place

BUG: 447897

This accidentally got lost in 8a4f3930.

This way it gets listed on apps.kde.org

Olivier Trichet authored Mar 04, 2022 and Nate Graham committed Mar 08, 2022

This change wraps calls to QAction::shortcut() done in QML files
to use the portable representation of QKeySequence.

The QKeySequence to QVariant operator return a string
representation using the native format not the portable format.
E.g., the sequence "Space", will be "Espace" under French locale.
The 'shortcut' attribute of QtQuick Action is stored as QVariant.
In qml file, when the QAction::shortcut() value (a QKeySequence)
is affected to a QtQuick Action shortcut, the previous operator is
used and the shortcut value may be bogus depending on translation.

    // A QAction* with the Qt::Key_Space shortcut
    property var playPauseAction: ElisaApplication.action("Play-Pause")
    Action {
        // - playPauseAction.shortcut returns QKeySequence(Qt::Key_Space).
        // - QKeySequence(Qt::Key_Space) is transform into a QVariant that
        //        contains native text "Espace".
        // - this QVariant is affected to shortcut: broken.
        shortcut: playPauseAction.shortcut
        onTriggered: ElisaApplication.audioControl.playPause()
    }

BUG: 424890
BUG: 410110

Since we have two simple conditions that differ only by the value of one
property, we can avoid explicit States to make the code shorter and
less indirect.

Co-authored-by: Jack Hill <jackhill3103@gmail.com>

BUG: 448066
FIXED-IN: 22.04

No need to use explicit States for a simple two-position transition that
only involves a single property change. We can do it much more clearly
and readably without them.

Now we use the upstream size from Kirigami which automatically makes
them a bit shorter by default, but they automatically adjust to become
taller when in Tablet Mode.

This lets it adjust with the font size.

These are already set by the base items, so there is no need to set them
again here.

At this point it's a single simple library component item that's only
used on no place. There's no benefit to having it in a separate file.

Tranter Madi authored Mar 08, 2022 and Nate Graham committed Mar 08, 2022

- Avoid the label overlapping the hovering buttons when the width of
the playlist is small enough and the user clicks the play button
- Collapse button row into a menu when playlist is very narrow
- Use better icon for "remove"
- Remove some unneeded code

CCBUG: 434437
FIXED-IN: 22.04