GitLab

This commit is the culmination of !205

Notable Changes:
- Added mobile folder with components needed for mobile (and are separator from desktop components)
- Changed tst_NavigationActionBar test so that it does not check for artist button when it is invisible (loaders are used now so the button wouldn't be detected)
- Added loaders in ContentView.qml to switch between the mobile and desktop sidebars
- Changed ContextView.qml to use FormLayout, and also add mobile navigation buttons
- Collapsed the two list delegates (detailed and non detailed) together, along with edits for mobile usage
- Lowered the size of text in list delegates
- Extracted out the settings form to be shared between mobile and desktop
- Edited the grid delegate to be mobile friendly
- Removed clip from both listviews and gridviews for performance
- Extracted out the volume slider and duration slider to be shared for mobile and desktop
- Add mobile and desktop component switching for MediaPlayListView.qml
- Port the metadata view into Kirigami FormLayout so that it can be shared between mobile and desktop
- Rework NavigationActionBar buttons to all be components loaded in by loaders, so that we can have different layouts for mobile and desktop
- Extract shared properties for playlist delegates between mobile and desktop into BasePlayListDelegate.qml
- Extract shared properties between media players on mobile and desktop into BasePlayerControl.qml

m3u files, when loaded by an audio player, will cause it to choke on
entries with non-ASCII characters--even if the file itself is UTF-8
encoded. To make this work, the filename extension itself must be m3u8,
not m3u.

Elisa already transparently supports files with the .m3u8 extension, but
does not save in this file format by default, and does not list them for
opening in its open dialog.

This commit makes Elisa able to open m3u8 files from its file dialog and
save playlists in that format by default.

CCBUG: 389187

This commit simplifies the button code for Elisa in the following ways:
- Use ToolButtons rather than flat Buttons for controls than want to
  look like ToolButtons. This is possible now that our QQC2 style shows
  ToolButton focus correctly.
- Remove hardcoded custom button sizes and let them be their natural
  size so they adjust with the scale factor and font size properly.
- Make HeaderFooterToolbar a bit smaller to fit the new noew-smaller
  ToolButtons.
- Redo the custom contentItem for the sort button to work properly with
  standardized buttons.

Sven Marquardt authored Jan 10, 2021 and Matthieu Gallien committed Jan 13, 2021

Adding Radio stream was broken before this. The issue was a check
against the databaseId for new Radiostreams. The check was against a
predefined value for ulong that was not correct anymore. This change
fixes the assumption about the value of not initialized long values by
using hasDatabaseid. Also introduces some tests so this can not
happen again. Hopefully.
Signed-off-by: Sven Marquardt <dev@mail.smarquardt.space>

Adding Radio stream was broken before this. The issue was a check
against the databaseId for new Radiostreams. The check was against a
predefined value for ulong that was not correct anymore. This change
fixes the assumption about the value of not initialized long values by
using hasDatabaseid. Also introduces some tests so this can not
happen again. Hopefully.
Signed-off-by: Sven Marquardt <dev@mail.smarquardt.space>

do not "loose" the embedded cover when modifying a track with an
embedded cover

BUG: 429041

there is one less line i n the model after a bug in database has been
fixed

adapt tests of data model to changes in database (those changes are
legitimate)

still some problems and tests errors

durationa and a few other roles where mssing. Add them back.

test removal of track number

test removal of disc number

only modify the database

will need to also modify the track file itself

cannot add or remove metadata fields

error checking and validity checking not yet done

fix automated tests of proxy model for media play list

ensure currentTrackChanged signals are emitted only when needed and
update tests accordingly

BUG: 425601

resets to default value before each test

modify the default value for play at start when needed

fix ability to do a proper usage of KConfig generated code in automated
tests

use KConfig in automated test

Summary:
only possible for all albums, all artists and all genres

related to T11154

Test Plan:
after adding
[Views]
EmbeddedView=3

Genres are added to ViewSelector list

properly display icons in views list including albums (default icon and cover)

introduce ViewsListData to handle data of the list of views

to be used by both the model and the ViewManager class handling the
switch between views

if config changed, embedded category property may have changed

separate ViewsListData object from ViewsModel and use it

will allow sharing with the ViewsManager object

ViewsModel no longer have any properties

will allow to get any amount of data including not visible ones

remove use of explicit path filters in ViewManager

use only generic data filters for paths

remove locale file only logic in favor of generic URL handling

remove code and remove data converion done in qml

remove most of the ElisaUtils::PlayListEntryType parameters to allow
enqueue of miced entities

clean up also in MediaPlayListProxyModel

fix enqueue from grid views header bar