1. 19 May, 2021 1 commit
  2. 13 Jan, 2021 1 commit
    • Sven Marquardt's avatar
      Fix Radio streams · 7b0cf1da
      Sven Marquardt authored and Matthieu Gallien's avatar Matthieu Gallien committed
      
      
      Adding Radio stream was broken before this. The issue was a check
      against the databaseId for new Radiostreams. The check was against a
      predefined value for ulong that was not correct anymore. This change
      fixes the assumption about the value of not initialized long values by
      using hasDatabaseid. Also introduces some tests so this can not
      happen again. Hopefully.
      Signed-off-by: Sven Marquardt's avatarSven Marquardt <dev@mail.smarquardt.space>
      7b0cf1da
  3. 10 Jan, 2021 1 commit
    • Sven Marquardt's avatar
      Fix Radio streams · 3fbb202c
      Sven Marquardt authored
      
      
      Adding Radio stream was broken before this. The issue was a check
      against the databaseId for new Radiostreams. The check was against a
      predefined value for ulong that was not correct anymore. This change
      fixes the assumption about the value of not initialized long values by
      using hasDatabaseid. Also introduces some tests so this can not
      happen again. Hopefully.
      Signed-off-by: Sven Marquardt's avatarSven Marquardt <dev@mail.smarquardt.space>
      3fbb202c
  4. 17 Nov, 2020 1 commit
  5. 12 Nov, 2020 3 commits
  6. 02 Nov, 2020 1 commit
  7. 18 Sep, 2020 1 commit
  8. 07 Jul, 2020 1 commit
  9. 20 May, 2020 3 commits
  10. 06 May, 2020 1 commit
  11. 22 Feb, 2020 1 commit
  12. 26 Jan, 2020 1 commit
  13. 22 Jan, 2020 2 commits
  14. 21 Jan, 2020 1 commit
    • Jerome Guidon's avatar
      Radios: add support for images · eb209bf8
      Jerome Guidon authored and Matthieu Gallien's avatar Matthieu Gallien committed
      Summary:
      Album images where disabled for radios. This patch adds support for images in the radio view. A field has been added to EditableMetaData to allow the user to choose the image he wants for a radio. It can be a local file or an url.
      
      Linked to: T7567
      
      Reviewers: #elisa, mgallien, ngraham, astippich
      
      Reviewed By: #elisa, astippich
      
      Subscribers: ndavis, astippich, ngraham, mgallien
      
      Differential Revision: https://phabricator.kde.org/D23859
      eb209bf8
  15. 05 Dec, 2019 1 commit
    • Jerome Guidon's avatar
      Standardize the database upgrade mechanism · 977c002b
      Jerome Guidon authored and Nate Graham's avatar Nate Graham committed
      Summary:
      This patch is aim to standardize the upgrade mechanism which is currently in the method DatabaseInterface::initDatabase.
      The idea is to avoid taking care about the upgrade logic when creating new versions.
      
      On a new version XX, the steps would be the following:
        1-create the method DatabaseInterface::upgradeDatabaseVXX
        2-add the version to the enum DatabaseInterface::DatabaseVersion
        3-add upgradeDatabaseVXX to the switch-cas in callUpgradeFunctionForVersion
      
      Added mechanism for upgrade the database
      Add integration for versions V9 -> V14
      Added drop request for the unused tables
      
      Reviewers: #elisa, mgallien, ngraham, astippich
      
      Reviewed By: #elisa, mgallien
      
      Differential Revision: https://phabricator.kde.org/D24563
      977c002b
  16. 10 Nov, 2019 1 commit
  17. 09 Nov, 2019 2 commits
  18. 09 Oct, 2019 1 commit
  19. 08 Oct, 2019 1 commit
    • Matthieu Gallien's avatar
      ensure that baloo detection works · e535ef7e
      Matthieu Gallien authored
      Summary:
      connect to the signal used to detect baloo earlier such that we detect
      it correctly at start
      
      Thanks to Martin Steigerwald for the report on stable branch (but also reproducible on master)
      
      CCMAIL: martin@lichtvoll.de
      
      BUG: 412210
      
      Test Plan:
      if no elisa files exist (database, kconfig and Qt settings) baloo is detected and used to get audio files
      
      without it, nothing happen at start
      
      Reviewers: #elisa, astippich, ngraham, jguidon
      
      Reviewed By: #elisa, ngraham
      
      Subscribers: mthw
      
      Differential Revision: https://phabricator.kde.org/D24303
      e535ef7e
  20. 06 Oct, 2019 1 commit
  21. 05 Oct, 2019 1 commit
  22. 19 Sep, 2019 1 commit
  23. 14 Sep, 2019 1 commit
  24. 09 Sep, 2019 1 commit
  25. 07 Sep, 2019 1 commit
  26. 05 Sep, 2019 1 commit
  27. 19 Aug, 2019 1 commit
    • Jerome Guidon's avatar
      Add support for radio streams · 84001921
      Jerome Guidon authored and Matthieu Gallien's avatar Matthieu Gallien committed
      Summary:
      Add support for radio streams
      
      Steps of development:
        - play a stream and get some information from it
        - Added a table for radios in the database (V13) with some examples in it.
        - Get the examples in the view and add/play them in the playlist.
      
      Test Plan: after the first reviews, add test for the radios view
      
      Reviewers: #elisa, #vdg, mgallien, astippich
      
      Reviewed By: #elisa, mgallien, astippich
      
      Subscribers: astippich, ngraham, mgallien, ndavis
      
      Maniphest Tasks: T7567
      
      Differential Revision: https://phabricator.kde.org/D21525
      84001921
  28. 09 Aug, 2019 1 commit
  29. 06 Aug, 2019 1 commit
  30. 24 Jul, 2019 1 commit
  31. 29 Jun, 2019 1 commit
  32. 28 Jun, 2019 1 commit
  33. 24 Jun, 2019 1 commit
    • Matthieu Gallien's avatar
      fix restore of tracks with missing metadata in playlist · a3eb443d
      Matthieu Gallien authored
      Summary:
      fix storing of tracks without track, disc, ...
      
      correctly store a null when track, disc, channels, bit rate, sample rate
      are not existing in the track data
      
      will need a complete reindexing to fix users database
      
      let play list and audio player restore state when track has few metadata
      
      when album, track number or disc number are missing, the state is not
      correctly restored at startup
      
      let those metadata be optional in the saved state such that tracks
      missing those are still restored
      
      Test Plan: new test is OK and a track without album, track and disc numbers will restore and playback will restore at correct position
      
      Reviewers: #elisa, astippich
      
      Reviewed By: astippich
      
      Subscribers: astippich, #elisa
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D21900
      a3eb443d
  34. 13 May, 2019 1 commit