1. 07 Mar, 2020 3 commits
  2. 16 Feb, 2020 4 commits
  3. 22 Jan, 2020 1 commit
  4. 10 Jan, 2020 1 commit
  5. 14 Nov, 2019 1 commit
  6. 10 Nov, 2019 1 commit
  7. 09 Nov, 2019 2 commits
  8. 09 Oct, 2019 1 commit
  9. 08 Oct, 2019 1 commit
    • Matthieu Gallien's avatar
      ensure that baloo detection works · e535ef7e
      Matthieu Gallien authored
      Summary:
      connect to the signal used to detect baloo earlier such that we detect
      it correctly at start
      
      Thanks to Martin Steigerwald for the report on stable branch (but also reproducible on master)
      
      CCMAIL: martin@lichtvoll.de
      
      BUG: 412210
      
      Test Plan:
      if no elisa files exist (database, kconfig and Qt settings) baloo is detected and used to get audio files
      
      without it, nothing happen at start
      
      Reviewers: #elisa, astippich, ngraham, jguidon
      
      Reviewed By: #elisa, ngraham
      
      Subscribers: mthw
      
      Differential Revision: https://phabricator.kde.org/D24303
      e535ef7e
  10. 06 Oct, 2019 1 commit
  11. 13 Sep, 2019 1 commit
  12. 27 Aug, 2019 1 commit
  13. 26 Aug, 2019 1 commit
    • Alexander Stippich's avatar
      Rework shuffle handling · aa0cd617
      Alexander Stippich authored
      Summary:
      Remove deprecated usage of qrand().
      Keep a list of the previous, current and next track
      when in shuffle mode, to be used in a following patch.
      Simplify calling skip and previousTracks
      
      Depends on D22769
      
      Test Plan: all tests pass
      
      Reviewers: ngraham, mgallien
      
      Reviewed By: mgallien
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D22770
      aa0cd617
  14. 22 Aug, 2019 1 commit
    • Alexander Stippich's avatar
      Make MediaPlayList responsible for remaining tracks · 9e28b008
      Alexander Stippich authored
      Summary:
      Make MediaPlayList responsible for remaining tracks.
      Allows simplification by only reacting to currentTrack
      changes inside manageheaderbar.
      Add tests for remainingTracks and cleanup manageheaderbar.
      Fixes the remaining tracks showing when in playlist repeat
      or shuffle mode.
      
      Test Plan:
      tests pass
      Remaining tracks are only showed for when not in
      shuffle or repeat mode
      
      Reviewers: ngraham, mgallien
      
      Reviewed By: mgallien
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D22769
      9e28b008
  15. 19 Aug, 2019 1 commit
  16. 06 Aug, 2019 1 commit
    • Matthieu Gallien's avatar
      fix the compilation album insertion · 61f06336
      Matthieu Gallien authored
      Summary:
      partial fix for handling albums without album artist
      
      partially handle the case of compilations not getting Various Artists as
      album artist
      
      BUG: 409147
      
      Test Plan: all tests are fine and most common cases should be covered.
      
      Reviewers: #elisa, ngraham, astippich
      
      Reviewed By: #elisa, ngraham
      
      Differential Revision: https://phabricator.kde.org/D22499
      61f06336
  17. 25 Jul, 2019 1 commit
  18. 24 Jun, 2019 1 commit
    • Matthieu Gallien's avatar
      fix restore of tracks with missing metadata in playlist · a3eb443d
      Matthieu Gallien authored
      Summary:
      fix storing of tracks without track, disc, ...
      
      correctly store a null when track, disc, channels, bit rate, sample rate
      are not existing in the track data
      
      will need a complete reindexing to fix users database
      
      let play list and audio player restore state when track has few metadata
      
      when album, track number or disc number are missing, the state is not
      correctly restored at startup
      
      let those metadata be optional in the saved state such that tracks
      missing those are still restored
      
      Test Plan: new test is OK and a track without album, track and disc numbers will restore and playback will restore at correct position
      
      Reviewers: #elisa, astippich
      
      Reviewed By: astippich
      
      Subscribers: astippich, #elisa
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D21900
      a3eb443d
  19. 17 Apr, 2019 1 commit
  20. 12 Apr, 2019 1 commit
    • Jerome Guidon's avatar
      Allow to undo the clear actions on the playlist · c8a43561
      Jerome Guidon authored
      Summary:
      When a clear action is performed on the playlist, the user might lose valuable work.
      Add the possibility to undo this operation via passive notification.
      Keep it simple by allowing only one undo and no redo.
      
       - The patch now enables to restore the playlist and the player status.
      For the notification, I use KNotification here, you can see in the screenshot the notification with an Undo button.
      
       - KNotification needs the file elisa.notifyrc to be installed in QStandardPaths::GenericDataLocation directory, so it may impact the packaging of the app (https://api.kde.org/frameworks/knotifications/html/classKNotification.html#file).
      
      Reviewers: mgallien
      
      Reviewed By: mgallien
      
      Subscribers: ngraham
      
      Tags: #elisa
      
      Maniphest Tasks: T5376
      
      Differential Revision: https://phabricator.kde.org/D19610
      c8a43561
  21. 25 Mar, 2019 1 commit
    • Matthieu Gallien's avatar
      Simplify and improve music indexers management · 79054e47
      Matthieu Gallien authored
      Summary:
      start baloo first and if it is not available, start local file indexer
      
      remove management of track discovery sources
      
      simplify management of tracks by removing management of which source has
      discovered a track
      
      should allow users to easily switch from Baloo to local file system as
      tracks source
      
      improve management of tracks sources such that only baloo or local file
      system scanning is enabled
      
      no longer emit a signal when Elisa cannot watch a file for changes
      
      refactor the way we check for Baloo availability
      
      filter tracks by the configured paths when getting all tracks from Baloo
      
      use the same list of paths than plain file system scanning
      
      BUG: 393106
      
      remove double checking for baloo configuration: not needed
      
      Baloo configuration is now checked before going into
      LocalBalooFileListing: no need to do it a second time
      
      add support for qt logging category and use it for file indexers
      
      improve management of indexers state and user reporting
      
      convert LocalBalooFileListing to only use categorized debug logs
      
      hopefully fix the display of busy indexers notifications
      
      when configuration change, display proper busy notification to the user
      
      indexing is no longer finished until tracks have been fully removed
      
      Test Plan:
      Only one indexer is active (baloo or plain old file indexer).
      Traces should help diagnose what happen
      
      Reviewers: ngraham
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D19650
      79054e47
  22. 15 Feb, 2019 2 commits
  23. 01 Feb, 2019 1 commit
  24. 19 Dec, 2018 1 commit
  25. 12 Dec, 2018 9 commits