GitLab

BUG: 415827

Summary: partial removal of isRadio and duplicated code in TrackMetadataModel

Test Plan:
could not spot regressions

all automatic tests are OK except elisaqmltests that does not run due to an issue with a missing so dependency on KIO

Reviewers: #elisa, ngraham, jguidon, astippich

Reviewed By: #elisa, ngraham, astippich

Differential Revision: https://phabricator.kde.org/D23280

Jerome Guidon authored Aug 19, 2019 and Matthieu Gallien committed Aug 19, 2019

Summary:
Add support for radio streams

Steps of development:
  - play a stream and get some information from it
  - Added a table for radios in the database (V13) with some examples in it.
  - Get the examples in the view and add/play them in the playlist.

Test Plan: after the first reviews, add test for the radios view

Reviewers: #elisa, #vdg, mgallien, astippich

Reviewed By: #elisa, mgallien, astippich

Subscribers: astippich, ngraham, mgallien, ndavis

Maniphest Tasks: T7567

Differential Revision: https://phabricator.kde.org/D21525

Summary:
The setup of the search shortcut was seriously broken.
Since multiple NavigationActionBars were instantiated
for each view, the shortcut would also be instantiated
multiple times, which could even crash Elisa.

Test Plan:
toggling the search fieed works, Elisa does not crash
when using the shortcut with different view

Reviewers: ngraham, ognarb, mgallien

Reviewed By: ngraham, ognarb

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D22781

Summary:
Separate delegates for tracks view and album view
are not needed anymore. Rename delegate to ListBrowserDelegate

Test Plan: No visual changes

Reviewers: mgallien, ngraham

Reviewed By: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D22410

Summary: put a small section header to indicate the disc number in the album view

Test Plan: only albums with mutiple discs show disc headers

Reviewers: #elisa, ngraham

Reviewed By: #elisa, ngraham

Subscribers: ngraham, pino

Differential Revision: https://phabricator.kde.org/D22110

Summary: fix tracks in album being wrongly sorted

Test Plan: now albums are sorted correctly

Reviewers: #elisa, ngraham, astippich

Reviewed By: #elisa, ngraham, astippich

Differential Revision: https://phabricator.kde.org/D22063

Summary:
Factor all list views into a single one to decrease duplicated code.

fix display of single album list view

we now have a list and a grid generic view

DataListView is the new generic list view

Next one will be the file manager view.

Test Plan: tests are OK and manual testing shows no regressions.

Reviewers: #elisa

Differential Revision: https://phabricator.kde.org/D21774

Summary: fix focus rectangle not visible in single album view mode

Test Plan: the focus rectangle is now properly shown

Reviewers: #elisa, ngraham

Reviewed By: #elisa, ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D21081

David Körmendi authored Apr 30, 2019 and Matthieu Gallien committed Apr 30, 2019

Summary:
As reported in 406940, the busy indicators that show up when data is being loaded are a bit too big at the moment. These changes reduce their size by anchoring them at the center instead of having them fill the available space (see example screenshots below for comparison).

BUG: 406940

Track view before change:
{F6798571}

Track view after change:
{F6798572}

Grid view before change:
{F6798574}

Grid view after change:
{F6798575}

Test Plan: This is just a minor UI tweak. No behavioural changes.

Reviewers: #elisa, mgallien, #vdg, ngraham

Reviewed By: #elisa, mgallien, #vdg, ngraham

Subscribers: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D20880

filter the newly added albums, artists or tracks to only display the
valid one (filtering by an artist, a genre ...)

currently no live refresh as soon as a new track is played

only the views accessible from the left most menu work