GitLab

Tranter Madi authored Apr 22, 2021 and Nate Graham committed Apr 22, 2021

- Elide/Align stuff properly
- Make the "Show in Folder" action visible again

Any smaller than about 620, and the player controls become unusable.

BUG: 435446
FIXED-IN: 21.04.0

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This commit is the culmination of !205

Notable Changes:
- Added mobile folder with components needed for mobile (and are separator from desktop components)
- Changed tst_NavigationActionBar test so that it does not check for artist button when it is invisible (loaders are used now so the button wouldn't be detected)
- Added loaders in ContentView.qml to switch between the mobile and desktop sidebars
- Changed ContextView.qml to use FormLayout, and also add mobile navigation buttons
- Collapsed the two list delegates (detailed and non detailed) together, along with edits for mobile usage
- Lowered the size of text in list delegates
- Extracted out the settings form to be shared between mobile and desktop
- Edited the grid delegate to be mobile friendly
- Removed clip from both listviews and gridviews for performance
- Extracted out the volume slider and duration slider to be shared for mobile and desktop
- Add mobile and desktop component switching for MediaPlayListView.qml
- Port the metadata view into Kirigami FormLayout so that it can be shared between mobile and desktop
- Rework NavigationActionBar buttons to all be components loaded in by loaders, so that we can have different layouts for mobile and desktop
- Extract shared properties for playlist delegates between mobile and desktop into BasePlayListDelegate.qml
- Extract shared properties between media players on mobile and desktop into BasePlayerControl.qml

We don't use light text in many places, and the uses here weren't
internally consistent anyway.

that is the case when we get an audio file not with a format not yet
supported by KFileMetaData

BUG: 433892
FIXED-IN: 21.04

m3u files, when loaded by an audio player, will cause it to choke on
entries with non-ASCII characters--even if the file itself is UTF-8
encoded. To make this work, the filename extension itself must be m3u8,
not m3u.

Elisa already transparently supports files with the .m3u8 extension, but
does not save in this file format by default, and does not list them for
opening in its open dialog.

This commit makes Elisa able to open m3u8 files from its file dialog and
save playlists in that format by default.

CCBUG: 389187

They were not valid, since ApplicationWindow is not an Item. This was
throwing an error in the console.

We don't want these views to suddenly have an auto-generated header in
addition to the custom one; we will need to do some porting work first
to get everything wired up correctly before we can display the
auto-generated header and delete the custom one.

(cherry picked from commit 61ed83ca)

rely mostly on Baloo for changes notifications (not complete)

CCBUG: 409587

This commit ports the Context View  to use a Kirgami.Page with proper
headers and footers, and ports the HeaderFooterToolbar components to use
QQC2.ToolBar with Kirigami.ActionToolbars inside them.

There are no UI changes.

separate the display of durations with StringDurationRole of the role
used to sort by duration (i.e. DurationRole) in milliseconds

This commit ports the PlayList to use a Kirgami.Page with proper
headers and footers, and ports the HeaderFooterToolbar components to use
QQC2.ToolBar with Kirigami.ActionToolbars inside them.

There are no UI changes.

This icon is used to mean "Cancel", while the button is not a cancel
button--it really and truly is just a close button. These buttons
typically have no icon.

(cherry picked from commit 0e88950d)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"