1. 01 Mar, 2021 1 commit
  2. 09 Dec, 2020 1 commit
    • Nate Graham's avatar
      Move remaining track indicator to playlist footer · 219ef4fb
      Nate Graham authored
      Right now it can overlap with the text in the HeaderBar. And its
      current location there feels kind of random, like it's just floating
      in space, unstructured. By moving it to the playlist's footer, we solve
      both of those problems and also give it in a more logical home:
      alongside the indicator of the total number of tracks. Now the footer
      shows two related pieces of information: the total number of tracks,
      the the number of remaining tracks.
      
      BUG: 429464
      FIXED-IN: 21.04
      219ef4fb
  3. 08 Dec, 2020 1 commit
  4. 05 Dec, 2020 1 commit
  5. 13 Oct, 2020 2 commits
  6. 11 Oct, 2020 1 commit
  7. 21 Sep, 2020 1 commit
  8. 15 Sep, 2020 1 commit
  9. 29 Aug, 2020 1 commit
  10. 12 Aug, 2020 1 commit
  11. 11 Aug, 2020 1 commit
  12. 07 Jul, 2020 2 commits
  13. 06 May, 2020 1 commit
  14. 16 Mar, 2020 1 commit
  15. 08 Mar, 2020 1 commit
  16. 07 Mar, 2020 1 commit
    • Alexander Stippich's avatar
      New shuffle mode for playlist · 3c925162
      Alexander Stippich authored
      This implements a new shuffle mode for the playlist with a proxy model that shuffles the available data.
      he following features are implemented:
      
      each track is selected exactly once in shuffle mode
      the shuffle mode and order are fully visible to the user
      full history with going back and forth
      
      Interfacing with the QML code is now done with the proxy model.
      
      BUG: 394333
      3c925162
  17. 01 Mar, 2020 1 commit
  18. 25 Feb, 2020 2 commits
  19. 14 Feb, 2020 2 commits
  20. 21 Dec, 2019 1 commit
  21. 13 Dec, 2019 1 commit
  22. 06 Oct, 2019 1 commit
  23. 10 Sep, 2019 1 commit
  24. 07 Sep, 2019 1 commit
    • Alexander Stippich's avatar
      Rework the mediaplayercontrol · 2ccf0082
      Alexander Stippich authored
      Summary:
      Rework the mediaplayercontrol to use the new previous
      and next tracks from mediaplaylist. Allows a large
      cleanup.
      
      Depends on D22771
      
      Test Plan:
      tests pass
      play, next and previous buttons are still enabled as before
      Random and repeat buttons still work as before
      
      Reviewers: ngraham, mgallien
      
      Reviewed By: mgallien
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D22772
      2ccf0082
  25. 22 Aug, 2019 2 commits
  26. 13 Aug, 2019 1 commit
  27. 03 Aug, 2019 1 commit
    • Alexander Stippich's avatar
      Fix setup of search shortcut · 0d52e4f1
      Alexander Stippich authored
      Summary:
      The setup of the search shortcut was seriously broken.
      Since multiple NavigationActionBars were instantiated
      for each view, the shortcut would also be instantiated
      multiple times, which could even crash Elisa.
      
      Test Plan:
      toggling the search fieed works, Elisa does not crash
      when using the shortcut with different view
      
      Reviewers: ngraham, ognarb, mgallien
      
      Reviewed By: ngraham, ognarb
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D22781
      0d52e4f1
  28. 21 Jul, 2019 1 commit
  29. 20 Jul, 2019 1 commit
  30. 20 Jun, 2019 1 commit
  31. 16 Jun, 2019 1 commit
  32. 12 Jun, 2019 3 commits
    • Matthieu Gallien's avatar
      improve accessibility by providing metadata for UI elements · ee49bfc0
      Matthieu Gallien authored
      Summary: Add metadata while preserving the string freeze to help a screen reader when navigating with keyboard
      
      Test Plan: Tested under plasma with orca
      
      Reviewers: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Reviewed By: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Subscribers: lavender, davidedmundson, ngraham
      
      Differential Revision: https://phabricator.kde.org/D21608
      ee49bfc0
    • Nate Graham's avatar
      [RFC] Implement KDE-style header toolbars and statusbars for Playlist and Context view · 00b32e06
      Nate Graham authored
      Summary:
      This patch is basically a design proposal in patch form.
      
      Right now, each view's header is not visually separated at all from the content
      view below it, and all header areas have different visual styles, some of then
      being very tall and taking up a lot of space that could be used for more content.
      The context view's flickable is adjusted to take advantage of this, resulting in
      a greatly increased amount of vertical space when the lyrics portion is long.
      
      This patch/design proposal implements a new style of header and statusbar
      that looks more "KDE-style", for lack of a batter term. It mimics what toolbars
      in Kirigami and other QML apps look like. Advantages include:
      - Improved visual consistency with modern KDE apps
      - Visually pleasing separation from content area
      - Scrollable content doesn't appear to get "cut off" under an invisible item anymore
      - More compact headers leave more room for content
      - Code simplification from using a re-usable component rather than multiple custom views
      
      Test Plan:
      Playlist, before: {F6878549}
      Playlist, after: {F6878548}
      
      Playlist + context view, before: {F6878551}
      Playlist + context view, after: {F6878550}
      
      This patch implements the new header style for only the Playlist and Context View.
      If the proposal is approved and the patch lands, I can do the main view too, which
      is more complicated to port and will require changes to the autotests as well.
      
      Reviewers: mgallien, #elisa, #vdg
      
      Reviewed By: mgallien, #elisa
      
      Differential Revision: https://phabricator.kde.org/D21676
      00b32e06
    • Matthieu Gallien's avatar
      improve accessibility by providing metadata for UI elements · 4c71234d
      Matthieu Gallien authored
      Summary: Add metadata while preserving the string freeze to help a screen reader when navigating with keyboard
      
      Test Plan: Tested under plasma with orca
      
      Reviewers: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Reviewed By: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Subscribers: lavender, davidedmundson, ngraham
      
      Differential Revision: https://phabricator.kde.org/D21608
      4c71234d
  33. 25 Mar, 2019 1 commit
    • Matthieu Gallien's avatar
      Simplify and improve music indexers management · 79054e47
      Matthieu Gallien authored
      Summary:
      start baloo first and if it is not available, start local file indexer
      
      remove management of track discovery sources
      
      simplify management of tracks by removing management of which source has
      discovered a track
      
      should allow users to easily switch from Baloo to local file system as
      tracks source
      
      improve management of tracks sources such that only baloo or local file
      system scanning is enabled
      
      no longer emit a signal when Elisa cannot watch a file for changes
      
      refactor the way we check for Baloo availability
      
      filter tracks by the configured paths when getting all tracks from Baloo
      
      use the same list of paths than plain file system scanning
      
      BUG: 393106
      
      remove double checking for baloo configuration: not needed
      
      Baloo configuration is now checked before going into
      LocalBalooFileListing: no need to do it a second time
      
      add support for qt logging category and use it for file indexers
      
      improve management of indexers state and user reporting
      
      convert LocalBalooFileListing to only use categorized debug logs
      
      hopefully fix the display of busy indexers notifications
      
      when configuration change, display proper busy notification to the user
      
      indexing is no longer finished until tracks have been fully removed
      
      Test Plan:
      Only one indexer is active (baloo or plain old file indexer).
      Traces should help diagnose what happen
      
      Reviewers: ngraham
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D19650
      79054e47