Nate Graham authored May 20, 2021 and Matthieu Gallien committed May 21, 2021

The Playlist currently has a homemade version of this with a line break
between sentences, but PlaceholderMessage now has a property just for
this.

The frameworks dependency version is bumped to 5.80, which is the
version where Kirigami.PlaceholderMessage gained this feature.

- Fix binding loop
- Use fixed height for sections
- Make the section's image fill all the height

The material style use 0 add padding by default and the
qqc2-desktop-style use more appropriate values.

This commit is the culmination of !205

Notable Changes:
- Added mobile folder with components needed for mobile (and are separator from desktop components)
- Changed tst_NavigationActionBar test so that it does not check for artist button when it is invisible (loaders are used now so the button wouldn't be detected)
- Added loaders in ContentView.qml to switch between the mobile and desktop sidebars
- Changed ContextView.qml to use FormLayout, and also add mobile navigation buttons
- Collapsed the two list delegates (detailed and non detailed) together, along with edits for mobile usage
- Lowered the size of text in list delegates
- Extracted out the settings form to be shared between mobile and desktop
- Edited the grid delegate to be mobile friendly
- Removed clip from both listviews and gridviews for performance
- Extracted out the volume slider and duration slider to be shared for mobile and desktop
- Add mobile and desktop com...

m3u files, when loaded by an audio player, will cause it to choke on
entries with non-ASCII characters--even if the file itself is UTF-8
encoded. To make this work, the filename extension itself must be m3u8,
not m3u.

Elisa already transparently supports files with the .m3u8 extension, but
does not save in this file format by default, and does not list them for
opening in its open dialog.

This commit makes Elisa able to open m3u8 files from its file dialog and
save playlists in that format by default.

CCBUG: 389187

We don't want these views to suddenly have an auto-generated header in
addition to the custom one; we will need to do some porting work first
to get everything wired up correctly before we can display the
auto-generated header and delete the custom one.

This commit ports the PlayList to use a Kirgami.Page with proper
headers and footers, and ports the HeaderFooterToolbar components to use
QQC2.ToolBar with Kirigami.ActionToolbars inside them.

There are no UI changes.

Nate Graham authored Jan 14, 2021 and Matthieu Gallien committed Jan 15, 2021

I broke this in 3b80b000 by making
PlayListBasicView into a ScrollView, not a ListView. Therefore anything
that wants to target properties and functions of the list view item
needs to be adjusted to do so explicitly.

BUG: 431602
FIXED-IN: 20.12.2

Right now it can overlap with the text in the HeaderBar. And its
current location there feels kind of random, like it's just floating
in space, unstructured. By moving it to the playlist's footer, we solve
both of those problems and also give it in a more logical home:
alongside the indicator of the total number of tracks. Now the footer
shows two related pieces of information: the total number of tracks,
the the number of remaining tracks.

BUG: 429464
FIXED-IN: 21.04

You need to pass the number as a placeholder even for the case of a
single item, because some languages use this form for e.g. the number
21.

This fixes the text on the placeholder flooding out when playlist is hidden

I don't know that QML enums existed back when this component was created
(they were introduced in Qt 5.10). Either way, they do now, so we should
use them.

This compinent suffered from various rookie mistakes:
- Making assumptions about its parent item
- Setting width and height properties of items in Layouts
- Hardcoded heights rather than using units

All are fixed. Visual changes are extremely minimal.

CCBUG: 424445

Kirigami has a standard component for this that results in a unified
appearance across KDE apps, and using it lets us remove tons of code.

This implements a new shuffle mode for the playlist with a proxy model that shuffles the available data.
he following features are implemented:

each track is selected exactly once in shuffle mode
the shuffle mode and order are fully visible to the user
full history with going back and forth

Interfacing with the QML code is now done with the proxy model.

BUG: 394333

Summary:
Remove entirely the PassiveNotification and use the already
present Kirigami.InlineMessage to consistently display
stuff related to playlists

Test Plan:
load e.g. any file that is not a playlist
using the load playlist button, new notification is displayed

Reviewers: mgallien, ngraham

Reviewed By: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D21911

Summary:
Port the button in the mediaplaylistview to FlatButtonWithTooltip.
Also unifies the accessibility behavior while at it.

Reviewers: mgallien

Reviewed By: mgallien

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D21854

Summary: Add metadata while preserving the string freeze to help a screen reader when navigating with keyboard

Test Plan: Tested under plasma with orca

Reviewers: #elisa, #plasma_accessibility, chempfling, ngraham

Reviewed By: #elisa, #plasma_accessibility, chempfling, ngraham

Subscribers: lavender, davidedmundson, ngraham

Differential Revision: https://phabricator.kde.org/D21608

Summary:
This patch is basically a design proposal in patch form.

Right now, each view's header is not visually separated at all from the content
view below it, and all header areas have different visual styles, some of then
being very tall and taking up a lot of space that could be used for more content.
The context view's flickable is adjusted to take advantage of this, resulting in
a greatly increased amount of vertical space when the lyrics portion is long.

This patch/design proposal implements a new style of header and statusbar
that looks more "KDE-style", for lack of a batter term. It mimics what toolbars
in Kirigami and other QML apps look like. Advantages include:
- Improved visual consistency with modern KDE apps
- Visually pleasing separation from content area
- Scrollable content doesn't appear to get "cut off" under an invisible item anymore
- More compact headers leave more room for content
- Code simplification from using a re-usable component rather than multiple custom views

Test Plan:
Playlist, before: {F6878549}
Playlist, after: {F6878548}

Playlist + context view, before: {F6878551}
Playlist + context view, after: {F6878550}

This patch implements the new header style for only the Playlist and Context View.
If the proposal is approved and the patch lands, I can do the main view too, which
is more complicated to port and will require changes to the autotests as well.

Reviewers: mgallien, #elisa, #vdg

Reviewed By: mgallien, #elisa

Differential Revision: https://phabricator.kde.org/D21676

Summary: Add metadata while preserving the string freeze to help a screen reader when navigating with keyboard

Test Plan: Tested under plasma with orca

Reviewers: #elisa, #plasma_accessibility, chempfling, ngraham

Reviewed By: #elisa, #plasma_accessibility, chempfling, ngraham

Subscribers: lavender, davidedmundson, ngraham

Differential Revision: https://phabricator.kde.org/D21608

Summary:
Currently playlist items do not span the full width; there is a bunch of
complicated logic to determine the margins and playlist's width. This
makes the display look unbalanced and causes a subtle visual bug
(see BUG: below).

This patch resolves both issues by making playlist items visually stick to
both edges of the playlist, just like the category selector list items do.

This patch also does a bit of necessary code cleanup for the playlist states.
I tested this out quite a bit but to make sure there were no regressions but
it's possible that I missed something so more testing may be needed.

BUG: 408210

Test Plan:
Before: {F6871989}

After: {F6871988}

Reviewers: mgallien, #elisa

Reviewed By: mgallien, #elisa

Subscribers: januz

Differential Revision: https://phabricator.kde.org/D21582

Summary:
Currently playlist items do not span the full width; there is a bunch of
complicated logic to determine the margins and playlist's width. This
makes the display look unbalanced and causes a subtle visual bug
(see BUG: below).

This patch resolves both issues by making playlist items visually stick to
both edges of the playlist, just like the category selector list items do.

This patch also does a bit of necessary code cleanup for the playlist states.
I tested this out quite a bit but to make sure there were no regressions but
it's possible that I missed something so more testing may be needed.

BUG: 408210

Test Plan:
Before: {F6871989}

After: {F6871988}

Reviewers: mgallien, #elisa

Reviewed By: mgallien, #elisa

Subscribers: januz

Differential Revision: https://phabricator.kde.org/D21582

Summary:
Use boundingRect of TextMetrics to compute the correct sizes

BUG: 407337

ensure all font.pointSize are set to integer values

Test Plan: Everything is looking fine

Reviewers: #elisa, ngraham

Reviewed By: ngraham

Differential Revision: https://phabricator.kde.org/D21198

Summary:
A timer is used to automatically hide the notification 3 seconds after it is being shown.

The duration is currently not user configurable.

BUG: 406603

Test Plan: 3 seconds after it is being shown, the notification is automatically removed

Reviewers: #elisa, ngraham

Reviewed By: ngraham

Subscribers: shubham, pino

Differential Revision: https://phabricator.kde.org/D20670

Jerome Guidon authored Apr 12, 2019 and Matthieu Gallien committed Apr 12, 2019

Summary:
When a clear action is performed on the playlist, the user might lose valuable work.
Add the possibility to undo this operation via passive notification.
Keep it simple by allowing only one undo and no redo.

 - The patch now enables to restore the playlist and the player status.
For the notification, I use KNotification here, you can see in the screenshot the notification with an Undo button.

 - KNotification needs the file elisa.notifyrc to be installed in QStandardPaths::GenericDataLocation directory, so it may impact the packaging of the app (https://api.kde.org/frameworks/knotifications/html/classKNotification.html#file).

Reviewers: mgallien

Reviewed By: mgallien

Subscribers: ngraham

Tags: #elisa

Maniphest Tasks: T5376

Differential Revision: https://phabricator.kde.org/D19610

Ashwin Dhakaita authored Jan 15, 2019 and Matthieu Gallien committed Jan 15, 2019

Summary:
Assign SpaceBar key as the global shortcut for play/pause action.  Most of the media player out there already use spacebar as the global shortcut for play/pause action.  So,  it would be good to do the same for Elisa.
Modified ElisaMainWindow.qml to add the shortcut component.
Modified MediaPlayerControl.qml to prevent elements from getting focus as it causes interference with the shortcut keypressed events.

BUG:    392989
FIXED-IN:    elisa  0.3.80

Reviewers: #elisa, ngraham, mgallien

Reviewed By: #elisa, ngraham, mgallien

Subscribers: shubham, mgallien, ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D17994