1. 11 Feb, 2020 1 commit
  2. 09 Feb, 2020 1 commit
  3. 04 Feb, 2020 1 commit
  4. 02 Feb, 2020 1 commit
  5. 08 Jan, 2020 1 commit
    • Nate Graham's avatar
      Playlist: adopt simpler and more compact track/disc numbering and playback indicator · 0ae5dd3e
      Nate Graham authored
      Elisa's playlist items currently use a bunch of very complicated code to produce a large amount of whitespace to the left of the track/album numbers that contains only the playback indicator, and aligns the right edge of the album art with the right edge of the numbers. Unfortunately this results in a lot of wasted space in the very narrow space of the playlist, and many song titles are elided.
      
      This MR changes the visual style to reduce the whitespace and replace the track/disc number indicator with the playback indicator for the currently playing song, saving a ton of space. Doing this allows the elimination of a great deal of complex and fragile layouting code.
      0ae5dd3e
  6. 03 Jan, 2020 1 commit
  7. 22 Dec, 2019 1 commit
  8. 17 Aug, 2019 2 commits
  9. 14 Aug, 2019 1 commit
  10. 08 Aug, 2019 1 commit
    • Alexander Stippich's avatar
      Use standard icon names · 3cd39553
      Alexander Stippich authored
      Summary:
      Try to avoid icon names containing "amarok" in order to
      use more common icon names, which they are symlink of.
      Only remaining icon is "media-show-active-track-amarok"
      for which there is no standard replacement.
      
      Reviewers: ngraham, mgallien
      
      Reviewed By: ngraham, mgallien
      
      Differential Revision: https://phabricator.kde.org/D22921
      3cd39553
  11. 08 Jul, 2019 1 commit
  12. 07 Jul, 2019 1 commit
    • Nate Graham's avatar
      Implement new Header toolbar style for main view · 7160095a
      Nate Graham authored
      Summary:
      This patch implements the new header toolbar style for the main view.
      
      Of note, I had to remove the subtitle and make the buttons icons-only toolbuttons.
      If these are considered problems, what we could make do is always use the toolbar to
      display the category name (rather than the album name etc) to make room for the
      toolbuttons regaining their labels, then put the artist/album/etc names below inside
      the content view itself, sort of like what I did in the Context view in D21771. That
      would probably be best suited as material for a follow-up patch though since it would
      entail porting to QQC2 to get toolbuttons that can have visible text.
      
      Test Plan:
      Before, search tools collapsed: {F6886122}
      After: search tools collapsed: {F6886123}
      
      Before: search tools expanded and in use: {F6886121}
      After: search tools expanded and in use: {F6886120}
      
      Before: drilldown into an album, showing a list: {F6886118}
      After: drilldown into an album, showing a list: {F6918020}
      
      Reviewers: mgallien, #elisa, #vdg, astippich
      
      Reviewed By: astippich
      
      Subscribers: mikeroyal, astippich
      
      Differential Revision: https://phabricator.kde.org/D21776
      7160095a
  13. 12 Jun, 2019 1 commit
    • Nate Graham's avatar
      [RFC] Implement KDE-style header toolbars and statusbars for Playlist and Context view · 00b32e06
      Nate Graham authored
      Summary:
      This patch is basically a design proposal in patch form.
      
      Right now, each view's header is not visually separated at all from the content
      view below it, and all header areas have different visual styles, some of then
      being very tall and taking up a lot of space that could be used for more content.
      The context view's flickable is adjusted to take advantage of this, resulting in
      a greatly increased amount of vertical space when the lyrics portion is long.
      
      This patch/design proposal implements a new style of header and statusbar
      that looks more "KDE-style", for lack of a batter term. It mimics what toolbars
      in Kirigami and other QML apps look like. Advantages include:
      - Improved visual consistency with modern KDE apps
      - Visually pleasing separation from content area
      - Scrollable content doesn't appear to get "cut off" under an invisible item anymore
      - More compact headers leave more room for content
      - Code simplification from using a re-usable component rather than multiple custom views
      
      Test Plan:
      Playlist, before: {F6878549}
      Playlist, after: {F6878548}
      
      Playlist + context view, before: {F6878551}
      Playlist + context view, after: {F6878550}
      
      This patch implements the new header style for only the Playlist and Context View.
      If the proposal is approved and the patch lands, I can do the main view too, which
      is more complicated to port and will require changes to the autotests as well.
      
      Reviewers: mgallien, #elisa, #vdg
      
      Reviewed By: mgallien, #elisa
      
      Differential Revision: https://phabricator.kde.org/D21676
      00b32e06
  14. 14 May, 2019 1 commit
  15. 23 Apr, 2019 1 commit
    • Nate Graham's avatar
      Revamp grid browser delegates to improve UI · 761e3af6
      Nate Graham authored
      Summary:
      This patch changes the grid browser delegates in the following ways:
      - Labels are centered
      - Album art size increases from 100px to 170px, making the album view more attractive and leaving more room for labels
      - Hover buttons now appear in the corner, have borders, and no longer make the album art get washed out when the delegate is hovered
      - Some minor layout and positioning bugs are fixed
      
      As a result, the following bugs are fixed:
      BUG: 406468
      BUG: 406476
      
      Also, the last usage of QQC1 in this component is removed as a side effect.
      
      Test Plan:
      Everything still works and there are no behavioral changes.
      
      {F6780036}
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Differential Revision: https://phabricator.kde.org/D20581
      761e3af6
  16. 16 Apr, 2019 1 commit
  17. 14 Apr, 2019 2 commits
  18. 01 Feb, 2019 1 commit
  19. 30 Dec, 2018 1 commit
  20. 12 Dec, 2018 1 commit
  21. 17 Nov, 2018 1 commit
  22. 17 Sep, 2018 2 commits
  23. 13 Sep, 2018 2 commits
  24. 10 Sep, 2018 1 commit
  25. 23 Aug, 2018 1 commit
  26. 15 Jul, 2018 1 commit
  27. 02 Jul, 2018 1 commit
  28. 01 Jul, 2018 1 commit
  29. 14 Jun, 2018 1 commit
  30. 16 May, 2018 3 commits
  31. 13 May, 2018 1 commit
    • Diego Gangl's avatar
      Design tweaks for the PlayerBar · 314be22f
      Diego Gangl authored
      Summary:
      Design changes for the elisa player bar according to the mockups in the ML
      
      ## Included in this patch
      
      - Move menu button to the bar
      - Make volume slider a bit smaller
      - Move repeat and shuffle to the bar
      - Fix the seek's handle so it doesn't show the radius of the elapsed rect
      - Make player bar slightly thinner
      - Make background of the seek/volume sliders darker so they are more visible
      - Make volume button closer to slider
      - Tweak length of seek bar and spacing between elements to make the design feel more balanced
      - Align "remaining tracks" text and imported notification with the hamburger menu
      
      {F5835836}
      
      ## Notes
      
      - I haven't tested this with a RTL layout. I follow the LayoutMirroring pattern so it should be mostly ok (plz test!)
      - I'm pretty sure I broke something when I moved the shuffle and repeat buttons to the bar because their state isn't being saved when I restart Elisa, but I can't figure out what it is.
      - Do we have another choice of next/prev track icons? The vertical bars on these are super huge and make them feel way too heavy. Specially compared to the shuffle/repeat icons
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Subscribers: ngraham, mgallien, astippich
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D12714
      314be22f
  32. 08 May, 2018 1 commit
    • Diego Gangl's avatar
      Sidebar design changes · 3f978272
      Diego Gangl authored
      Summary:
      Design changes for the sidebar according to the mockups in the ML
      
      ## In this patch
      
      - Make sidebar smaller
      - Make the selected view use the highlight color for the text and icon
      - Add a small margin to align with the views titles
      - Remove backgrounds
      
      {F5835919}
      
      Reviewers: #elisa, mgallien
      
      Reviewed By: #elisa, mgallien
      
      Subscribers: mgallien, ngraham
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D12715
      3f978272
  33. 06 May, 2018 1 commit
  34. 27 Mar, 2018 1 commit