1. 13 Mar, 2021 1 commit
    • Devin Lin's avatar
      Add mobile layout · 7bb83f95
      Devin Lin authored
      This commit is the culmination of !205
      
      Notable Changes:
      - Added mobile folder with components needed for mobile (and are separator from desktop components)
      - Changed tst_NavigationActionBar test so that it does not check for artist button when it is invisible (loaders are used now so the button wouldn't be detected)
      - Added loaders in ContentView.qml to switch between the mobile and desktop sidebars
      - Changed ContextView.qml to use FormLayout, and also add mobile navigation buttons
      - Collapsed the two list delegates (detailed and non detailed) together, along with edits for mobile usage
      - Lowered the size of text in list delegates
      - Extracted out the settings form to be shared between mobile and desktop
      - Edited the grid delegate to be mobile friendly
      - Removed clip from both listviews and gridviews for performance
      - Extracted out the volume slider and duration slider to be shared for mobile and desktop
      - Add mobile and desktop component switching for MediaPlayListView.qml
      - Port the metadata view into Kirigami FormLayout so that it can be shared between mobile and desktop
      - Rework NavigationActionBar buttons to all be components loaded in by loaders, so that we can have different layouts for mobile and desktop
      - Extract shared properties for playlist delegates between mobile and desktop into BasePlayListDelegate.qml
      - Extract shared properties between media players on mobile and desktop into BasePlayerControl.qml
      7bb83f95
  2. 02 Mar, 2021 2 commits
    • Nate Graham's avatar
      Prefer m3u8 over m3u as a playlist format · 08583663
      Nate Graham authored
      m3u files, when loaded by an audio player, will cause it to choke on
      entries with non-ASCII characters--even if the file itself is UTF-8
      encoded. To make this work, the filename extension itself must be m3u8,
      not m3u.
      
      Elisa already transparently supports files with the .m3u8 extension, but
      does not save in this file format by default, and does not list them for
      opening in its open dialog.
      
      This commit makes Elisa able to open m3u8 files from its file dialog and
      save playlists in that format by default.
      
      CCBUG: 389187
      08583663
    • Nate Graham's avatar
  3. 25 Feb, 2021 1 commit
  4. 13 Feb, 2021 1 commit
    • Nate Graham's avatar
      Port playlist panel to Kirigami.Page · 41793eda
      Nate Graham authored
      This commit ports the PlayList to use a Kirgami.Page with proper
      headers and footers, and ports the HeaderFooterToolbar components to use
      QQC2.ToolBar with Kirigami.ActionToolbars inside them.
      
      There are no UI changes.
      41793eda
  5. 15 Jan, 2021 1 commit
  6. 09 Dec, 2020 1 commit
    • Nate Graham's avatar
      Move remaining track indicator to playlist footer · 219ef4fb
      Nate Graham authored
      Right now it can overlap with the text in the HeaderBar. And its
      current location there feels kind of random, like it's just floating
      in space, unstructured. By moving it to the playlist's footer, we solve
      both of those problems and also give it in a more logical home:
      alongside the indicator of the total number of tracks. Now the footer
      shows two related pieces of information: the total number of tracks,
      the the number of remaining tracks.
      
      BUG: 429464
      FIXED-IN: 21.04
      219ef4fb
  7. 08 Dec, 2020 1 commit
    • Nate Graham's avatar
      Correct i18np() usage · d15a7989
      Nate Graham authored
      You need to pass the number as a placeholder even for the case of a
      single item, because some languages use this form for e.g. the number
      21.
      d15a7989
  8. 10 Sep, 2020 1 commit
  9. 01 Sep, 2020 2 commits
  10. 29 Aug, 2020 1 commit
  11. 23 Jul, 2020 1 commit
  12. 07 Jul, 2020 1 commit
  13. 12 May, 2020 1 commit
  14. 06 May, 2020 1 commit
  15. 24 Apr, 2020 1 commit
  16. 14 Mar, 2020 1 commit
  17. 11 Mar, 2020 1 commit
  18. 07 Mar, 2020 1 commit
    • Alexander Stippich's avatar
      New shuffle mode for playlist · 3c925162
      Alexander Stippich authored
      This implements a new shuffle mode for the playlist with a proxy model that shuffles the available data.
      he following features are implemented:
      
      each track is selected exactly once in shuffle mode
      the shuffle mode and order are fully visible to the user
      full history with going back and forth
      
      Interfacing with the QML code is now done with the proxy model.
      
      BUG: 394333
      3c925162
  19. 25 Feb, 2020 2 commits
  20. 16 Feb, 2020 1 commit
  21. 04 Jan, 2020 1 commit
  22. 22 Dec, 2019 1 commit
  23. 20 Jul, 2019 1 commit
  24. 19 Jun, 2019 1 commit
  25. 12 Jun, 2019 4 commits
    • Nate Graham's avatar
      Fix merge collision issue · 86e40e7e
      Nate Graham authored
      86e40e7e
    • Matthieu Gallien's avatar
      improve accessibility by providing metadata for UI elements · ee49bfc0
      Matthieu Gallien authored
      Summary: Add metadata while preserving the string freeze to help a screen reader when navigating with keyboard
      
      Test Plan: Tested under plasma with orca
      
      Reviewers: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Reviewed By: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Subscribers: lavender, davidedmundson, ngraham
      
      Differential Revision: https://phabricator.kde.org/D21608
      ee49bfc0
    • Nate Graham's avatar
      [RFC] Implement KDE-style header toolbars and statusbars for Playlist and Context view · 00b32e06
      Nate Graham authored
      Summary:
      This patch is basically a design proposal in patch form.
      
      Right now, each view's header is not visually separated at all from the content
      view below it, and all header areas have different visual styles, some of then
      being very tall and taking up a lot of space that could be used for more content.
      The context view's flickable is adjusted to take advantage of this, resulting in
      a greatly increased amount of vertical space when the lyrics portion is long.
      
      This patch/design proposal implements a new style of header and statusbar
      that looks more "KDE-style", for lack of a batter term. It mimics what toolbars
      in Kirigami and other QML apps look like. Advantages include:
      - Improved visual consistency with modern KDE apps
      - Visually pleasing separation from content area
      - Scrollable content doesn't appear to get "cut off" under an invisible item anymore
      - More compact headers leave more room for content
      - Code simplification from using a re-usable component rather than multiple custom views
      
      Test Plan:
      Playlist, before: {F6878549}
      Playlist, after: {F6878548}
      
      Playlist + context view, before: {F6878551}
      Playlist + context view, after: {F6878550}
      
      This patch implements the new header style for only the Playlist and Context View.
      If the proposal is approved and the patch lands, I can do the main view too, which
      is more complicated to port and will require changes to the autotests as well.
      
      Reviewers: mgallien, #elisa, #vdg
      
      Reviewed By: mgallien, #elisa
      
      Differential Revision: https://phabricator.kde.org/D21676
      00b32e06
    • Matthieu Gallien's avatar
      improve accessibility by providing metadata for UI elements · 4c71234d
      Matthieu Gallien authored
      Summary: Add metadata while preserving the string freeze to help a screen reader when navigating with keyboard
      
      Test Plan: Tested under plasma with orca
      
      Reviewers: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Reviewed By: #elisa, #plasma_accessibility, chempfling, ngraham
      
      Subscribers: lavender, davidedmundson, ngraham
      
      Differential Revision: https://phabricator.kde.org/D21608
      4c71234d
  26. 06 Jun, 2019 2 commits
    • Nate Graham's avatar
      Make Playlist items span full width · fe7d7043
      Nate Graham authored
      Summary:
      Currently playlist items do not span the full width; there is a bunch of
      complicated logic to determine the margins and playlist's width. This
      makes the display look unbalanced and causes a subtle visual bug
      (see BUG: below).
      
      This patch resolves both issues by making playlist items visually stick to
      both edges of the playlist, just like the category selector list items do.
      
      This patch also does a bit of necessary code cleanup for the playlist states.
      I tested this out quite a bit but to make sure there were no regressions but
      it's possible that I missed something so more testing may be needed.
      
      BUG: 408210
      
      Test Plan:
      Before: {F6871989}
      
      After: {F6871988}
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Subscribers: januz
      
      Differential Revision: https://phabricator.kde.org/D21582
      fe7d7043
    • Nate Graham's avatar
      Make Playlist items span full width · 50bbbfa3
      Nate Graham authored
      Summary:
      Currently playlist items do not span the full width; there is a bunch of
      complicated logic to determine the margins and playlist's width. This
      makes the display look unbalanced and causes a subtle visual bug
      (see BUG: below).
      
      This patch resolves both issues by making playlist items visually stick to
      both edges of the playlist, just like the category selector list items do.
      
      This patch also does a bit of necessary code cleanup for the playlist states.
      I tested this out quite a bit but to make sure there were no regressions but
      it's possible that I missed something so more testing may be needed.
      
      BUG: 408210
      
      Test Plan:
      Before: {F6871989}
      
      After: {F6871988}
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Subscribers: januz
      
      Differential Revision: https://phabricator.kde.org/D21582
      50bbbfa3
  27. 14 May, 2019 1 commit
  28. 26 Apr, 2019 1 commit
  29. 12 Apr, 2019 1 commit
    • Jerome Guidon's avatar
      Allow to undo the clear actions on the playlist · c8a43561
      Jerome Guidon authored and Matthieu Gallien's avatar Matthieu Gallien committed
      Summary:
      When a clear action is performed on the playlist, the user might lose valuable work.
      Add the possibility to undo this operation via passive notification.
      Keep it simple by allowing only one undo and no redo.
      
       - The patch now enables to restore the playlist and the player status.
      For the notification, I use KNotification here, you can see in the screenshot the notification with an Undo button.
      
       - KNotification needs the file elisa.notifyrc to be installed in QStandardPaths::GenericDataLocation directory, so it may impact the packaging of the app (https://api.kde.org/frameworks/knotifications/html/classKNotification.html#file).
      
      Reviewers: mgallien
      
      Reviewed By: mgallien
      
      Subscribers: ngraham
      
      Tags: #elisa
      
      Maniphest Tasks: T5376
      
      Differential Revision: https://phabricator.kde.org/D19610
      c8a43561
  30. 15 Jan, 2019 1 commit
    • Ashwin  Dhakaita's avatar
      Global shortcut for play/pause action using spacebar key · 5847d0e0
      Ashwin Dhakaita authored and Matthieu Gallien's avatar Matthieu Gallien committed
      Summary:
      Assign SpaceBar key as the global shortcut for play/pause action.  Most of the media player out there already use spacebar as the global shortcut for play/pause action.  So,  it would be good to do the same for Elisa.
      Modified ElisaMainWindow.qml to add the shortcut component.
      Modified MediaPlayerControl.qml to prevent elements from getting focus as it causes interference with the shortcut keypressed events.
      
      BUG:    392989
      FIXED-IN:    elisa  0.3.80
      
      Reviewers: #elisa, ngraham, mgallien
      
      Reviewed By: #elisa, ngraham, mgallien
      
      Subscribers: shubham, mgallien, ngraham
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D17994
      5847d0e0
  31. 30 Dec, 2018 1 commit
  32. 20 Dec, 2018 1 commit
  33. 12 Dec, 2018 1 commit