Skip to content

Fix the spacebar play/pause action when specific buttons have focus

Jack Hill requested to merge jackh/elisa:fix/spacebar-play-pause into master

Reason for the change

An event filter was applied to some specific buttons with the intention of overriding the space-bar for the play/pause action, but actually it had the effect of making the space-bar do nothing when pressed while one of these buttons had focus.

The space-bar shortcut is already handled by the Kirigami.Action in ElisaMainWindow, making this event filter unnecessary anyway.

Test plan

  • Apply focus to any button on the main toolbar, except for the Toggle Playlist button
  • Press space
  • Before: nothing happens
  • Now: playback is toggled

Bugs fixed

BUG: 476532

Edited by Jack Hill

Merge request reports

Loading