Commit 904dc9fb authored by Nate Graham's avatar Nate Graham 🔩
Browse files

Don't look for translated version of "Play-Pause" shortcut

Shortcuts should always use bare string literals instead of translations
because this causes issues in cases where the string has not been
translated in some languages, or when it gets customized before or after
the translation takes place.

This commit fixes the problem by always searching for the string literal.

BUG: 410110
FIXED-IN: 20.12.1
parent 35b6a6a8
Pipeline #42897 passed with stage
in 27 seconds
......@@ -526,7 +526,7 @@ bool ElisaApplication::eventFilter(QObject *object, QEvent *event)
Q_UNUSED(object)
auto *keyEvent = static_cast<QKeyEvent*>(event);
auto playPauseAction = d->mCollection.action(tr("Play-Pause"));
auto playPauseAction = d->mCollection.action(QStringLiteral("Play-Pause"));
if (keyEvent->key() == Qt::Key_Space && playPauseAction->shortcut()[0] == Qt::Key_Space) {
return true;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment