Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit dc6aea3d authored by Michael Pyne's avatar Michael Pyne

Fix two bugs in JuK trunk:

1) Crash when trying to download covers.  Apparently I missed the bit in the KIO docs where the jobs will
delete themselves when ready.  I believe this fixes bug 156204.
2) No longer allow eleventy billion KIO download progress windows to show up while filling in the cover
chooser dialog.

CCBUG:156204

svn path=/trunk/KDE/kdemultimedia/juk/; revision=805279
parent e00fe5ec
......@@ -70,7 +70,7 @@ WebImageFetcher::WebImageFetcher(QObject *parent)
WebImageFetcher::~WebImageFetcher()
{
delete d->connection;
delete d->dialog;
delete d;
}
......@@ -113,7 +113,7 @@ void WebImageFetcher::slotLoadImageURLs()
void WebImageFetcher::slotWebRequestFinished(KJob *job)
{
kDebug(65432) ;
kDebug(65432) << "Results received.\n";
if(job != d->connection)
return;
......@@ -138,11 +138,9 @@ void WebImageFetcher::slotWebRequestFinished(KJob *job)
kError(65432) << "Unable to create XML document from Yahoo results.\n";
kError(65432) << "Line " << errorLine << ", " << errorStr << endl;
delete d->connection;
return;
}
delete d->connection;
QDomNode n = results.documentElement();
bool hasNoResults = false;
......
......@@ -225,7 +225,7 @@ CoverIconViewItem::CoverIconViewItem(QWidget *parent, const WebImage &image) :
// Start downloading the image.
m_job = KIO::storedGet(image.thumbURL());
m_job = KIO::storedGet(image.thumbURL(), KIO::NoReload, KIO::HideProgressInfo);
connect(m_job, SIGNAL(result(KJob *)), this, SLOT(imageResult(KJob *)));
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment