GitLab

code to our already existing abstractions.

svn path=/trunk/kdemultimedia/juk/; revision=359727

This simplify whitespace here seems bogus to me.  That could
potentially break the folder name "My  Music" which though odd wouldn't
be invalid in any way.

Michael -- does this seem bogus to you too on a second look?

CCMAIL:Michael Pyne <michael.pyne@kdemail.net>

svn path=/trunk/kdemultimedia/juk/; revision=359725

time that you use it.  Also moved some variables into local scopes; even though
it's slighly less effecient, that's hardly a bottleneck in this code and it
makes it easier to read.

svn path=/trunk/kdemultimedia/juk/; revision=359724

svn path=/trunk/kdemultimedia/juk/; revision=359673

it's easier to debug when it prompts you about renaming rather than trying to
guess where the file went.

svn path=/trunk/kdemultimedia/juk/; revision=359672

svn path=/trunk/kdemultimedia/juk/; revision=359550

GUI: Overhaul the file renamer configuration dialog based on a design of Scott's.  This involved a lot more code than I thought at first, but it should be pretty neat.

This also should fix wish 64849 (Add genre to file renamer) and wish 63912.
In essence this creates a dialog that has a row with each possible category, and arrows allowing you to move that category up and down.
* In the options for the category, you can control leading and trailing text, and what happens if the tag is empty.
* You can set a minimum width for the track (bug 63912).
* The dialog includes a sample result, and you can either edit the sample tag values manually, or load tags from a file to see what it would look like.
* Right now the file renamer code automatically suppresses separators between tag values that use bracketing characters, since I feel that stuff like Artist - Title - [Track] looks dumb, but that may be changed/removed later.

Suggestions are accepted: michael (dot) pyne (at) kdemail (dot) net.

BUG:63912
BUG:64849

svn path=/trunk/kdemultimedia/juk/; revision=359516

symptoms to #77315, but actually isn't the same bug.

CCBUG:77315

svn path=/trunk/kdemultimedia/juk/; revision=355656

Fix bug 90608 (File Renamer dialog pops up unnecessarily).  You will still get No Change for filenames that don't change in the confirm dialog, but we don't try to rename them anymore.

In addition, error messages have been compacted into a single dialog.

CCMAIL:90608-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=351021

CCMAIL:89841-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=349612

  created.

svn path=/trunk/kdemultimedia/juk/; revision=349610

svn path=/trunk/kdemultimedia/juk/; revision=318174

file renamer dialog box.

Thiago, thanks for the patch, but I think that was for a different bug. :-)

CCMAIL:70699-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=318109

(but doesn't exist in BRANCH).  Show "No Change" when the files *are* the same.

svn path=/trunk/kdemultimedia/juk/; revision=316153

CCMAIL:82512-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=316126

over thier signal and slot code to normal method calls.  This code was pretty
ugly so this actually made things much more clear.

Also this required coming up with a more self contained MusicBrainz confirmation
process, so that's now been moved into MusicBrainzFileQuery.

Fixed a lot of includes along the way and removed a lot of unused cruft...

svn path=/trunk/kdemultimedia/juk/; revision=302745

  proper error handling) instead of doing that work by hand.

svn path=/trunk/kdemultimedia/juk/; revision=300373

file are the same in the renamer confirmation dialog.

svn path=/trunk/kdemultimedia/juk/; revision=294289

still a lot of damage control yet to be done, but this at least gets things
building and working after porting the PlaylistItem over.

svn path=/trunk/kdemultimedia/juk/; revision=293445

http://www.kde.me.uk/index.php?page=kdemultimedia_typos

svn path=/trunk/kdemultimedia/juk/; revision=284772

sane (and to follow the naming conventions from TagLib).

svn path=/trunk/kdemultimedia/juk/; revision=263819

  renaming loop

svn path=/trunk/kdemultimedia/juk/; revision=249336

a period in them prior to the extension.

svn path=/trunk/kdemultimedia/juk/; revision=249259

svn path=/trunk/kdemultimedia/juk/; revision=249258

svn path=/trunk/kdemultimedia/juk/; revision=249220

svn path=/trunk/kdemultimedia/juk/; revision=249181

  many files at once. It still sucks though, maybe a ListView or such is in
  order ;-/

svn path=/trunk/kdemultimedia/juk/; revision=248958

  for directory separators, not the token itself.
- Don't break if "Needs Value" is checked and a token value contains only
  slashes.

svn path=/trunk/kdemultimedia/juk/; revision=248892

  configuration :-)

svn path=/trunk/kdemultimedia/juk/; revision=248891

  filename scheme.

svn path=/trunk/kdemultimedia/juk/; revision=248890

svn path=/trunk/kdemultimedia/juk/; revision=248885

svn path=/trunk/kdemultimedia/juk/; revision=248855

svn path=/trunk/kdemultimedia/juk/; revision=248853

svn path=/trunk/kdemultimedia/juk/; revision=248811

  dialog

svn path=/trunk/kdemultimedia/juk/; revision=248733

svn path=/trunk/kdemultimedia/juk/; revision=244869

over hacks to make it work with 3.1 libs.

svn path=/trunk/kdemultimedia/juk/; revision=240929

roaming user fixes: use readPathEntry/writePathEntry instead of readEntry/writeEntry where necessary

svn path=/trunk/kdemultimedia/juk/; revision=232747

svn path=/trunk/kdemultimedia/juk/; revision=223459

of includes that weren't needed.

svn path=/trunk/kdemultimedia/juk/; revision=221955