1. 22 Feb, 2012 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Add last.fm scrobbling support to JuK. · 62c3c0ae
      Martin Tobias Holmedahl Sandsmark authored
      No configuration GUI yet, you have to add a [Scrobbling] section to your jukrc,
      with a Username=foo and Password=bar field to make it work.
      
      Doesn't use liblastfm, because liblastfm doesn't support the latest last.fm API.
      
      FEATURE:
      CCBUG:262194
      
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1281560
      62c3c0ae
  2. 29 Jan, 2012 1 commit
  3. 26 Jan, 2012 3 commits
    • Michael Pyne's avatar
      Use canonicalPath for playlist m3u files. · f47708a2
      Michael Pyne authored
      This is as opposed to absolutePath, which can end up adding the same playlist multiple
      times when given the combination of symlinks and stupid folder scan settings.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1275919
      f47708a2
    • Michael Pyne's avatar
      SVN_SILENT Bump version for KDE 4.9(?) · 2f8f6816
      Michael Pyne authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1275918
      2f8f6816
    • Michael Pyne's avatar
      Don't load a playlist if it's already found by folder scan. · 0663b609
      Michael Pyne authored
      The way file scanning is performed, it's possible for a playlist that is stored
      with a .m3u file to be found and loaded before JuK has finished loading its
      cached playlists.
      
      There's a few ways to fix this, but the most conservative (especially for those
      dealing with this bug for awhile) is to filter playlists as they are being
      loaded from the cache and remove any that have already been loaded. This also does not
      require a change to the QDataStream binary format used for saving playlists.
      
      This should fix a bug that's been open for more than five years now... by the
      way, anyone want to help with finding/fixing more JuK bugs? :D
      
      BUG:113769
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1275917
      0663b609
  4. 10 Jan, 2012 1 commit
    • Yury Kudryashov's avatar
      Remove unused constructor · 05d0e677
      Yury Kudryashov authored
      The constructor
      CacheDataStream::CacheDataStream(QByteArray &a, int mode)
      used Qt3Support
      QDataStream::QDataStream(QByteArray *, int)
      constructor and is not used itself.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1272994
      05d0e677
  5. 03 Jan, 2012 1 commit
  6. 17 Dec, 2011 1 commit
  7. 23 Nov, 2011 1 commit
  8. 08 Oct, 2011 1 commit
  9. 07 Sep, 2011 1 commit
  10. 05 Sep, 2011 1 commit
  11. 10 Aug, 2011 4 commits
    • Jan Gerrit Marker's avatar
      juk: Cleanup and make unmuting work · 9b925dcd
      Jan Gerrit Marker authored
      Restore the old volume when unmuting JuK. The value before
      the mute is hold in a membervariable of the mute/unmute
      button (the PlayerManager does not seem to keep it).
      Cleans up some pointer declarations (->Class *variable)
      according to KDElibs. Furthermore a new string for the
      mute/unmute button is added ("Mute/Unmute" for the tooltip).
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1246207
      9b925dcd
    • Jan Gerrit Marker's avatar
      Correct WhatsThisToolip's text of the guesser configuration · a0957f41
      Jan Gerrit Marker authored
      dialog to reflect the UI.
      
      CCBUG: 245533
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1246190
      a0957f41
    • Jan Gerrit Marker's avatar
      juk: Style fix and filter fix · 06ea5a2f
      Jan Gerrit Marker authored
      If artist was empty and you clicked on the album name
      of the now playing track you did get an empty list
      instead of a list of the album's songs.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1246186
      06ea5a2f
    • Jan Gerrit Marker's avatar
      juk: fix krazy issues · ce54b479
      Jan Gerrit Marker authored
      Fixes some issues krazy points out.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1246183
      ce54b479
  12. 31 Jul, 2011 1 commit
  13. 06 Jul, 2011 1 commit
  14. 30 Jun, 2011 1 commit
  15. 19 Jun, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: fix crash when adding items to toolbars with RMB. · dcb6da31
      Giorgos Kylafas authored
      When adding an item to a toolbar using right-click, the KXMLGUIClient
      object of the global action collection is accessed.
      (see KMenuMenuHandler::slotAddToToolBar() )
      The way the action collection was created meant the object was NULL,
      which resulted in crashes.
      So, create the action collection with KXMLGUIClient::actionCollection(),
      which properly sets the object.
      
      CCBUG: 258641
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1237516
      dcb6da31
  16. 16 Jun, 2011 4 commits
  17. 11 Jun, 2011 3 commits
    • Raphael Kubo da Costa's avatar
      Replace the deprecated QStatusBar::message() call with QStatusBar::showMessage() · f1ac8c2b
      Raphael Kubo da Costa authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1236163
      f1ac8c2b
    • Giorgos Kylafas's avatar
      juk: no crash-on-exit while playing, no matter how we exit. · af7271f4
      Giorgos Kylafas authored
      Since r921339, we stop the playback during exit, otherwise some phonon
      backends will crash. However, the relevant code was only executed when
      selecting "File->Quit", not when closing the window nor when quitting
      from the system tray.
      
      So, similarly to r1236077, put the stopping of playback into queryExit()
      to get executed in every case.
      
      Being in queryExit() means quit() has already been called. So, we can no
      longer wait for Phonon's StoppedState and then call quit(), as was done
      in r921339.
      However, waiting for Phonon's state change does not seem to be necessary
      any more, so we can safely remove slotPlaybackStopped().
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1236082
      af7271f4
    • Giorgos Kylafas's avatar
      juk: save the collection list cache no matter how the app exits. · d34bf39f
      Giorgos Kylafas authored
      Cache::save() was called from JuK::slotQuit(), which was triggered only
      by "File->Quit". So, the cache was not saved when closing the window or
      right-clicking the system tray and selecting "Quit",
      
      JuK::queryExit() is called in every case, so put Cache::save() there.
      Besides, according to KMainWindow's documentation, "a typical usage of
      queryExit() is to write configuration data back".
      
      While at it, remove saveConfig() from slotQuit(), since it is already
      being called from queryExit().
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1236077
      d34bf39f
  18. 09 Jun, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: keep the order of tracks when loading a plain playlist. · 174c0a68
      Giorgos Kylafas authored
      Plain Playlists are saved by explicitly writting the filenames of the
      tracks they contain (in contrast, SearchPlaylists store only their
      search pattern and FolderPlaylists only their folder). The filenames are
      written to the disk in the order they appear in the playlist.
      
      So, when loading such Playlists, disable sorting before adding the
      tracks, so that they appear in the order they were saved.
      
      CCBUG: 70402
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1235751
      174c0a68
  19. 06 Jun, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: load search playlists even when containing empty patterns. · aefff3f3
      Giorgos Kylafas authored
      When a new search playlist is created, we are allowed to not fill any
      "search lines" with our criteria. This means that when a new search
      playlist is created/saved, it may contain search components with empty
      patterns. However, when loading a search playlist from disk, we signal
      an error if we read an empty search pattern. As a result, the playlist
      does not get loaded and JuK gives the impression that it does not save
      the search playlists.
      
      Since we are presented with two search lines when creating a new search
      playlist (see AdvancedSearchDialog's ctor), the above has a rather high
      chance of happening.
      
      So, upon loading, we should not consider the presense of empty patterns
      as an error.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1235482
      aefff3f3
  20. 01 Jun, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: show only the selected columns in new playlists. · be36fe1b
      Giorgos Kylafas authored
      Whenever a new playlist was created (e.g. "File->New->Empty Playlist", a
      DynamicPlaylist is created etc.), all the available columns were shown
      instead of only those that the user had selected.
      
      The problem was that slotInitialize() (which adds all the columns to the
      playlist) was called _after_ Playlist::SharedSettings::apply() (which
      sets the visible and hidden columns).
      
      So, make sure slotInitialize() is called during the Playlist ctor.
      
      This commit is against trunk.
      CCBUG: 243449
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1234560
      be36fe1b
  21. 24 May, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: fix showing the items of all the selected playlists. · aded1d93
      Giorgos Kylafas authored
      When two or more playlists are selected from the PlaylistBox to the
      left, a dynamic playlist is used which shows the union of their
      contents. However, the first time this dynamic playlist is created, it
      has to be set up properly, otherwise only the contents of the first
      selected playlist will be shown.
      
      More specifically, if it is not set up, i.e. not added to the stack of
      playlists, QStackedWidget::setCurrentWidget() fails complaining that
      "widget 0x... not contained in stack".
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1233429
      aded1d93
  22. 18 May, 2011 1 commit
  23. 17 May, 2011 1 commit
    • Pino Toscano's avatar
      fixuifiles · 176e0f56
      Pino Toscano authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1232440
      176e0f56
  24. 15 May, 2011 7 commits