GitLab

until I get history saving / restoring working.  Thanks to cartman for
catching this.

CCMAIL:kde@myrealbox.com

svn path=/trunk/kdemultimedia/juk/; revision=242385

a pointer to a list.  Add the m_ prefix to member variables.  General style
cleanups.

svn path=/trunk/kdemultimedia/juk/; revision=242288

svn path=/trunk/kdemultimedia/juk/; revision=242278

svn path=/trunk/kdemultimedia/juk/; revision=242277

constructors (and add member variables and such).  More to come.

svn path=/trunk/kdemultimedia/juk/; revision=242200

destructor isn't virtual and (b) this doesn't do anything.

svn path=/trunk/kdemultimedia/juk/; revision=242194

i.e. "Mile Davis" will also match "Miles Davis and Cannonball Adderley" but
"exact match" for genres and albums -- "Rock" won't contain "Classic Rock".

svn path=/trunk/kdemultimedia/juk/; revision=242190

to remove duplicate code from SearchPlaylist (a subclass).

This also fixes the bug that search and dynamic playlist are now updated
when the playlists they're composed from change.

svn path=/trunk/kdemultimedia/juk/; revision=241986

next time around when things do break.

svn path=/trunk/kdemultimedia/juk/; revision=241979

svn path=/trunk/kdemultimedia/juk/; revision=241978

svn path=/trunk/kdemultimedia/juk/; revision=241969

svn path=/trunk/kdemultimedia/juk/; revision=241940

the history view should properly update the columns in the normal list view.

svn path=/trunk/kdemultimedia/juk/; revision=241921

svn path=/trunk/kdemultimedia/juk/; revision=241886

*) Don't add new history items when playing items *from* the history

svn path=/trunk/kdemultimedia/juk/; revision=241804

svn path=/trunk/kdemultimedia/juk/; revision=241802

3.1 compatibility has been dropped, remove it from here.

svn path=/trunk/kdemultimedia/juk/; revision=241801

Added new virtual methods to Playlist -- readOnly() and columnOffset().

columnOffset() indicates the position at which the Playlist class can expect
to find the standard set of columns.  This let me add a "time" column to
the history playlist.

I adjusted the code in other places to use these two new methods.

Also allow the history playlist to have multiple copies of the same item;
this is still buggy at the moment since this API feature hadn't yet been
used.

svn path=/trunk/kdemultimedia/juk/; revision=241800

nearest item.  Make sure that the nearest item has a valid playlist
associated with it or find one that does.

CCMAIL:62302-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=241786

TODO:

*) Save and restore the history -- this will be handled at the same time
   that saving and restoring of vfolders happens
*) Fill in the details of the subclass to add things like making it read
   only and saving a date along with the items

svn path=/trunk/kdemultimedia/juk/; revision=241664

code but still create their own subclasses of PlaylistItem.

svn path=/trunk/kdemultimedia/juk/; revision=241663

item.

svn path=/trunk/kdemultimedia/juk/; revision=241569

moment.  Please test and reopen if problems continue.

CCMAIL:61105-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=241494

don't start or end with a "word character" (as defined by QRegExp).

CCMAIL:62300-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=241468

end of the listview.

CCMAIL:62306-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=241397

CCMAIL:62311-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=241386

svn path=/trunk/kdemultimedia/juk/; revision=241192

*) Make it possible to use the "create group from selection" from any
   playlist, not just the collection.
*) Add tag guessing stuff to the RMB menu.

CCMAIL:61182-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=241178

before removing the ones that the user has asked to delete.

svn path=/trunk/kdemultimedia/juk/; revision=241102

svn path=/trunk/kdemultimedia/juk/; revision=241098

kind of work.

Outstanding issues:
*) They aren't saved and restored properly
*) The "more" and "fewer" buttons in the dialog don't do anything
*) The stuff for marking a playlist "dirty" isn't really working so the
   search might not be updated when the data in the collection list
   changes

But this all will follow shortly.

CCMAIL:55524-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=241062

svn path=/trunk/kdemultimedia/juk/; revision=241058

when executed.  The last step will come soon when a SearchPlaylist is
created by the PlaylistSplitter using this search.

svn path=/trunk/kdemultimedia/juk/; revision=241056

svn path=/trunk/kdemultimedia/juk/; revision=240931

over hacks to make it work with 3.1 libs.

svn path=/trunk/kdemultimedia/juk/; revision=240929

svn path=/trunk/kdemultimedia/juk/; revision=240842

* Small optimization

svn path=/trunk/kdemultimedia/juk/; revision=240833

will come.

svn path=/trunk/kdemultimedia/juk/; revision=240635

last commit; all should work now again.

svn path=/trunk/kdemultimedia/juk/; revision=240634

you check to make sure that I didn't leave anything out (that needs to be
there)?

=== from the mail with the patch ===
 The following issues are corected:
- files moved in a lists always get moved below an item dropped on, but the
  ui shows insertion marks above when moving above the upper half of an item.
- files dropped or pasted at a specific position in a playlist get added
  on top
- new items get always added at top of a playlist. It should be better to add
  them at  the end, especially if someone adds items to a playing list.
- multiple items get added in reversed order.

Detailed changes:

- insert before an item when dropping on the upper half of an item.
- Playlist signalFilesDroped, decode and
  PlaylistSplitter slotAddToPlaylist, addImpl are extended by the item
  after which the files should be added.
- The slotAddToPlaylist method without insert position now add items at the
  end of a list.
- remove decode method from CollectionList, it's duplicated from Playlist.

CCMAIL:hel@admin.de

svn path=/trunk/kdemultimedia/juk/; revision=240632