1. 19 Jun, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: fix crash when adding items to toolbars with RMB. · dcb6da31
      Giorgos Kylafas authored
      When adding an item to a toolbar using right-click, the KXMLGUIClient
      object of the global action collection is accessed.
      (see KMenuMenuHandler::slotAddToToolBar() )
      The way the action collection was created meant the object was NULL,
      which resulted in crashes.
      So, create the action collection with KXMLGUIClient::actionCollection(),
      which properly sets the object.
      
      CCBUG: 258641
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1237516
      dcb6da31
  2. 16 Jun, 2011 4 commits
  3. 11 Jun, 2011 3 commits
    • Raphael Kubo da Costa's avatar
      Replace the deprecated QStatusBar::message() call with QStatusBar::showMessage() · f1ac8c2b
      Raphael Kubo da Costa authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1236163
      f1ac8c2b
    • Giorgos Kylafas's avatar
      juk: no crash-on-exit while playing, no matter how we exit. · af7271f4
      Giorgos Kylafas authored
      Since r921339, we stop the playback during exit, otherwise some phonon
      backends will crash. However, the relevant code was only executed when
      selecting "File->Quit", not when closing the window nor when quitting
      from the system tray.
      
      So, similarly to r1236077, put the stopping of playback into queryExit()
      to get executed in every case.
      
      Being in queryExit() means quit() has already been called. So, we can no
      longer wait for Phonon's StoppedState and then call quit(), as was done
      in r921339.
      However, waiting for Phonon's state change does not seem to be necessary
      any more, so we can safely remove slotPlaybackStopped().
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1236082
      af7271f4
    • Giorgos Kylafas's avatar
      juk: save the collection list cache no matter how the app exits. · d34bf39f
      Giorgos Kylafas authored
      Cache::save() was called from JuK::slotQuit(), which was triggered only
      by "File->Quit". So, the cache was not saved when closing the window or
      right-clicking the system tray and selecting "Quit",
      
      JuK::queryExit() is called in every case, so put Cache::save() there.
      Besides, according to KMainWindow's documentation, "a typical usage of
      queryExit() is to write configuration data back".
      
      While at it, remove saveConfig() from slotQuit(), since it is already
      being called from queryExit().
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1236077
      d34bf39f
  4. 09 Jun, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: keep the order of tracks when loading a plain playlist. · 174c0a68
      Giorgos Kylafas authored
      Plain Playlists are saved by explicitly writting the filenames of the
      tracks they contain (in contrast, SearchPlaylists store only their
      search pattern and FolderPlaylists only their folder). The filenames are
      written to the disk in the order they appear in the playlist.
      
      So, when loading such Playlists, disable sorting before adding the
      tracks, so that they appear in the order they were saved.
      
      CCBUG: 70402
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1235751
      174c0a68
  5. 06 Jun, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: load search playlists even when containing empty patterns. · aefff3f3
      Giorgos Kylafas authored
      When a new search playlist is created, we are allowed to not fill any
      "search lines" with our criteria. This means that when a new search
      playlist is created/saved, it may contain search components with empty
      patterns. However, when loading a search playlist from disk, we signal
      an error if we read an empty search pattern. As a result, the playlist
      does not get loaded and JuK gives the impression that it does not save
      the search playlists.
      
      Since we are presented with two search lines when creating a new search
      playlist (see AdvancedSearchDialog's ctor), the above has a rather high
      chance of happening.
      
      So, upon loading, we should not consider the presense of empty patterns
      as an error.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1235482
      aefff3f3
  6. 01 Jun, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: show only the selected columns in new playlists. · be36fe1b
      Giorgos Kylafas authored
      Whenever a new playlist was created (e.g. "File->New->Empty Playlist", a
      DynamicPlaylist is created etc.), all the available columns were shown
      instead of only those that the user had selected.
      
      The problem was that slotInitialize() (which adds all the columns to the
      playlist) was called _after_ Playlist::SharedSettings::apply() (which
      sets the visible and hidden columns).
      
      So, make sure slotInitialize() is called during the Playlist ctor.
      
      This commit is against trunk.
      CCBUG: 243449
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1234560
      be36fe1b
  7. 24 May, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: fix showing the items of all the selected playlists. · aded1d93
      Giorgos Kylafas authored
      When two or more playlists are selected from the PlaylistBox to the
      left, a dynamic playlist is used which shows the union of their
      contents. However, the first time this dynamic playlist is created, it
      has to be set up properly, otherwise only the contents of the first
      selected playlist will be shown.
      
      More specifically, if it is not set up, i.e. not added to the stack of
      playlists, QStackedWidget::setCurrentWidget() fails complaining that
      "widget 0x... not contained in stack".
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1233429
      aded1d93
  8. 18 May, 2011 1 commit
  9. 17 May, 2011 1 commit
    • Pino Toscano's avatar
      fixuifiles · 176e0f56
      Pino Toscano authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1232440
      176e0f56
  10. 15 May, 2011 10 commits
  11. 13 May, 2011 1 commit
  12. 11 May, 2011 4 commits
    • Michael Pyne's avatar
      juk: Remove KPixmapCache, more simplification. · e01b9b83
      Michael Pyne authored
      With only a few SVG elements in use, at an essentially fixed size, a cache
      becomes highly overkill (and even if not, KPixmapCache has issues, although I
      am biased...), so just use a simple QMap to cache generated SVG elements.
      
      I could probably go farther (e.g. remove locking) and I'm sure there's headers
      that could be removed, but I think this is fairly low-fat again in keeping with
      the spirit of the code committed yesterday. :-)
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1231346
      e01b9b83
    • Michael Pyne's avatar
      juk: Dead code removal, Simplification of SVG Handler. · 3f522b46
      Michael Pyne authored
      Removed more unneeded code in the SVG Handler, and removed the (in our case)
      needless ability to have multiple SVG renderers since we only have the one
      SVG theme file.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1231344
      3f522b46
    • Michael Pyne's avatar
      juk: Reduce SVG theme size. · c758b405
      Michael Pyne authored
      The previous theme SVG was basically Amarok's default-theme-clean with excess
      information mostly removed by editing in Inkscape.
      
      For this I just manually added elements we actually use into an empty shell
      XML, and any cross-referenced elements. The result is much smaller, and both
      appears the same and the SVG handling code doesn't complain about missing
      elements.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1231341
      c758b405
    • Michael Pyne's avatar
      juk: No need to copy dead code from Amarok svg handler. · 78e56b5c
      Michael Pyne authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1231340
      78e56b5c
  13. 10 May, 2011 5 commits
  14. 09 May, 2011 3 commits
    • Giorgos Kylafas's avatar
      juk: save & restore playlist and tag editor sizes. · 0a9a71c9
      Giorgos Kylafas authored
      editorSplitter is turned to a member variable (m_editorSplitter) whose
      sizes are stored and retrieved the same way as PlaylistSplitter's.
      
      If no sizes were saved, use default sizes for the playlist and the
      editor. The values are just hints for the actual size, m_editorSplitter
      will distribute the space according to their relative weight.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1231059
      0a9a71c9
    • Scott Wheeler's avatar
      Switch to Amarok's volume / track polition sliders. · 5487fcaa
      Scott Wheeler authored
      There's a lot that still seems wonky, but it seems to all be Phonon
      breakage that I can reproduce with the version pre-changeset.
      
      Specifically Phonon (or its backends) seem quite fickle about when
      they've decided that seeking is enabled.  The crossfading code seems
      to compound this, but again, this does not seem to be a regression
      from the previous code.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1231011
      5487fcaa
    • Yuri Chornoivan's avatar
      fix typo: chose->choose · e43aa99e
      Yuri Chornoivan authored
      http://www.merriam-webster.com/dictionary/choose
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1230971
      e43aa99e
  15. 08 May, 2011 3 commits