1. 19 Dec, 2018 2 commits
    • Michael Pyne's avatar
      Use a thread pool for the threaded music loader. · eb4a4d15
      Michael Pyne authored
      Large music libraries can cause dozens/hundreds or even more of threads
      to be created at once. But all we really need is to do the loading off
      of the GUI thread, and the I/O will be the bottleneck no matter how many
      threads we use. So use Qt Concurrent to manage a threadpool instead,
      which also simplifies the code somewhat.
      
      I also fixed the broken global status updating when using threaded
      loader while refactoring to support this.
      eb4a4d15
    • Michael Pyne's avatar
      Move initial music load to a separate thread. · 3cf74c35
      Michael Pyne authored
      I ran into all the problems one might expect from adding threading to an
      old codebase but this variant seems pretty stable.
      
      The benefit is that the heavy I/O with large music libraries is now off
      of the GUI thread. So even though it will still take awhile to load all
      music until I fix the bug(s) with using cached tags, at least the
      application itself will be responsive while it loads audio.
      3cf74c35
  2. 12 Dec, 2018 1 commit
  3. 01 Dec, 2018 3 commits
  4. 26 Nov, 2018 1 commit
  5. 11 Nov, 2018 5 commits
    • Michael Pyne's avatar
      Merge branch 'Applications/18.12' · 6a35bbe0
      Michael Pyne authored
      6a35bbe0
    • Michael Pyne's avatar
      hidpi: Port remaining icon uses to use QIcon for HiDPI support. · 1862b0f6
      Michael Pyne authored
      GUI: This fixes things like the warning icons in the file deletion
      dialog, file renamer, menu icons (such as Create Playlist from Selected
      Items), and the "Jump to Playing Track" button on the status bar.
      
      The track position slider remains unfixed.
      1862b0f6
    • Michael Pyne's avatar
      hidpi: Mark cover art as being at native display resolution. · c31920fa
      Michael Pyne authored
      This lets Hi-DPI displays to show cover art (when clicking the cover in
      the "Now Playing" bar) at its native resolution even when using screen
      scaling.
      
      This is probably suboptimal for smaller covers but most embedded cover
      art I find in the recent few years is already more than large enough to
      show up fine this way.
      
      CHANGELOG: Show embedded music cover art at native display resolution.
      c31920fa
    • Michael Pyne's avatar
      Merge branch 'Applications/18.12' · 89ceeb08
      Michael Pyne authored
      Conflicts:
      	CMakeLists.txt
      89ceeb08
    • Michael Pyne's avatar
      Enable Qt support for High DPI icons. · 0ad0ee58
      Michael Pyne authored
      As submitted by Guo Yunhe <i@guoyunhe.me> on kde-multimedia.
      
      In my testing this only applies with QT_AUTO_SCREEN_SCALE_FACTOR
      environment variable enabled, but does indeed allow for many (not all)
      pixmaps to automatically load high-res versions (such as from
      KIconLoader).
      
      I consider this a bugfix and the support is non-invasive, so applying to
      18.12 and will merge to master separately.
      
      Note that the cover art and slider art is still suboptimal.
      0ad0ee58
  6. 10 Nov, 2018 1 commit
  7. 09 Nov, 2018 2 commits
  8. 07 Nov, 2018 1 commit
  9. 20 Oct, 2018 2 commits
    • Michael Pyne's avatar
      Merge branch 'Applications/18.08' · b4cdf1c1
      Michael Pyne authored
      Conflicts:
      	playermanager.cpp
      b4cdf1c1
    • Michael Pyne's avatar
      systray: Make SHIFT+Mousewheel change the volume, not the song. · e2012e79
      Michael Pyne authored
      This fixes a bug that recently hit its 8 year anniversary. :(
      
      The big issue was that there was no easy way to tell which keyboard
      modifiers were set for the systray since Qt's event loop didn't actually
      receive the keyboard events.
      
      There's a separate function you can call, queryKeyboardModifiers, which
      makes a specific query to the desktop, and works even if Qt event loop
      didn't receive keyboard events. This fixes the bug here, and hopefully
      for everyone else.
      
      In fixing the bug I noticed that we can set out-of-bounds volumes due to
      lack of checking, so I fixed that too.
      
      BUG:250355
      FIXED-IN:18.08.3
      e2012e79
  10. 19 Oct, 2018 6 commits
  11. 10 Oct, 2018 2 commits
  12. 07 Oct, 2018 3 commits
  13. 03 Oct, 2018 1 commit
  14. 26 Sep, 2018 1 commit
    • Luigi Toscano's avatar
      LyricWiki: link to the actual lyrics page · eb1d9b62
      Luigi Toscano authored
      Summary:
      Instead of pointing to the homepage of the wiki,
      set the link to the actual page of the lyrics
      which are being shown.
      
      BUG: 332664
      FIXED-IN: 18.12.0
      
      Test Plan:
      The link to the LyricsWiki points to the actual page.
      Nothing changes when the lyrics are not found.
      
      Reviewers: mpyne
      
      Reviewed By: mpyne
      
      Differential Revision: https://phabricator.kde.org/D15303
      eb1d9b62
  15. 23 Sep, 2018 1 commit
  16. 22 Sep, 2018 2 commits
  17. 02 Sep, 2018 2 commits
  18. 31 Aug, 2018 1 commit
  19. 19 Aug, 2018 2 commits
  20. 18 Aug, 2018 1 commit